public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch 2/8] IntelSiliconPkg: Fix format issues
Date: Mon, 19 Dec 2016 07:32:24 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8C63A9@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1482132023-10416-3-git-send-email-dandan.bi@intel.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, December 19, 2016 3:20 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch 2/8] IntelSiliconPkg: Fix format issues
> 
> 1. Fix doxygen formt
> 2. Fix Guid format
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h   | 2 +-
>  IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h      | 2 +-
>  IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h              | 2 +-
>  IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.c   | 2 +-
>  IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.inf | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h
> b/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h
> index 39f20ea..cdc080b 100644
> --- a/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h
> +++ b/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h
> @@ -1,9 +1,9 @@
>  /** @file
>    FirmwareInterfaceTable (FIT) related definitions.
> 
> -  @todo: update document/spec reference
> +  @todo update document/spec reference
> 
>    Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be
> found at
> diff --git a/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> b/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> index b982d79..bcb741f 100644
> --- a/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> +++ b/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> @@ -1,9 +1,9 @@
>  /** @file
>    Intel Firmware Version Info (FVI) related definitions.
> 
> -  @todo: update document/spec reference
> +  @todo update document/spec reference
> 
>    Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be
> found at
> diff --git a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> index fd6f813..5ce80a5 100644
> --- a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> +++ b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> @@ -29,11 +29,11 @@
>  /**
>    OpRegion structures:
>    Sub-structures define the different parts of the OpRegion followed by the
>    main structure representing the entire OpRegion.
> 
> -  @note: These structures are packed to 1 byte offsets because the exact
> +  @note These structures are packed to 1 byte offsets because the exact
>    data location is required by the supporting design specification due to
>    the fact that the data is used by ASL and Graphics driver code compiled
>    separately.
>  **/
>  #pragma pack(1)
> diff --git
> a/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.c
> b/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.c
> index 8d513e0..facab9a 100644
> --- a/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.c
> +++ b/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.c
> @@ -28,11 +28,11 @@
>  #include <Protocol/Smbios.h>
> 
>  /**
> 
>    Get the full size of SMBIOS structure including optional strings that follow the
> formatted structure.
> -  @note: This function is copy from SmbiosDxe in MdeModulePkg.
> +  @note This function is copy from SmbiosDxe in MdeModulePkg.
> 
>    @param[in] This                 The EFI_SMBIOS_PROTOCOL instance.
>    @param[in] Head                 Pointer to the beginning of SMBIOS
> structure.
>    @param[out] Size                The returned size.
>    @param[out] NumberOfStrings     The returned number of optional strings
> that follow the formatted structure.
> diff --git
> a/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.inf
> b/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.inf
> index afac26f..4fb2551 100644
> --- a/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.inf
> +++ b/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.inf
> @@ -35,10 +35,10 @@ [LibraryClasses]
>  BaseLib
>  HobLib
>  UefiLib
> 
>  [Guids]
> -gIntelSmbiosDataHobGuid ## CONSUMES
> +gIntelSmbiosDataHobGuid ## CONSUMES   ## GUID
> 
>  [Depex]
>  gEfiSmbiosProtocolGuid
> 
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2016-12-19  7:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19  7:20 [patch 0/8] Fix coding style issues Dandan Bi
2016-12-19  7:20 ` [patch 1/8] SecurityPkg/FmpAuthenticationLib: Fix Guid format issues Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 2/8] IntelSiliconPkg: Fix " Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen [this message]
2016-12-19  7:20 ` [patch 3/8] MdeModulePkg/CapsuleApp: Fix Guid " Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follow rules Dandan Bi
2016-12-19  7:33   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 5/8] MdeModulePkg/EmmcDxe: Avoid Non-Boolean type used as Boolean Dandan Bi
2016-12-19  7:38   ` Tian, Feng
2016-12-19  7:20 ` [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration Dandan Bi
2016-12-20  1:14   ` Tian, Feng
2016-12-19  7:20 ` [patch 7/8] MdeModulePkg/SataControllerDxe: Fix coding style issue Dandan Bi
2016-12-20  1:18   ` Tian, Feng
2016-12-19  7:20 ` [patch 8/8] MdeModulePkg/NonDiscoverableDeviceRegistrationLib: Fix coding style issues Dandan Bi
2016-12-19 13:44   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A8C63A9@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox