public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch 1/8] SecurityPkg/FmpAuthenticationLib: Fix Guid format issues
Date: Mon, 19 Dec 2016 07:32:38 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8C63BA@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1482132023-10416-2-git-send-email-dandan.bi@intel.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, December 19, 2016 3:20 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch 1/8] SecurityPkg/FmpAuthenticationLib: Fix Guid format issues
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  .../Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf   | 2 +-
>  .../FmpAuthenticationLibRsa2048Sha256.inf                             | 4
> ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.i
> nf
> b/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.i
> nf
> index bce958d..215b3cb 100644
> ---
> a/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.i
> nf
> +++
> b/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.i
> nf
> @@ -44,6 +44,6 @@ [LibraryClasses]
>    DebugLib
>    MemoryAllocationLib
>    BaseCryptLib
> 
>  [Guids]
> -  gEfiCertPkcs7Guid        ## CONSUMES
> +  gEfiCertPkcs7Guid        ## CONSUMES   ## GUID
> diff --git
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationL
> ibRsa2048Sha256.inf
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthentication
> LibRsa2048Sha256.inf
> index b58966d..633f407 100644
> ---
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationL
> ibRsa2048Sha256.inf
> +++
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthentication
> LibRsa2048Sha256.inf
> @@ -47,7 +47,7 @@ [LibraryClasses]
> 
>  [Pcd]
>    gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer     ##
> CONSUMES
> 
>  [Guids]
> -  gEfiCertTypeRsa2048Sha256Guid         ## CONSUMES
> -  gEfiHashAlgorithmSha256Guid           ## CONSUMES
> +  gEfiCertTypeRsa2048Sha256Guid         ## CONSUMES   ## GUID
> +  gEfiHashAlgorithmSha256Guid           ## CONSUMES   ## GUID
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2016-12-19  7:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19  7:20 [patch 0/8] Fix coding style issues Dandan Bi
2016-12-19  7:20 ` [patch 1/8] SecurityPkg/FmpAuthenticationLib: Fix Guid format issues Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen [this message]
2016-12-19  7:20 ` [patch 2/8] IntelSiliconPkg: Fix " Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 3/8] MdeModulePkg/CapsuleApp: Fix Guid " Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follow rules Dandan Bi
2016-12-19  7:33   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 5/8] MdeModulePkg/EmmcDxe: Avoid Non-Boolean type used as Boolean Dandan Bi
2016-12-19  7:38   ` Tian, Feng
2016-12-19  7:20 ` [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration Dandan Bi
2016-12-20  1:14   ` Tian, Feng
2016-12-19  7:20 ` [patch 7/8] MdeModulePkg/SataControllerDxe: Fix coding style issue Dandan Bi
2016-12-20  1:18   ` Tian, Feng
2016-12-19  7:20 ` [patch 8/8] MdeModulePkg/NonDiscoverableDeviceRegistrationLib: Fix coding style issues Dandan Bi
2016-12-19 13:44   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A8C63BA@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox