From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4934682094 for ; Sun, 18 Dec 2016 23:33:26 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 18 Dec 2016 23:33:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,372,1477983600"; d="scan'208";a="44362714" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 18 Dec 2016 23:33:22 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 18 Dec 2016 23:33:21 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 18 Dec 2016 23:33:21 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.54]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.77]) with mapi id 14.03.0248.002; Mon, 19 Dec 2016 15:33:17 +0800 From: "Yao, Jiewen" To: "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follow rules Thread-Index: AQHSWciI1CgEIZEjtk69p1Is7UrdoKEO4LmA Date: Mon, 19 Dec 2016 07:33:17 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8C63E1@shsmsx102.ccr.corp.intel.com> References: <1482132023-10416-1-git-send-email-dandan.bi@intel.com> <1482132023-10416-5-git-send-email-dandan.bi@intel.com> In-Reply-To: <1482132023-10416-5-git-send-email-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follow rules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 07:33:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Dandan Bi > Sent: Monday, December 19, 2016 3:20 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follo= w > rules >=20 > For variable name, it should contain lower case characters. >=20 > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > .../Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 8 ++++---- > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h | 2 +- > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c | 18 > +++++++++--------- > 3 files changed, 14 insertions(+), 14 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c > b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c > index 9c5707e..ba62c6a 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c > @@ -164,21 +164,21 @@ DebuggerDisplaySymbolAccrodingToAddress ( > EDBPrint (L" Address Type Symbol\n"); > EDBPrint (L" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D\n"); > // EDBPrint (L" 0xFFFFFFFF00000000 ( F) TestMain\n"); > EDBPrint ( > L" 0x%016lx %s %a\n", > - (UINT64)Entry->RVA + Object->BaseAddress, > + (UINT64)Entry->Rva + Object->BaseAddress, > EdbSymbolTypeToStr (Entry->Type), > Entry->Name > ); > } else { > EDBPrint (L" Address Type Symbol\n"); > EDBPrint (L" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D =3D=3D=3D= =3D=3D=3D=3D=3D\n"); > // EDBPrint (L" 0xFFFF0000 ( F) TestMain\n"); > EDBPrint ( > L" 0x%08x %s %a\n", > - Entry->RVA + Object->BaseAddress, > + Entry->Rva + Object->BaseAddress, > EdbSymbolTypeToStr (Entry->Type), > Entry->Name > ); > } >=20 > @@ -271,19 +271,19 @@ DebuggerDisplaySymbolAccrodingToName ( > } >=20 > if (sizeof(UINTN) =3D=3D sizeof(UINT64)) { > EDBPrint ( > L" 0x%016lx %s %a (%a)\n", > - (UINT64)Entry->RVA + Object->BaseAddress, > + (UINT64)Entry->Rva + Object->BaseAddress, > EdbSymbolTypeToStr (Entry->Type), > Entry->Name, > Entry->ObjName > ); > } else { > EDBPrint ( > L" 0x%08x %s %a (%a)\n", > - Entry->RVA + Object->BaseAddress, > + Entry->Rva + Object->BaseAddress, > EdbSymbolTypeToStr (Entry->Type), > Entry->Name, > Entry->ObjName > ); > } > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h > b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h > index 2a54be1..d452b2b 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h > @@ -88,11 +88,11 @@ typedef enum { > EfiDebuggerSymbolTypeMax, > } EFI_DEBUGGER_SYMBOL_TYPE; >=20 > typedef struct { > CHAR8 > Name[EFI_DEBUGGER_SYMBOL_NAME_MAX]; > - UINTN RVA; > + UINTN Rva; > EFI_DEBUGGER_SYMBOL_TYPE Type; > CHAR8 > ObjName[EFI_DEBUGGER_SYMBOL_NAME_MAX]; > CHAR8 *CodBuffer; > UINTN CodBufferSize; > UINTN FuncOffsetBase; > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c > b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c > index e6a677d..4e640ea 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c > @@ -65,11 +65,11 @@ EdbLoadSymbolSingleEntry ( > // > AsciiStrnCpyS (Entry->Name, sizeof(Entry->Name), Name, > sizeof(Entry->Name) - 1); > if (ObjName !=3D NULL) { > AsciiStrnCpyS (Entry->ObjName, sizeof(Entry->ObjName), ObjName, > sizeof(Entry->ObjName) - 1); > } > - Entry->RVA =3D Address % EFI_DEBUGGER_DEFAULT_LINK_IMAGEBASE; > + Entry->Rva =3D Address % EFI_DEBUGGER_DEFAULT_LINK_IMAGEBASE; > Entry->Type =3D Type; >=20 > // > // Increase Count > // > @@ -513,29 +513,29 @@ EbdFindSymbolAddress ( > // > // Go through each entry > // > Entry =3D Object->Entry; > for (SubIndex =3D 0; SubIndex < Object->EntryCount; SubIndex++, Entr= y++) { > - if (Address !=3D Entry->RVA + Object->BaseAddress) { > + if (Address !=3D Entry->Rva + Object->BaseAddress) { > // > // Check for nearest address > // > - if (Address > Entry->RVA + Object->BaseAddress) { > + if (Address > Entry->Rva + Object->BaseAddress) { > // > // Record it if Current RVA < Address > // > - if (CandidateLowerAddress < Entry->RVA + Object->BaseAddress) = { > - CandidateLowerAddress =3D Entry->RVA + Object->BaseAddress; > + if (CandidateLowerAddress < Entry->Rva + Object->BaseAddress) = { > + CandidateLowerAddress =3D Entry->Rva + Object->BaseAddress; > LowEntry =3D Entry; > LowObject =3D Object; > } > } else { > // > // Record it if Current RVA > Address > // > - if (CandidateUpperAddress > Entry->RVA + Object->BaseAddress) = { > - CandidateUpperAddress =3D Entry->RVA + Object->BaseAddress; > + if (CandidateUpperAddress > Entry->Rva + Object->BaseAddress) = { > + CandidateUpperAddress =3D Entry->Rva + Object->BaseAddress; > UpperEntry =3D Entry; > UpperObject =3D Object; > } > } > continue; > @@ -1710,11 +1710,11 @@ FindSymbolStr ( > Entry =3D Object[ObjectIndex].Entry; > for (EntryIndex =3D 0; EntryIndex < Object[ObjectIndex].EntryCount; > EntryIndex++) { > // > // if Address match, return Name > // > - if (Address =3D=3D (Entry[EntryIndex].RVA + > Object[ObjectIndex].BaseAddress)) { > + if (Address =3D=3D (Entry[EntryIndex].Rva + > Object[ObjectIndex].BaseAddress)) { > return Entry[EntryIndex].Name; > } > } > } >=20 > @@ -2217,11 +2217,11 @@ Symboltoi ( > return EFI_NO_MAPPING; > } else { > // > // record Address > // > - *Address =3D (Entry[EntryIndex].RVA + > Object[ObjectIndex].BaseAddress); > + *Address =3D (Entry[EntryIndex].Rva + > Object[ObjectIndex].BaseAddress); > } > } > } > } >=20 > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel