Re: [PATCH 1/2] MdePkg: Tpm2Acpi.h: Fix incompatible change

["Yao, Jiewen" <jiewen.yao@intel.com>]

Hi
Can we add more comment:
> +  //    BIT0~15:  PlatformClass // this field is only valid for version 4 and above.

With the comment update, reviewed-by: Jiewen.yao@intel.com

Thank you
Yao Jiewen

> -----Original Message-----
> From: Zhang, Chao B
> Sent: Wednesday, January 11, 2017 4:13 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH 1/2] MdePkg: Tpm2Acpi.h: Fix incompatible change
> 
> Fix incompatible change.  Some modules are still referencing old definition.
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> index 7578676..0ac1ae0 100644
> --- a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> +++ b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> @@ -21,11 +21,14 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY
> KIND, EITHER EXPRESS OR IMPLIED.
> 
>  #define EFI_TPM2_ACPI_TABLE_REVISION_3  3
>  #define EFI_TPM2_ACPI_TABLE_REVISION_4  4
> +#define EFI_TPM2_ACPI_TABLE_REVISION
> EFI_TPM2_ACPI_TABLE_REVISION_4
> 
>  typedef struct {
>    EFI_ACPI_DESCRIPTION_HEADER Header;
> -  UINT16                      PlatformClass;
> -  UINT16                      Reserved;
> +  // Flags field is replaced in version 4 and later
> +  //    BIT0~15:  PlatformClass
> +  //    BIT16~31: Reserved
> +  UINT32                      Flags;
>    UINT64                      AddressOfControlArea;
>    UINT32                      StartMethod;
>  //UINT8                       PlatformSpecificParameters[];
> --
> 1.9.5.msysgit.1