From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 71D8F81B4A for ; Wed, 11 Jan 2017 00:15:48 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 11 Jan 2017 00:15:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="921233604" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 11 Jan 2017 00:15:48 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 11 Jan 2017 00:15:48 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 11 Jan 2017 00:15:47 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Wed, 11 Jan 2017 16:15:45 +0800 From: "Yao, Jiewen" To: "Zhang, Chao B" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [PATCH 1/2] MdePkg: Tpm2Acpi.h: Fix incompatible change Thread-Index: AQHSa+KFAzbqA2ytmk6vuBqmf5iB9qEy7b/Q Date: Wed, 11 Jan 2017 08:15:44 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8DE7C0@shsmsx102.ccr.corp.intel.com> References: <20170111081243.20360-1-chao.b.zhang@intel.com> In-Reply-To: <20170111081243.20360-1-chao.b.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/2] MdePkg: Tpm2Acpi.h: Fix incompatible change X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 08:15:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Can we add more comment: > + // BIT0~15: PlatformClass // this field is only valid for version = 4 and above. With the comment update, reviewed-by: Jiewen.yao@intel.com Thank you Yao Jiewen > -----Original Message----- > From: Zhang, Chao B > Sent: Wednesday, January 11, 2017 4:13 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star ; > Zhang, Chao B > Subject: [PATCH 1/2] MdePkg: Tpm2Acpi.h: Fix incompatible change >=20 > Fix incompatible change. Some modules are still referencing old definiti= on. >=20 > Cc: Star Zeng > Cc: Yao Jiewen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chao Zhang > --- > MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h > b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h > index 7578676..0ac1ae0 100644 > --- a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h > +++ b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h > @@ -21,11 +21,14 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. >=20 > #define EFI_TPM2_ACPI_TABLE_REVISION_3 3 > #define EFI_TPM2_ACPI_TABLE_REVISION_4 4 > +#define EFI_TPM2_ACPI_TABLE_REVISION > EFI_TPM2_ACPI_TABLE_REVISION_4 >=20 > typedef struct { > EFI_ACPI_DESCRIPTION_HEADER Header; > - UINT16 PlatformClass; > - UINT16 Reserved; > + // Flags field is replaced in version 4 and later > + // BIT0~15: PlatformClass > + // BIT16~31: Reserved > + UINT32 Flags; > UINT64 AddressOfControlArea; > UINT32 StartMethod; > //UINT8 PlatformSpecificParameters[]; > -- > 1.9.5.msysgit.1