From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 94DE681B4A for ; Wed, 11 Jan 2017 00:18:10 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP; 11 Jan 2017 00:18:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="1092618797" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2017 00:17:58 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 11 Jan 2017 00:17:57 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Wed, 11 Jan 2017 16:17:54 +0800 From: "Yao, Jiewen" To: "Zhang, Chao B" , "edk2-devel@lists.01.org" CC: "Zhang, Chao B" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible change Thread-Index: AQHSa+KD/fuwgS6Y9UaPn2vt/gUIE6Ey7heQ Date: Wed, 11 Jan 2017 08:17:53 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8DE7D4@shsmsx102.ccr.corp.intel.com> References: <20170111081243.20360-1-chao.b.zhang@intel.com> <20170111081243.20360-2-chao.b.zhang@intel.com> In-Reply-To: <20170111081243.20360-2-chao.b.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible change X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 08:18:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi I think we should add assign PlatformClass to PcdGet8 (PcdTpmPlatformClass)= , if version is 4, to follow TCG spec. You may want to submit another patch to resolve. Reviewed-by: Jiewen.yao@intel.com Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zh= ang, > Chao B > Sent: Wednesday, January 11, 2017 4:13 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > ; Zeng, Star > Subject: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible change >=20 > Address incompatible change introduced in patch > 8f07a374b1d0497b6676491de8cbe2f08f4f7e9f >=20 > Cc: Star Zeng > Cc: Yao Jiewen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chao Zhang > --- > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c > b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c > index 1df2da8..0c3b19c 100644 > --- a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c > +++ b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c > @@ -77,14 +77,14 @@ EFI_TPM2_ACPI_TABLE mTpm2AcpiTemplate =3D { > { > EFI_ACPI_5_0_TRUSTED_COMPUTING_PLATFORM_2_TABLE_SIGNATURE, > sizeof (mTpm2AcpiTemplate), > - EFI_TPM2_ACPI_TABLE_REVISION_4, > + EFI_TPM2_ACPI_TABLE_REVISION, > // > // Compiler initializes the remaining bytes to 0 > // These fields should be filled in in production > // > }, > - 0, // 16-bit PlatformClass > - 0, // 16-bit Reserved > + 0, // BIT0~15: PlatformClass > + // BIT16~31: Reserved > 0, // Control Area > EFI_TPM2_ACPI_TABLE_START_METHOD_TIS, // StartMethod > }; > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel