From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7E30981F1A for ; Tue, 24 Jan 2017 18:18:07 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 24 Jan 2017 18:18:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,281,1477983600"; d="scan'208";a="1086952357" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 24 Jan 2017 18:18:06 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 24 Jan 2017 18:18:06 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 24 Jan 2017 18:18:05 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Wed, 25 Jan 2017 10:18:03 +0800 From: "Yao, Jiewen" To: "Zhang, Chao B" , "Zeng, Star" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 2/3] MdePkg: VariableDxe: Use UEFI_VARIABLE_DATA Thread-Index: AQHSdheX49RDUvZ3jk+HxmEdmCkxLqFGxo6AgAEoOwCAAIZ7QA== Date: Wed, 25 Jan 2017 02:18:02 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8E522A@shsmsx102.ccr.corp.intel.com> References: <20170124075732.27484-1-chao.b.zhang@intel.com> <20170124075732.27484-2-chao.b.zhang@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8199D3@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/3] MdePkg: VariableDxe: Use UEFI_VARIABLE_DATA X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 02:18:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you. I also think this is a right way to go. One observation I have is that we need use sizeof(TREE_BOOT_SERVICE_CAPABIL= ITY_1_0) in Tcg2Dxe. I think we can use OFFSET_OF(EFI_TCG2_BOOT_SERVICE_CAPABILITY , NumberOfPCR= Banks) to remove TrEE reference in Tcg2. Thank you Yao Jiewen > -----Original Message----- > From: Zhang, Chao B > Sent: Wednesday, January 25, 2017 10:13 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: RE: [edk2] [PATCH 2/3] MdePkg: VariableDxe: Use UEFI_VARIABLE_DA= TA >=20 > Star: > I agree. I will clean up other TrEEProtocol reference later on. >=20 > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, January 24, 2017 4:33 PM > To: Zhang, Chao B ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star > Subject: RE: [edk2] [PATCH 2/3] MdePkg: VariableDxe: Use UEFI_VARIABLE_DA= TA >=20 > Could we remove " #include " in Measurement.c? >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zh= ang, > Chao B > Sent: Tuesday, January 24, 2017 3:58 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > ; Zeng, Star > Subject: [edk2] [PATCH 2/3] MdePkg: VariableDxe: Use UEFI_VARIABLE_DATA >=20 > Use UEFI_VARIABLE_DATA data structure according to TCG PC-Client PFP Spec > 00.21. > http://www.trustedcomputinggroup.org/wp-content/uploads/PC-ClientSpecific > _Platform_Profile_for_TPM_2p0_Systems_v21.pdf >=20 > Cc: Star Zeng > Cc: Yao Jiewen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chao Zhang > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/Measurement.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Measurement.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/Measurement.c > index 309521f..b9febac 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Measurement.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Measurement.c > @@ -96,7 +96,7 @@ MeasureVariable ( > { > EFI_STATUS Status; > UINTN VarNameLength; > - EFI_VARIABLE_DATA_TREE *VarLog; > + UEFI_VARIABLE_DATA *VarLog; > UINT32 VarLogSize; >=20 > ASSERT ((VarSize =3D=3D 0 && VarData =3D=3D NULL) || (VarSize !=3D 0 &= & VarData !=3D > NULL)); @@ -105,7 +105,7 @@ MeasureVariable ( > VarLogSize =3D (UINT32)(sizeof (*VarLog) + VarNameLength * sizeof (*Va= rName) > + VarSize > - sizeof (VarLog->UnicodeName) - sizeof > (VarLog->VariableData)); >=20 > - VarLog =3D (EFI_VARIABLE_DATA_TREE *) AllocateZeroPool (VarLogSize); > + VarLog =3D (UEFI_VARIABLE_DATA *) AllocateZeroPool (VarLogSize); > if (VarLog =3D=3D NULL) { > return EFI_OUT_OF_RESOURCES; > } > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel