From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9C4E181F1D for ; Wed, 8 Feb 2017 22:04:54 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 08 Feb 2017 22:04:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,349,1484035200"; d="scan'208,217";a="62949305" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 08 Feb 2017 22:04:53 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Feb 2017 22:04:53 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Thu, 9 Feb 2017 14:04:51 +0800 From: "Yao, Jiewen" To: "Long, Qin" , "edk2-devel@lists.01.org" CC: "Zhang, Chao B" Thread-Topic: [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared. Thread-Index: AQHSgm05LeGm0X3QMkGKeSUNmLmGyaFgL/jA Date: Thu, 9 Feb 2017 06:04:50 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8EBC04@shsmsx102.ccr.corp.intel.com> References: <1486455866-7896-1-git-send-email-jiewen.yao@intel.com> <1486455866-7896-3-git-send-email-jiewen.yao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 06:04:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good catch. Fixed. From: Long, Qin Sent: Wednesday, February 8, 2017 4:41 PM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: RE: [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared. Reviewed-by: Qin Long > Please correct one typo: accroding --> according in the comment. Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, February 7, 2017 12:24 AM > To: edk2-devel@lists.01.org > Cc: Long, Qin >; Zhang, Cha= o B > > > Subject: [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared. > > This PCD is to indicate if the password is cleared. > > Cc: Qin Long > > Cc: Chao Zhang > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > > --- > SecurityPkg/SecurityPkg.dec | 6 ++++++ SecurityPkg/SecurityPkg.uni | 1= 0 > ++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec in= dex > b556fb6..da2f84f 100644 > --- a/SecurityPkg/SecurityPkg.dec > +++ b/SecurityPkg/SecurityPkg.dec > @@ -446,6 +446,12 @@ > # @Prompt Initial setting of TCG2 Persistent Firmware Management Flags > > gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UI > NT32|0x0001001B > > + ## Indicate whether the password is cleared. > + # When it is configured to Dynamic or DynamicEx, it can be set > + through detection using # a platform-specific method (e.g. Board > + Jumper set) in a actual platform in early boot phase.

# > + @Prompt The passowrd clear status > + > gEfiSecurityPkgTokenSpaceGuid.PcdPasswordCleared|FALSE|BOOLEAN|0x0 > 0010 > + 01C > + > [PcdsDynamic, PcdsDynamicEx] > > ## This PCD indicates Hash mask for TPM 2.0.

diff --git > a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni index > 17d36c0..ffc097e 100644 > --- a/SecurityPkg/SecurityPkg.uni > +++ b/SecurityPkg/SecurityPkg.uni > @@ -219,6 +219,16 @@ > "When it is configured to Dynamic or DynamicEx, it can be set through > detection using " > "a platform-specific method (e.g. Button pressed) in a actual platform i= n > early boot phase.

" > > +#string > STR_gEfiSecurityPkgTokenSpaceGuid_PcdPasswordCleared_PROMPT > +#language en-US > +"The passowrd clear status" > + > +#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPasswordCleared_HELP > +#language en-US > +"Indicate whether the password is cleared. " > +"When it is configured to Dynamic or DynamicEx, it can be set through > detection using " > +"a platform-specific method (e.g. Board Jumper set) in a actual platform= in > early boot phase.

" > + > #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPkcs7CertBuffer_PROMPT > #language en-US "One PKCS7 cert used to verify Recovery and Capsule > Update images" > > #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPkcs7CertBuffer_HELP > #language en-US "Provides one PKCS7 cert used to verify Recovery and > Capsule Update images\n" > -- > 2.7.4.windows.1