Re: EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg

["Yao, Jiewen" <jiewen.yao@intel.com>]

I agree. It does not make sense to define it ShellPkg.

Another option is just to do cleanup and remove them at all. This is an internal data structure.

Thank you
Yao Jiewen

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Rebecca Cran
> Sent: Thursday, February 16, 2017 2:48 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and
> ShellPkg
> 
> I'm a bit confused about why Firmware Management Protocol image
> descriptor structures are split between MdePkg and ShellPkg:
> 
> In MdePkg/Include/Protocol/FirmwareInformation.h there's the definition
> of EFI_FIRMWARE_IMAGE_DESCRIPTOR (version 3).  But then the
> EFI_FIRMWARE_IMAGE_DESCRIPTOR_V1 and
> EFI_FIRMWARE_IMAGE_DESCRIPTOR_V2
> struct definitions are in
> ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h along with
> some seemingly-unrelated stuff - and that file appears to have a
> ridiculous number of #include's!
> 
> 
> Is there a reasoning behind putting the older structures in ShellPkg, or
> should they be moved to FirmwareInformation.h?
> 
> 
> --
> 
> Rebecca
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel