From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C2152820AE for ; Thu, 16 Feb 2017 15:12:48 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Feb 2017 15:12:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,169,1484035200"; d="scan'208,217";a="1096675756" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 16 Feb 2017 15:12:48 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 16 Feb 2017 15:12:46 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Fri, 17 Feb 2017 07:12:45 +0800 From: "Yao, Jiewen" To: "Shah, Tapan" , Rebecca Cran , "edk2-devel@lists.01.org" , "Gao, Liming" Thread-Topic: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg Thread-Index: AQHSiKayidllc+ct/EOZQJ5Bbs6+AqFruUeAgACImoA= Date: Thu, 16 Feb 2017 23:12:44 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8EFF4F@shsmsx102.ccr.corp.intel.com> References: <27f6c46b-aebe-a250-eb17-b93267c12a82@bluestop.org> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 23:12:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, I agree that SHELL pkg should dump V1 only and V2 only data structure. I just think there is no need to add new data structure there. The shell pkg can just skip LowestSupportedImageVersion in V1 and skip Last= AttemptVersion/ LastAttemptStatus/ HardwareInstance in V2. Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Sh= ah, > Tapan > Sent: Thursday, February 16, 2017 3:00 PM > To: Rebecca Cran ; edk2-devel@lists.01.org; Gao, Li= ming > > Subject: Re: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and > ShellPkg > > UEFI Spec does not have old FMP image descriptor structures V1 and V2 def= ined. > > MdePkg only follows the spec, so it contains the latest version # 3. But = there are > still drivers using old V1, V2 revisions and Shell 'dh' command needs to = support > decoding all revisions and needs to remain in ShellPkg. > > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Rebecca Cran > Sent: Thursday, February 16, 2017 4:48 PM > To: edk2-devel@lists.01.org > Subject: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and > ShellPkg > > I'm a bit confused about why Firmware Management Protocol image descripto= r > structures are split between MdePkg and ShellPkg: > > In MdePkg/Include/Protocol/FirmwareInformation.h there's the definition o= f > EFI_FIRMWARE_IMAGE_DESCRIPTOR (version 3). But then the > EFI_FIRMWARE_IMAGE_DESCRIPTOR_V1 and > EFI_FIRMWARE_IMAGE_DESCRIPTOR_V2 struct definitions are in > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h along with s= ome > seemingly-unrelated stuff - and that file appears to have a ridiculous nu= mber of > #include's! > > > Is there a reasoning behind putting the older structures in ShellPkg, or = should > they be moved to FirmwareInformation.h? > > > -- > > Rebecca > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel