* [patch] MdeModulePkg: Fix coding style issues
@ 2017-02-28 8:17 Dandan Bi
2017-02-28 8:22 ` Yao, Jiewen
0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2017-02-28 8:17 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
1. Make function comments align with the function.
2. Change the FILE_GUID value in SmmSmiHandlerProfileLib.inf
since it is duplicated with the FILE_GUID value in
SmiHandlerProfileLibNull.inf
3. Add missing PCD PROMPT&HELP string to uni file.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 2 +-
.../SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf | 2 +-
MdeModulePkg/MdeModulePkg.uni | 14 ++++++++++++++
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
index 00cab0c..84a1c8e 100644
--- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
+++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
@@ -243,11 +243,11 @@ GetShortPdbFileName (
The following methods will be tried orderly:
1. Image PDB
2. FFS UI section
3. Image GUID
- @param[in] DriverInfo Pointer to memory profile driver info.
+ @param[in] ImageStruct Point to the image structure.
@return The resulting Ascii name string is stored in the mNameString global array.
**/
CHAR8 *
diff --git a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf
index 0c1ad7e..ba0d65e 100644
--- a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf
+++ b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf
@@ -17,11 +17,11 @@
[Defines]
INF_VERSION = 0x00010005
BASE_NAME = SmmSmiHandlerProfileLib
MODULE_UNI_FILE = SmmSmiHandlerProfileLib.uni
- FILE_GUID = B43D1B52-6251-4E6F-82EC-A599A5EE94C1
+ FILE_GUID = FC38CEAE-FB74-4049-A51C-68F0BA69DA7D
MODULE_TYPE = DXE_SMM_DRIVER
VERSION_STRING = 1.0
LIBRARY_CLASS = SmiHandlerProfileLib|DXE_SMM_DRIVER
CONSTRUCTOR = SmmSmiHandlerProfileLibConstructor
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index 5436b60..ff0d697 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -1073,5 +1073,19 @@
#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_PROMPT #language en-US "If there is any test key used by the platform."
#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP #language en-US "This dynamic PCD holds the information if there is any test key used by the platform."
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_PROMPT #language en-US "SmiHandlerProfile Property."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_HELP #language en-US "The mask is used to control SmiHandlerProfile behavior.<BR><BR>\n"
+ "BIT0 - Enable SmiHandlerProfile.<BR>"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_PROMPT #language en-US "Set image protection policy."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_HELP #language en-US "Set image protection policy. The policy is bitwise.\n"
+ "If a bit is set, the image will be protected by DxeCore if it is aligned.\n"
+ "The code section becomes read-only, and the data section becomes non-executable.\n"
+ "If a bit is clear, the image will not be protected.<BR><BR>\n"
+ "BIT0 - Image from unknown device. <BR>\n"
+ "BIT1 - Image from firmware volume.<BR>"
+
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] MdeModulePkg: Fix coding style issues
2017-02-28 8:17 [patch] MdeModulePkg: Fix coding style issues Dandan Bi
@ 2017-02-28 8:22 ` Yao, Jiewen
0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2017-02-28 8:22 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, February 28, 2017 4:17 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch] MdeModulePkg: Fix coding style issues
>
> 1. Make function comments align with the function.
> 2. Change the FILE_GUID value in SmmSmiHandlerProfileLib.inf
> since it is duplicated with the FILE_GUID value in
> SmiHandlerProfileLibNull.inf
> 3. Add missing PCD PROMPT&HELP string to uni file.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 2 +-
> .../SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf | 2 +-
> MdeModulePkg/MdeModulePkg.uni | 14
> ++++++++++++++
> 3 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git
> a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
> b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
> index 00cab0c..84a1c8e 100644
> ---
> a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
> +++
> b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
> @@ -243,11 +243,11 @@ GetShortPdbFileName (
> The following methods will be tried orderly:
> 1. Image PDB
> 2. FFS UI section
> 3. Image GUID
>
> - @param[in] DriverInfo Pointer to memory profile driver info.
> + @param[in] ImageStruct Point to the image structure.
>
> @return The resulting Ascii name string is stored in the mNameString global
> array.
>
> **/
> CHAR8 *
> diff --git
> a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.i
> nf
> b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.
> inf
> index 0c1ad7e..ba0d65e 100644
> ---
> a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.i
> nf
> +++
> b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.
> inf
> @@ -17,11 +17,11 @@
>
> [Defines]
> INF_VERSION = 0x00010005
> BASE_NAME = SmmSmiHandlerProfileLib
> MODULE_UNI_FILE = SmmSmiHandlerProfileLib.uni
> - FILE_GUID =
> B43D1B52-6251-4E6F-82EC-A599A5EE94C1
> + FILE_GUID =
> FC38CEAE-FB74-4049-A51C-68F0BA69DA7D
> MODULE_TYPE = DXE_SMM_DRIVER
> VERSION_STRING = 1.0
> LIBRARY_CLASS =
> SmiHandlerProfileLib|DXE_SMM_DRIVER
> CONSTRUCTOR = SmmSmiHandlerProfileLibConstructor
>
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index 5436b60..ff0d697 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1073,5 +1073,19 @@
>
> #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_PROMPT
> #language en-US "If there is any test key used by the platform."
>
> #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP
> #language en-US "This dynamic PCD holds the information if there is any test key
> used by the platform."
>
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_
> PROMPT #language en-US "SmiHandlerProfile Property."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_
> HELP #language en-US "The mask is used to control SmiHandlerProfile
> behavior.<BR><BR>\n"
> +
> "BIT0 - Enable SmiHandlerProfile.<BR>"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_PROMPT
> #language en-US "Set image protection policy."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_HELP
> #language en-US "Set image protection policy. The policy is bitwise.\n"
> +
> "If a bit is set, the image will be protected by DxeCore if it is aligned.\n"
> +
> "The code section becomes read-only, and the data section becomes
> non-executable.\n"
> +
> "If a bit is clear, the image will not be protected.<BR><BR>\n"
> +
> "BIT0 - Image from unknown device. <BR>\n"
> +
> "BIT1 - Image from firmware volume.<BR>"
> +
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-28 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-28 8:17 [patch] MdeModulePkg: Fix coding style issues Dandan Bi
2017-02-28 8:22 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox