From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 884B581EE0 for ; Tue, 28 Feb 2017 00:22:48 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 28 Feb 2017 00:22:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,218,1484035200"; d="scan'208,217";a="938883362" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 28 Feb 2017 00:22:48 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 28 Feb 2017 00:22:47 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 28 Feb 2017 00:22:47 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Tue, 28 Feb 2017 16:22:45 +0800 From: "Yao, Jiewen" To: "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [patch] MdeModulePkg: Fix coding style issues Thread-Index: AQHSkZsf5k1ixP01TkqeFvUG2Xry8qF+FECw Date: Tue, 28 Feb 2017 08:22:44 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8F6A46@shsmsx102.ccr.corp.intel.com> References: <1488269840-32256-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1488269840-32256-1-git-send-email-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [patch] MdeModulePkg: Fix coding style issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 08:22:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com > -----Original Message----- > From: Bi, Dandan > Sent: Tuesday, February 28, 2017 4:17 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [patch] MdeModulePkg: Fix coding style issues > > 1. Make function comments align with the function. > 2. Change the FILE_GUID value in SmmSmiHandlerProfileLib.inf > since it is duplicated with the FILE_GUID value in > SmiHandlerProfileLibNull.inf > 3. Add missing PCD PROMPT&HELP string to uni file. > > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 2 +- > .../SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf | 2 +- > MdeModulePkg/MdeModulePkg.uni | 14 > ++++++++++++++ > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git > a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c > b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c > index 00cab0c..84a1c8e 100644 > --- > a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c > +++ > b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c > @@ -243,11 +243,11 @@ GetShortPdbFileName ( > The following methods will be tried orderly: > 1. Image PDB > 2. FFS UI section > 3. Image GUID > > - @param[in] DriverInfo Pointer to memory profile driver info. > + @param[in] ImageStruct Point to the image structure. > > @return The resulting Ascii name string is stored in the mNameString g= lobal > array. > > **/ > CHAR8 * > diff --git > a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.i > nf > b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib. > inf > index 0c1ad7e..ba0d65e 100644 > --- > a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.i > nf > +++ > b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib. > inf > @@ -17,11 +17,11 @@ > > [Defines] > INF_VERSION =3D 0x00010005 > BASE_NAME =3D SmmSmiHandlerProfileLib > MODULE_UNI_FILE =3D SmmSmiHandlerProfileLib.uni > - FILE_GUID =3D > B43D1B52-6251-4E6F-82EC-A599A5EE94C1 > + FILE_GUID =3D > FC38CEAE-FB74-4049-A51C-68F0BA69DA7D > MODULE_TYPE =3D DXE_SMM_DRIVER > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D > SmiHandlerProfileLib|DXE_SMM_DRIVER > CONSTRUCTOR =3D SmmSmiHandlerProfileLibConstructor > > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index 5436b60..ff0d697 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1073,5 +1073,19 @@ > > #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_PROMPT > #language en-US "If there is any test key used by the platform." > > #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP > #language en-US "This dynamic PCD holds the information if there is any t= est key > used by the platform." > > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_ > PROMPT #language en-US "SmiHandlerProfile Property." > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_ > HELP #language en-US "The mask is used to control SmiHandlerProfile > behavior.

\n" > + > "BIT0 - Enable SmiHandlerProfile.
" > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_PROMPT > #language en-US "Set image protection policy." > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_HELP > #language en-US "Set image protection policy. The policy is bitwise.\n" > + > "If a bit is set, the image will be protected by DxeCore if it is aligned= .\n" > + > "The code section becomes read-only, and the data section becomes > non-executable.\n" > + > "If a bit is clear, the image will not be protected.

\n" > + > "BIT0 - Image from unknown device.
\n" > + > "BIT1 - Image from firmware volume.
" > + > -- > 1.9.5.msysgit.1