From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 69B3380387 for ; Wed, 8 Mar 2017 16:47:57 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2017 16:47:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,266,1486454400"; d="scan'208";a="1120248358" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 08 Mar 2017 16:47:57 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Mar 2017 16:47:57 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Mar 2017 16:47:56 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Thu, 9 Mar 2017 08:47:54 +0800 From: "Yao, Jiewen" To: Laszlo Ersek , edk2-devel-01 CC: "Tian, Feng" , Michael Tsirkin , Ard Biesheuvel , Phil Dennis-Jordan , Leo Duran , Al Stone , "Zeng, Star" Thread-Topic: [edk2] [PATCH v2 1/2] MdeModulePkg/AcpiTableDxe: condense whitespace around FADT.{DSDT, X_DSDT} Thread-Index: AQHSmEZw+Me51AIrn0+HRQU8Xd69pqGLrQIg Date: Thu, 9 Mar 2017 00:47:53 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8FC9AD@shsmsx102.ccr.corp.intel.com> References: <20170308195839.18689-1-lersek@redhat.com> <20170308195839.18689-2-lersek@redhat.com> In-Reply-To: <20170308195839.18689-2-lersek@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 1/2] MdeModulePkg/AcpiTableDxe: condense whitespace around FADT.{DSDT, X_DSDT} X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 00:47:57 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@Intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo > Ersek > Sent: Thursday, March 9, 2017 3:59 AM > To: edk2-devel-01 > Cc: Tian, Feng ; Michael Tsirkin ; > Ard Biesheuvel ; Phil Dennis-Jordan > ; Leo Duran ; Yao, Jiewen > ; Al Stone ; Zeng, Star > > Subject: [edk2] [PATCH v2 1/2] MdeModulePkg/AcpiTableDxe: condense > whitespace around FADT.{DSDT, X_DSDT} >=20 > This patch incurs no functional changes, it just removes some whitespace, > and also makes sure we always assign >=20 > AcpiTableInstance->Fadt3->Dsdt >=20 > first, and >=20 > AcpiTableInstance->Fadt3->XDsdt >=20 > second. The goal is to separate the syntactic changes from the functional > changes implemented by the next patch. >=20 > Cc: Al Stone > Cc: Ard Biesheuvel > Cc: Feng Tian > Cc: Igor Mammedov > Cc: Jiewen Yao > Cc: Leo Duran > Cc: Michael Tsirkin > Cc: Phil Dennis-Jordan > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > Reviewed-by: Thomas Huth > Reviewed-by: Feng Tian > --- >=20 > Notes: > v2: > - no changes > - pick up R-b's from Thomas and Feng >=20 > v1: > NOTE for people on the CC list: >=20 > If you are not presently subscribed to edk2-devel and wish to comment= on > this patch publicly, you need to subscribe first, and wait for the > subscription request to *complete* (see your inbox), *before* sending > your followup. This is not ideal, but edk2-devel requires subscriptio= n > before reflecting messages from someone. >=20 > Subscribe at . Than= ks. >=20 > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 20 > ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > index 7f95b9dc709d..7795ff7269ca 100644 > --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > @@ -646,16 +646,12 @@ AddTableToList ( > AcpiTableInstance->Fadt3->FirmwareCtrl =3D 0; > } > if ((UINT64)(UINTN)AcpiTableInstance->Dsdt3 < BASE_4GB) { > - AcpiTableInstance->Fadt3->Dsdt =3D (UINT32) (UINTN) > AcpiTableInstance->Dsdt3; > + AcpiTableInstance->Fadt3->Dsdt =3D (UINT32) (UINTN) > AcpiTableInstance->Dsdt3; > ZeroMem (&AcpiTableInstance->Fadt3->XDsdt, sizeof (UINT64)); > } else { > - Buffer64 =3D (UINT64) (UINTN) > AcpiTableInstance->Dsdt3; > - CopyMem ( > - &AcpiTableInstance->Fadt3->XDsdt, > - &Buffer64, > - sizeof (UINT64) > - ); > AcpiTableInstance->Fadt3->Dsdt =3D 0; > + Buffer64 =3D (UINT64) (UINTN) AcpiTableInstance->Dsdt3; > + CopyMem (&AcpiTableInstance->Fadt3->XDsdt, &Buffer64, sizeof > (UINT64)); > } >=20 > // > @@ -850,14 +846,10 @@ AddTableToList ( > // > if (AcpiTableInstance->Fadt3 !=3D NULL) { > if ((UINT64)(UINTN)AcpiTableInstance->Dsdt3 < BASE_4GB) { > - AcpiTableInstance->Fadt3->Dsdt =3D (UINT32) (UINTN) > AcpiTableInstance->Dsdt3; > + AcpiTableInstance->Fadt3->Dsdt =3D (UINT32) (UINTN) > AcpiTableInstance->Dsdt3; > } > - Buffer64 =3D (UINT64) (UINTN) > AcpiTableInstance->Dsdt3; > - CopyMem ( > - &AcpiTableInstance->Fadt3->XDsdt, > - &Buffer64, > - sizeof (UINT64) > - ); > + Buffer64 =3D (UINT64) (UINTN) AcpiTableInstance->Dsdt3; > + CopyMem (&AcpiTableInstance->Fadt3->XDsdt, &Buffer64, sizeof > (UINT64)); >=20 > // > // Checksum FADT table > -- > 2.9.3 >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel