From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch] MdeModulePkg/DxeCapsuleLibFmp: Fix build failure
Date: Mon, 20 Mar 2017 01:44:22 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A906F64@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1489974074-34284-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, March 20, 2017 9:41 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch] MdeModulePkg/DxeCapsuleLibFmp: Fix build failure
>
> Move the definition of variable "mEsrtTable" and
> "mIsVirtualAddrConverted" to DxeCapsuleLib.c.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++--
> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleRuntime.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> index 49f1103..2f39778 100644
> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> @@ -45,12 +45,12 @@
> #include <Protocol/GraphicsOutput.h>
> #include <Protocol/EsrtManagement.h>
> #include <Protocol/FirmwareManagement.h>
> #include <Protocol/DevicePath.h>
>
> -extern EFI_SYSTEM_RESOURCE_TABLE *mEsrtTable;
> -extern BOOLEAN mIsVirtualAddrConverted;
> +EFI_SYSTEM_RESOURCE_TABLE *mEsrtTable = NULL;
> +BOOLEAN mIsVirtualAddrConverted = FALSE;
>
> BOOLEAN mDxeCapsuleLibEndOfDxe = FALSE;
> EFI_EVENT mDxeCapsuleLibEndOfDxeEvent = NULL;
>
> /**
> diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleRuntime.c
> b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleRuntime.c
> index 4725d53..c88a0fc 100644
> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleRuntime.c
> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleRuntime.c
> @@ -24,12 +24,12 @@
> #include <Library/DxeServicesTableLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> #include <Library/UefiRuntimeServicesTableLib.h>
> #include <Library/MemoryAllocationLib.h>
>
> -EFI_SYSTEM_RESOURCE_TABLE *mEsrtTable
> = NULL;
> -BOOLEAN mIsVirtualAddrConverted
> = FALSE;
> +extern EFI_SYSTEM_RESOURCE_TABLE *mEsrtTable;
> +extern BOOLEAN mIsVirtualAddrConverted;
> EFI_EVENT
> mDxeRuntimeCapsuleLibVirtualAddressChangeEvent = NULL;
>
> /**
> Convert EsrtTable physical address to virtual address.
>
> --
> 1.9.5.msysgit.1
prev parent reply other threads:[~2017-03-20 1:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 1:41 [patch] MdeModulePkg/DxeCapsuleLibFmp: Fix build failure Dandan Bi
2017-03-20 1:44 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A906F64@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox