* [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is 0" msg to DEBUG_WARN
@ 2017-03-20 11:09 Laszlo Ersek
2017-03-20 11:11 ` Ard Biesheuvel
2017-03-20 15:09 ` Yao, Jiewen
0 siblings, 2 replies; 4+ messages in thread
From: Laszlo Ersek @ 2017-03-20 11:09 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Ard Biesheuvel, Feng Tian, Jiewen Yao, Star Zeng
UEFI executables that consist of a single read+write+exec PE/COFF section
trigger this message, but such a binary layout isn't actually an error.
The image can be launched alright, only image protection cannot be applied
to it fully.
One example that elicits the message is (some) Linux kernels (with the EFI
stub of course).
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Feng Tian <feng.tian@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
index 7689c794a8ad..699c9a827720 100644
--- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
+++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
@@ -580,10 +580,10 @@ ProtectUefiImageCommon (
}
if (ImageRecord->CodeSegmentCount == 0) {
- DEBUG ((DEBUG_ERROR, "!!!!!!!! ProtectUefiImageCommon - CodeSegmentCount is 0 !!!!!!!!\n"));
+ DEBUG ((DEBUG_WARN, "!!!!!!!! ProtectUefiImageCommon - CodeSegmentCount is 0 !!!!!!!!\n"));
PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN) ImageAddress);
if (PdbPointer != NULL) {
- DEBUG ((DEBUG_ERROR, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointer));
+ DEBUG ((DEBUG_WARN, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointer));
}
goto Finish;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is 0" msg to DEBUG_WARN
2017-03-20 11:09 [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is 0" msg to DEBUG_WARN Laszlo Ersek
@ 2017-03-20 11:11 ` Ard Biesheuvel
2017-03-20 15:09 ` Yao, Jiewen
1 sibling, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2017-03-20 11:11 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-01, Feng Tian, Jiewen Yao, Star Zeng
On 20 March 2017 at 11:09, Laszlo Ersek <lersek@redhat.com> wrote:
> UEFI executables that consist of a single read+write+exec PE/COFF section
> trigger this message, but such a binary layout isn't actually an error.
> The image can be launched alright, only image protection cannot be applied
> to it fully.
>
> One example that elicits the message is (some) Linux kernels (with the EFI
> stub of course).
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> index 7689c794a8ad..699c9a827720 100644
> --- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> +++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> @@ -580,10 +580,10 @@ ProtectUefiImageCommon (
> }
>
> if (ImageRecord->CodeSegmentCount == 0) {
> - DEBUG ((DEBUG_ERROR, "!!!!!!!! ProtectUefiImageCommon - CodeSegmentCount is 0 !!!!!!!!\n"));
> + DEBUG ((DEBUG_WARN, "!!!!!!!! ProtectUefiImageCommon - CodeSegmentCount is 0 !!!!!!!!\n"));
> PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN) ImageAddress);
> if (PdbPointer != NULL) {
> - DEBUG ((DEBUG_ERROR, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointer));
> + DEBUG ((DEBUG_WARN, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointer));
> }
> goto Finish;
> }
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is 0" msg to DEBUG_WARN
2017-03-20 11:09 [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is 0" msg to DEBUG_WARN Laszlo Ersek
2017-03-20 11:11 ` Ard Biesheuvel
@ 2017-03-20 15:09 ` Yao, Jiewen
2017-03-20 15:48 ` Laszlo Ersek
1 sibling, 1 reply; 4+ messages in thread
From: Yao, Jiewen @ 2017-03-20 15:09 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01; +Cc: Ard Biesheuvel, Tian, Feng, Zeng, Star
I agree to downgrade the logging level.
Can we add the comment, from log message to the comment in the C code?
Such as below:
==========================
//
// UEFI executables that consist of a single read+write+exec PE/COFF section
// isn't actually an error.
// The image can be launched alright, only image protection cannot be applied
// to it fully.
//
// One example that elicits this is (some) Linux kernels (with the EFI
// stub of course).
//
==========================
With comment added, reviewed-by: Jiewen.yao@intel.com
Thank you
Yao Jiewen
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Monday, March 20, 2017 7:10 PM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Tian, Feng
> <feng.tian@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is
> 0" msg to DEBUG_WARN
>
> UEFI executables that consist of a single read+write+exec PE/COFF section
> trigger this message, but such a binary layout isn't actually an error.
> The image can be launched alright, only image protection cannot be applied
> to it fully.
>
> One example that elicits the message is (some) Linux kernels (with the EFI
> stub of course).
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> index 7689c794a8ad..699c9a827720 100644
> --- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> +++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> @@ -580,10 +580,10 @@ ProtectUefiImageCommon (
> }
>
> if (ImageRecord->CodeSegmentCount == 0) {
> - DEBUG ((DEBUG_ERROR, "!!!!!!!! ProtectUefiImageCommon -
> CodeSegmentCount is 0 !!!!!!!!\n"));
> + DEBUG ((DEBUG_WARN, "!!!!!!!! ProtectUefiImageCommon -
> CodeSegmentCount is 0 !!!!!!!!\n"));
> PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN)
> ImageAddress);
> if (PdbPointer != NULL) {
> - DEBUG ((DEBUG_ERROR, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointer));
> + DEBUG ((DEBUG_WARN, "!!!!!!!! Image - %a !!!!!!!!\n",
> PdbPointer));
> }
> goto Finish;
> }
> --
> 2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is 0" msg to DEBUG_WARN
2017-03-20 15:09 ` Yao, Jiewen
@ 2017-03-20 15:48 ` Laszlo Ersek
0 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2017-03-20 15:48 UTC (permalink / raw)
To: Yao, Jiewen, edk2-devel-01; +Cc: Ard Biesheuvel, Tian, Feng, Zeng, Star
On 03/20/17 16:09, Yao, Jiewen wrote:
> I agree to downgrade the logging level.
>
> Can we add the comment, from log message to the comment in the C code?
> Such as below:
> ==========================
> //
> // UEFI executables that consist of a single read+write+exec PE/COFF section
> // isn't actually an error.
> // The image can be launched alright, only image protection cannot be applied
> // to it fully.
> //
> // One example that elicits this is (some) Linux kernels (with the EFI
> // stub of course).
> //
> ==========================
>
> With comment added, reviewed-by: Jiewen.yao@intel.com
I updated the patch with the comment. Commit 38b15ebe4fd5.
Thanks!
Laszlo
>
> Thank you
> Yao Jiewen
>
>
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Monday, March 20, 2017 7:10 PM
>> To: edk2-devel-01 <edk2-devel@lists.01.org>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Tian, Feng
>> <feng.tian@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star
>> <star.zeng@intel.com>
>> Subject: [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is
>> 0" msg to DEBUG_WARN
>>
>> UEFI executables that consist of a single read+write+exec PE/COFF section
>> trigger this message, but such a binary layout isn't actually an error.
>> The image can be launched alright, only image protection cannot be applied
>> to it fully.
>>
>> One example that elicits the message is (some) Linux kernels (with the EFI
>> stub of course).
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Feng Tian <feng.tian@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
>> b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
>> index 7689c794a8ad..699c9a827720 100644
>> --- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
>> +++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
>> @@ -580,10 +580,10 @@ ProtectUefiImageCommon (
>> }
>>
>> if (ImageRecord->CodeSegmentCount == 0) {
>> - DEBUG ((DEBUG_ERROR, "!!!!!!!! ProtectUefiImageCommon -
>> CodeSegmentCount is 0 !!!!!!!!\n"));
>> + DEBUG ((DEBUG_WARN, "!!!!!!!! ProtectUefiImageCommon -
>> CodeSegmentCount is 0 !!!!!!!!\n"));
>> PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN)
>> ImageAddress);
>> if (PdbPointer != NULL) {
>> - DEBUG ((DEBUG_ERROR, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointer));
>> + DEBUG ((DEBUG_WARN, "!!!!!!!! Image - %a !!!!!!!!\n",
>> PdbPointer));
>> }
>> goto Finish;
>> }
>> --
>> 2.9.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-20 15:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-20 11:09 [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is 0" msg to DEBUG_WARN Laszlo Ersek
2017-03-20 11:11 ` Ard Biesheuvel
2017-03-20 15:09 ` Yao, Jiewen
2017-03-20 15:48 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox