Re: [PATCH 2/3] SecurityPkg: Error Level is not used correctly

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Fan, Jeff
> Sent: Monday, April 10, 2017 2:20 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH 2/3] SecurityPkg: Error Level is not used correctly
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan <jeff.fan@intel.com>
> ---
>  SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c | 4 ++--
>  SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c | 4 ++--
>  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c                                | 2 +-
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c                                | 4 ++--
>  SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c                                | 4 ++--
>  SecurityPkg/Tcg/TrEEPei/TrEEPei.c                                | 4 ++--
>  6 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git
> a/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c
> b/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c
> index 1e8c354..eedc439 100644
> --- a/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c
> +++ b/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c
> @@ -3,7 +3,7 @@
>    via PcdTpmInstanceGuid. Platform need make choice that which one will be
> final one.
>    At most one TPM2 instance can be finally registered, and other will return
> unsupported.
> 
> -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved. <BR>
> +Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved. <BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -89,7 +89,7 @@ Tpm2RegisterTpm2DeviceLib (
>    )
>  {
>    if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &Tpm2Device->ProviderGuid)){
> -    DEBUG ((EFI_D_ERROR, "WARNING: Tpm2RegisterTpm2DeviceLib - does
> not support %g registration\n", &Tpm2Device->ProviderGuid));
> +    DEBUG ((DEBUG_WARN, "WARNING: Tpm2RegisterTpm2DeviceLib - does
> not support %g registration\n", &Tpm2Device->ProviderGuid));
>      return EFI_UNSUPPORTED;
>    }
> 
> diff --git a/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c
> b/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c
> index 0211399..7470fe3 100644
> --- a/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c
> +++ b/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c
> @@ -3,7 +3,7 @@
>    via PcdTpmInstanceGuid. Platform need make choice that which one will be
> final one.
>    At most one TPM2 instance can be finally registered, and other will return
> unsupported.
> 
> -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved. <BR>
> +Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved. <BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -120,7 +120,7 @@ Tpm2RegisterTpm2DeviceLib (
>    TPM2_DEVICE_INTERFACE *Tpm2DeviceInterface;
> 
>    if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &Tpm2Device->ProviderGuid)){
> -    DEBUG ((EFI_D_ERROR, "WARNING: Tpm2RegisterTpm2DeviceLib - does
> not support %g registration\n", &Tpm2Device->ProviderGuid));
> +    DEBUG ((DEBUG_WARN, "WARNING: Tpm2RegisterTpm2DeviceLib - does
> not support %g registration\n", &Tpm2Device->ProviderGuid));
>      return EFI_UNSUPPORTED;
>    }
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> index 53de666..c2c52e3 100644
> --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> @@ -2466,7 +2466,7 @@ DriverEntry (
> 
>    if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &gEfiTpmDeviceInstanceNoneGuid) ||
>        CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &gEfiTpmDeviceInstanceTpm12Guid)){
> -    DEBUG ((EFI_D_ERROR, "No TPM2 instance required!\n"));
> +    DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n"));
>      return EFI_UNSUPPORTED;
>    }
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> index 209d843..69adad4 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Initialize TPM2 device and measure FVs before handing off control to DXE.
> 
> -Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -736,7 +736,7 @@ PeimEntryMA (
> 
>    if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &gEfiTpmDeviceInstanceNoneGuid) ||
>        CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &gEfiTpmDeviceInstanceTpm12Guid)){
> -    DEBUG ((EFI_D_ERROR, "No TPM2 instance required!\n"));
> +    DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n"));
>      return EFI_UNSUPPORTED;
>    }
> 
> diff --git a/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> b/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> index fb69fa1..95e9d74 100644
> --- a/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> +++ b/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> @@ -1,7 +1,7 @@
>  /** @file
>    This module implements TrEE Protocol.
> 
> -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -1733,7 +1733,7 @@ DriverEntry (
> 
>    if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &gEfiTpmDeviceInstanceNoneGuid) ||
>        CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &gEfiTpmDeviceInstanceTpm12Guid)){
> -    DEBUG ((EFI_D_ERROR, "No TPM2 instance required!\n"));
> +    DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n"));
>      return EFI_UNSUPPORTED;
>    }
> 
> diff --git a/SecurityPkg/Tcg/TrEEPei/TrEEPei.c
> b/SecurityPkg/Tcg/TrEEPei/TrEEPei.c
> index 8d8639d..b561245 100644
> --- a/SecurityPkg/Tcg/TrEEPei/TrEEPei.c
> +++ b/SecurityPkg/Tcg/TrEEPei/TrEEPei.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Initialize TPM2 device and measure FVs before handing off control to DXE.
> 
> -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -597,7 +597,7 @@ PeimEntryMA (
> 
>    if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &gEfiTpmDeviceInstanceNoneGuid) ||
>        CompareGuid (PcdGetPtr(PcdTpmInstanceGuid),
> &gEfiTpmDeviceInstanceTpm12Guid)){
> -    DEBUG ((EFI_D_ERROR, "No TPM2 instance required!\n"));
> +    DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n"));
>      return EFI_UNSUPPORTED;
>    }
> 
> --
> 2.9.3.windows.2