From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7FBC421A04822 for ; Tue, 11 Apr 2017 01:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491900760; x=1523436760; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Qxl8/KvWz3eE8CuFZVd5u4Gae/rFkDhM+Bysg2ZUTZM=; b=vyk3XhRD2ACUb8l5dk61EOCORILOQ5WgbXZobOzVWIjwu8R9qLyTpK9t 7bC+zAT6SyRzLGMUInLYYnZWHhdj0w==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2017 01:52:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,184,1488873600"; d="scan'208";a="1133870852" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 11 Apr 2017 01:52:40 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 11 Apr 2017 01:52:39 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 11 Apr 2017 01:52:39 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Tue, 11 Apr 2017 16:52:37 +0800 From: "Yao, Jiewen" To: "Fan, Jeff" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 2/3] SecurityPkg: Error Level is not used correctly Thread-Index: AQHSscJ9FGVcOVk9AE2FIJ+uzdoz46G/3mAw Date: Tue, 11 Apr 2017 08:52:37 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A92A74A@shsmsx102.ccr.corp.intel.com> References: <20170410061941.5016-1-jeff.fan@intel.com> <20170410061941.5016-3-jeff.fan@intel.com> In-Reply-To: <20170410061941.5016-3-jeff.fan@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/3] SecurityPkg: Error Level is not used correctly X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 08:52:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com > -----Original Message----- > From: Fan, Jeff > Sent: Monday, April 10, 2017 2:20 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [PATCH 2/3] SecurityPkg: Error Level is not used correctly >=20 > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan > --- > SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c | 4 ++-= - > SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c | 4 ++-= - > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 2 +- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++-= - > SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c | 4 ++-= - > SecurityPkg/Tcg/TrEEPei/TrEEPei.c | 4 ++-= - > 6 files changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git > a/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c > b/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c > index 1e8c354..eedc439 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c > @@ -3,7 +3,7 @@ > via PcdTpmInstanceGuid. Platform need make choice that which one will = be > final one. > At most one TPM2 instance can be finally registered, and other will re= turn > unsupported. >=20 > -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e found > at > @@ -89,7 +89,7 @@ Tpm2RegisterTpm2DeviceLib ( > ) > { > if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &Tpm2Device->ProviderGuid)){ > - DEBUG ((EFI_D_ERROR, "WARNING: Tpm2RegisterTpm2DeviceLib - does > not support %g registration\n", &Tpm2Device->ProviderGuid)); > + DEBUG ((DEBUG_WARN, "WARNING: Tpm2RegisterTpm2DeviceLib - does > not support %g registration\n", &Tpm2Device->ProviderGuid)); > return EFI_UNSUPPORTED; > } >=20 > diff --git a/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterP= ei.c > b/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c > index 0211399..7470fe3 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c > @@ -3,7 +3,7 @@ > via PcdTpmInstanceGuid. Platform need make choice that which one will = be > final one. > At most one TPM2 instance can be finally registered, and other will re= turn > unsupported. >=20 > -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e found > at > @@ -120,7 +120,7 @@ Tpm2RegisterTpm2DeviceLib ( > TPM2_DEVICE_INTERFACE *Tpm2DeviceInterface; >=20 > if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &Tpm2Device->ProviderGuid)){ > - DEBUG ((EFI_D_ERROR, "WARNING: Tpm2RegisterTpm2DeviceLib - does > not support %g registration\n", &Tpm2Device->ProviderGuid)); > + DEBUG ((DEBUG_WARN, "WARNING: Tpm2RegisterTpm2DeviceLib - does > not support %g registration\n", &Tpm2Device->ProviderGuid)); > return EFI_UNSUPPORTED; > } >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > index 53de666..c2c52e3 100644 > --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > @@ -2466,7 +2466,7 @@ DriverEntry ( >=20 > if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &gEfiTpmDeviceInstanceNoneGuid) || > CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &gEfiTpmDeviceInstanceTpm12Guid)){ > - DEBUG ((EFI_D_ERROR, "No TPM2 instance required!\n")); > + DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n")); > return EFI_UNSUPPORTED; > } >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > index 209d843..69adad4 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > @@ -1,7 +1,7 @@ > /** @file > Initialize TPM2 device and measure FVs before handing off control to D= XE. >=20 > -Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e found > at > @@ -736,7 +736,7 @@ PeimEntryMA ( >=20 > if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &gEfiTpmDeviceInstanceNoneGuid) || > CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &gEfiTpmDeviceInstanceTpm12Guid)){ > - DEBUG ((EFI_D_ERROR, "No TPM2 instance required!\n")); > + DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n")); > return EFI_UNSUPPORTED; > } >=20 > diff --git a/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c > b/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c > index fb69fa1..95e9d74 100644 > --- a/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c > +++ b/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c > @@ -1,7 +1,7 @@ > /** @file > This module implements TrEE Protocol. >=20 > -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e found > at > @@ -1733,7 +1733,7 @@ DriverEntry ( >=20 > if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &gEfiTpmDeviceInstanceNoneGuid) || > CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &gEfiTpmDeviceInstanceTpm12Guid)){ > - DEBUG ((EFI_D_ERROR, "No TPM2 instance required!\n")); > + DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n")); > return EFI_UNSUPPORTED; > } >=20 > diff --git a/SecurityPkg/Tcg/TrEEPei/TrEEPei.c > b/SecurityPkg/Tcg/TrEEPei/TrEEPei.c > index 8d8639d..b561245 100644 > --- a/SecurityPkg/Tcg/TrEEPei/TrEEPei.c > +++ b/SecurityPkg/Tcg/TrEEPei/TrEEPei.c > @@ -1,7 +1,7 @@ > /** @file > Initialize TPM2 device and measure FVs before handing off control to D= XE. >=20 > -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e found > at > @@ -597,7 +597,7 @@ PeimEntryMA ( >=20 > if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &gEfiTpmDeviceInstanceNoneGuid) || > CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), > &gEfiTpmDeviceInstanceTpm12Guid)){ > - DEBUG ((EFI_D_ERROR, "No TPM2 instance required!\n")); > + DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n")); > return EFI_UNSUPPORTED; > } >=20 > -- > 2.9.3.windows.2