public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg/PiSmmCore: Fix potentially uninitialized local variable
Date: Fri, 14 Apr 2017 03:40:47 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A92C47F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170410061514.14300-1-hao.a.wu@intel.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, April 10, 2017 2:15 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH] MdeModulePkg/PiSmmCore: Fix potentially uninitialized local
> variable
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  MdeModulePkg/Core/PiSmmCore/Pool.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Core/PiSmmCore/Pool.c
> b/MdeModulePkg/Core/PiSmmCore/Pool.c
> index f734b3f72d..43ce869d1e 100644
> --- a/MdeModulePkg/Core/PiSmmCore/Pool.c
> +++ b/MdeModulePkg/Core/PiSmmCore/Pool.c
> @@ -1,7 +1,7 @@
>  /** @file
>    SMM Memory pool management functions.
> 
> -  Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials are licensed and made available
>    under the terms and conditions of the BSD License which accompanies this
>    distribution.  The full text of the license may be found at
> @@ -136,6 +136,7 @@ InternalAllocPoolByIndex (
>    EFI_PHYSICAL_ADDRESS  Address;
>    SMM_POOL_TYPE         SmmPoolType;
> 
> +  Address     = 0;
>    SmmPoolType = UefiMemoryTypeToSmmPoolType(PoolType);
> 
>    ASSERT (PoolIndex <= MAX_POOL_INDEX);
> @@ -227,6 +228,8 @@ SmmInternalAllocatePool (
>    EFI_PHYSICAL_ADDRESS  Address;
>    UINTN                 PoolIndex;
> 
> +  Address = 0;
> +
>    if (PoolType != EfiRuntimeServicesCode &&
>        PoolType != EfiRuntimeServicesData) {
>      return EFI_INVALID_PARAMETER;
> --
> 2.12.0.windows.1



      reply	other threads:[~2017-04-14  3:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10  6:15 [PATCH] MdeModulePkg/PiSmmCore: Fix potentially uninitialized local variable Hao Wu
2017-04-14  3:40 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A92C47F@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox