From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 377B021A18AAB for ; Fri, 5 May 2017 07:03:49 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 May 2017 07:03:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,292,1491289200"; d="scan'208,217";a="257352897" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 05 May 2017 07:03:47 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 5 May 2017 07:03:47 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 5 May 2017 07:03:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Fri, 5 May 2017 22:03:44 +0800 From: "Yao, Jiewen" To: "Yao, Jiewen" , Leif Lindholm , "edk2-devel@lists.01.org" CC: "Richardson, Brian" , Ard Biesheuvel , Chenhui Sun , "Andrew Fish" , Alan Ott , Ryan Harkin , "Duran, Leo" , "haojian.zhuang@linaro.org" , Linaro UEFI , "Kinney, Michael D" , Heyi Guo Thread-Topic: [edk2] [RFC] migration of OpenPlatformPkg to tianocore Thread-Index: AQHSxGByckqBxVzTJk+mz9WG+bSkb6HlDa1wgAC2SAA= Date: Fri, 5 May 2017 14:03:43 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A939EA0@shsmsx102.ccr.corp.intel.com> References: <20170503225539.GQ1657@bivouac.eciton.net> <74D8A39837DF1E4DA445A8C0B3885C503A939E61@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A939E61@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [RFC] migration of OpenPlatformPkg to tianocore X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 14:03:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Some comments for the build failure. I think we might have different understanding on PACKAGES_PATH. We are using below structure: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Platform\ Intel\ PlatformAPkg PlatformBPkg Silicon\ Intel\ SiliconAPkg SiliconBPkg We set PACKAGES_PATH to "Platform\Intel:Silicon\Intel". As such Build.DSC can include PlatformAPkg/DriverA/DriverA.inf. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D My suggestion for your case is below: We can use =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Platform\ Arm\ JunoPkg VExpressPkg We set PACKAGES_PATH to "Platform\Arm". ArmJunoPkg.dsc can just use "VExpressPkg\ArmVExpress.dsc.inc" and "JunoPkg\= Library\JunoPciHostBridgeLib\ JunoPciHostBridgeLib.dsc" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D The benefit of adding "Pkg" is that people can have a clear picture on wher= e the path starts from. :) Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,= Jiewen Sent: Friday, May 5, 2017 9:46 PM To: Leif Lindholm ; edk2-devel@lists.01.org Cc: Richardson, Brian ; Ard Biesheuvel ; Chenhui Sun ; Andrew Fish ; Alan Ott ; Ryan Harkin ; Duran, Leo ; haojian.zhuang@linaro.org; Linaro= UEFI ; Kinney, Michael D ; Heyi Guo Subject: Re: [edk2] [RFC] migration of OpenPlatformPkg to tianocore HI Leif It is great that you are adding more platform to edk2-platforms. We (Intel) also have plan to add more boards there. In general, we are very= close on having silicon and platform folder. I have a quick look. One minor suggestions here: Take Arm folder as example. (I assume Juno is one package, and VExpress is = the other package.) Can we name Juno to be JunoPkg, and VExpress to be VExpressPkg ? We do not add "Pkg" to a folder. And we usually add "Pkg" suffix to a packa= ge. In general, I think it is a very good start. I may review the content in more detail and provide more feedback. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leif= Lindholm Sent: Thursday, May 4, 2017 6:56 AM To: edk2-devel@lists.01.org Cc: Ryan Harkin >; Ar= d Biesheuvel >;= Chenhui Sun >; Andre= w Fish >; Alan Ott >; Richardson, Brian >; Duran, Leo >; haojian.zhuang@linaro.org; Linaro UEFI >; Kinney, Michael D >; Heyi Guo > Subject: [edk2] [RFC] migration of OpenPlatformPkg to tianocore Hi all, As some of you may be aware, I have been working around the lack of a clear upstreaming strategy for platform support by keeping such code in a dedicated repository I set up at Linaro for that purpose: https://git.linaro.org/uefi/OpenPlatformPkg.git During discussions at the last Seattle plugfest we finally agreed on the (theoretical) details of how to use the edk2-platforms repository. After that I promised to migrate OpenPlatformPkg across to the edk2-platforms and edk2-non-osi structure, with the explicit end goal from my side that this should become the master branch for each. And now, before the release of HURD 1.0, I have. Current limitations (that I can remember): - A few references to OpenPlatformPkg remain, in ways that do not appear to break any of the platform builds. Most likely this affects dead code, but in case it's been accidentally orphaned, I thought it best to - I have simply nuked all references to Ebl (used in _addition_ to the UEFI shell, which was never the intent) and the efi-toolkit ramdisk driver. - The Marvell Yukon driver that I sent out for review last week has not migrated anywhere, and so has been temporarily disabled Mike suggested I should - USB support on the LeMaker Cello board depends on the patch "OptionRomPkg: add firmware loader driver for Renesas PD72020x" sent out by Ard on 18th of April. - I have dropped some of the binary-only modules from OpenPlatformPkg, and contacted the platform owners with requests for modifications. - The git history is quite messy and will be cleaned up, but I wanted to keep the transition quite visible in the RFC. - I haven't filled anything into the Maintainers.txt files - I am in favour of moving to a fully machine-readable format with wildcards as Laszlo has proposed in the past, and think this would be an excellent point to have that discussion (which can be had separately for edk2-platforms and edk2-non-osi from edk2). - Few of the platforms complete the FV generation stage, and I've inserted a couple of silly hacks to get them to get as far as they do. I think that either I am missing some points of how PACKAGES_PATH is intended to work, or I'm simply hitting corner cases no one has come across before. I could really use some help debugging these issues. (examples below). The below depends on the 3-part series I sent out today for importing DwEmmcDxe and EfiTimeBaseLib from OpenPlatformPkg. But apart from that, I have uploaded branches called devel-OpenPlatformPkg to: https://github.com/tianocore/edk2-platforms/tree/devel-OpenPlatformPkg https://github.com/tianocore/edk2-non-osi/tree/devel-OpenPlatformPkg These branches _will_ be rebased occasionally until they get to a point where they can move out of devel- stage (and hopefully onto master). Build issue description =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D So, one of the hopefully easier ones is what I'm seeing when trying to build the Juno platform: $ PACKAGES_PATH=3D"/work/maint/edk2-platforms:/work/maint/edk2-non-osi" GCC= 5_AARCH64_PREFIX=3Daarch64-linux-gnu- build -a AARCH64 -t GCC5 -p Platform/= ARM/Juno/ArmJuno.dsc -b RELEASE -n 9 results in: <<< GenFds.py... : error F003: Output file for RAW section could not be found for Platform/ARM/Juno/AcpiTables/AcpiTables.inf ### build.py... : error 7000: Failed to execute command GenFds -f /work/maint/edk2-platforms/Platform/ARM/Juno/ArmJuno.fdf= --conf=3D/work/maint/edk2/Conf -o /work/maint/edk2/Build/ArmJuno/RELEASE_G= CC5 -t GCC5 -b RELEASE -p /work/maint/edk2-platforms/Platform/ARM/Juno/ArmJ= uno.dsc -a AARCH64 -D "EFI_SOURCE=3D/work/maint/edk2/EdkCompatibilityPkg" -= D "EDK_SOURCE=3D/work/maint/edk2/EdkCompatibilityPkg" -D "TOOL_CHAIN_TAG=3D= GCC5" -D "TOOLCHAIN=3DGCC5" -D "TARGET=3DRELEASE" -D "FAMILY=3DGCC" -D "WOR= KSPACE=3D/work/maint/edk2" -D "EDK_TOOLS_PATH=3D/work/maint/edk2/BaseTools"= -D "ARCH=3DAARCH64" -D "ECP_SOURCE=3D/work/maint/edk2/EdkCompatibilityPkg" [/work/maint/edk2] - Failed - >>> And when I copy and paste the above command manually, I get: <<< GenFds.py... /work/maint/edk2-platforms/Platform/ARM/Juno/ArmJuno.dsc(34): error 000E: File/directory not found in workspace /work/maint/edk2-platforms/Platform/ARM/Juno/Platform/ARM/VExpress/= ArmVExpress.dsc.inc /work/maint/edk2/Platform/ARM/VExpress/ArmVExpress.dsc.inc >>> So, to an uniformed observer, it seems the portion !include Platform/ARM/VExpress/ArmVExpress.dsc.inc from ArmJuno.dsc gets expanded to "directory ArmJuno.dsc is in" + "Platform/ARM/VExpress/Arm= VExpress.dsc.inc" whereas I was hoping for it to try to find a match for "Platform/ARM/VExpress/ArmVExpress.dsc.inc" along PACKAGES_PATH (and find one in edk2-platforms). I also have the impression that something similar is happening in ArmJuno.fdf for the line INF RuleOverride=3DACPITABLE Platform/ARM/Juno/AcpiTables/AcpiTables.inf generating the error message from the original build command. But I'm not quite sure how to debug these issues (short of fully figuring out the innards of MultipleWorkspace.py, MetaFileParser.py and a few others). Any ideas of where to look, or even what is going on? Would these cases be expected to work? / Leif _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel