From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 222D221A16E3A for ; Wed, 10 May 2017 22:36:03 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2017 22:36:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,322,1491289200"; d="scan'208";a="967112433" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 10 May 2017 22:36:02 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 May 2017 22:36:02 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 May 2017 22:36:01 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.178]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Thu, 11 May 2017 13:35:58 +0800 From: "Yao, Jiewen" To: "Zhang, Chao B" , "edk2-devel@lists.01.org" CC: "Long, Qin" Thread-Topic: [PATCH] SecurityPkg: Add TCG Spec info to TCG related modules Thread-Index: AQHSyhWSjnnI0b5YBkqWQZKNuEfJB6HunLjw Date: Thu, 11 May 2017 05:35:57 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A944BB3@SHSMSX104.ccr.corp.intel.com> References: <20170511051447.123260-1-chao.b.zhang@intel.com> In-Reply-To: <20170511051447.123260-1-chao.b.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SecurityPkg: Add TCG Spec info to TCG related modules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 05:36:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com > -----Original Message----- > From: Zhang, Chao B > Sent: Thursday, May 11, 2017 1:15 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin ; Yao, Jiewen ; Z= hang, > Chao B > Subject: [PATCH] SecurityPkg: Add TCG Spec info to TCG related modules >=20 > Add TCG Spec compliance info to TCG related module INFs. >=20 > Cc: Qin Long > Cc: Yao Jiewen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chao Zhang > --- > .../Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf | 5 > ++++- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf | 8 > ++++++-- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 7 > +++++++ > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 7 > ++++++- > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf | 9 > ++++++++- > 5 files changed, 31 insertions(+), 5 deletions(-) >=20 > diff --git > a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf > b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf > index a11988e..939f6fb 100644 > --- > a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf > +++ > b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf > @@ -1,6 +1,9 @@ > ## @file > # Provides security service for TPM 2.0 measured boot > # > +# Spec Compliance Info: > +# "TCG PC Client Platform Firmware Profile Specification for TPM Fami= ly 2.0 > Level 00 Revision 00.21" > +# > # This library instance hooks LoadImage() API to measure every image th= at > # is not measured in PEI phase. And, it will also measure GPT partition= . > # > @@ -9,7 +12,7 @@ > # This external input must be validated carefully to avoid security iss= ues such > # as buffer overflow or integer overflow. > # > -# Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the = BSD > License > # which accompanies this distribution. The full text of the license may = be found > at > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > index 976972d..3e619b9 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > @@ -1,12 +1,16 @@ > ## @file > # Provides TPM 2.0 TIS/PTP functions for DTPM > -# > +# > +# Spec Compliance Info: > +# "TCG PC Client Platform TPM Profile(PTP) Specification Family 2.0 L= evel 00 > Revision 00.43" > +# "TCG PC Client Specific TPM Interface Specification(TIS) Version 1.= 3" > +# > # This library implements TIS (TPM Interface Specification) and > # PTP (Platform TPM Profile) functions which is > # used for every TPM 2.0 command. Choosing this library means platform = uses > and > # only uses TPM 2.0 DTPM device. > # > -# Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the = BSD > License > # which accompanies this distribution. The full text of the license may = be found > at > diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > index 8efc4e3..85415e8 100644 > --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > @@ -1,5 +1,12 @@ > ## @file > # Produces Tcg2 protocol and measure boot environment > +# > +# Spec Compliance Info: > +# "TCG PC Client Platform Firmware Profile Specification for TPM Fami= ly 2.0 > Level 00 Revision 00.21" > +# along with > +# "Errata for PC Client Specific Platform Firmware Profile Specificat= ion > Version 1.0 Revision 0.21" > +# "TCG EFI Protocol Specification" "Family 2.0" "Level 00 Revision 00= .13" > +# > # This module will produce Tcg2 protocol and measure boot environment. > # > # Caution: This module requires additional review when modified. > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > index 3477d82..1b79ee4 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > @@ -1,9 +1,14 @@ > ## @file > # Initializes TPM 2.0 device and measure FVs in PEI phase > # > +# Spec Compliance Info: > +# "TCG PC Client Platform Firmware Profile Specification for TPM Fami= ly 2.0 > Level 00 Revision 00.21" > +# along with > +# "Errata for PC Client Specific Platform Firmware Profile Specificat= ion > Version 1.0 Revision 0.21" > +# > # This module will initialize TPM device, measure reported FVs and BIOS > version. > # > -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the = BSD > License > # which accompanies this distribution. The full text of the license may = be found > at > diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf > b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf > index c4efa2a..c709743 100644 > --- a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf > +++ b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf > @@ -1,5 +1,12 @@ > ## @file > -# Provides ACPI metholds for TPM 2.0 support > +# Provides ACPI methods for TPM 2.0 support > +# > +# Spec Compliance Info: > +# "TCG ACPI Specification Level 00 Revision 00.37" > +# "Physical Presence Interface Specification Version 1.30 Revision 0= 0.52" > +# "Platform Reset Attack Mitigation Specification Version 1.00" > +# TPM2.0 ACPI device object > +# "TCG PC Client Platform Firmware Profile Specification for TPM Fam= ily 2.0 > Level 00 Revision 00.21" > # > # This driver implements TPM 2.0 definition block in ACPI table and > # registers SMI callback functions for Tcg2 physical presence and > -- > 1.9.5.msysgit.1