From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jiewen.yao@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 54D1321A13489
 for <edk2-devel@lists.01.org>; Thu, 11 May 2017 00:51:24 -0700 (PDT)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga105.jf.intel.com with ESMTP; 11 May 2017 00:51:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,323,1491289200"; d="scan'208";a="1146517023"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by fmsmga001.fm.intel.com with ESMTP; 11 May 2017 00:51:23 -0700
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 11 May 2017 00:51:23 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 11 May 2017 00:51:23 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.178]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.117]) with mapi id 14.03.0319.002;
 Thu, 11 May 2017 15:51:21 +0800
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Fan, Jeff" <jeff.fan@intel.com>, "edk2-devel@lists.01.org"
 <edk2-devel@lists.01.org>
CC: "Dong, Eric" <eric.dong@intel.com>
Thread-Topic: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix logic check error
Thread-Index: AQHSyigcj7RO35DxIUuZOTX9D2oNB6HuwmSw
Date: Thu, 11 May 2017 07:51:21 +0000
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A944DF3@SHSMSX104.ccr.corp.intel.com>
References: <20170511072714.6404-1-jeff.fan@intel.com>
In-Reply-To: <20170511072714.6404-1-jeff.fan@intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 10.0.102.7
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix logic check error
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 11 May 2017 07:51:24 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Fan, Jeff
> Sent: Thursday, May 11, 2017 3:27 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix logic check error
>=20
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan <jeff.fan@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c
> index 2713b19..9588eaf 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c
> @@ -267,7 +267,7 @@ IsInSmmRanges (
>  {
>    UINTN  Index;
>=20
> -  if ((Address < mCpuHotPlugData.SmrrBase) || (Address >=3D
> mCpuHotPlugData.SmrrBase + mCpuHotPlugData.SmrrSize)) {
> +  if ((Address >=3D mCpuHotPlugData.SmrrBase) && (Address <
> mCpuHotPlugData.SmrrBase + mCpuHotPlugData.SmrrSize)) {
>      return TRUE;
>    }
>    for (Index =3D 0; Index < mSmmCpuSmramRangeCount; Index++) {
> --
> 2.9.3.windows.2