* [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check @ 2017-06-05 6:41 Star Zeng 2017-06-05 6:56 ` Yao, Jiewen 2017-06-06 11:10 ` Udit Kumar 0 siblings, 2 replies; 7+ messages in thread From: Star Zeng @ 2017-06-05 6:41 UTC (permalink / raw) To: edk2-devel; +Cc: Star Zeng, Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=587 The Status check in "if (!EFI_ERROR (Status))" condition is useless, it should be NULL pointer check. And this patch also fixes a typo "continous" to "continuous". Cc: Jiewen Yao <jiewen.yao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng <star.zeng@intel.com> --- MdePkg/Library/SmmIoLib/SmmIoLib.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/MdePkg/Library/SmmIoLib/SmmIoLib.c b/MdePkg/Library/SmmIoLib/SmmIoLib.c index 181abb8e25df..f1cb0dace500 100644 --- a/MdePkg/Library/SmmIoLib/SmmIoLib.c +++ b/MdePkg/Library/SmmIoLib/SmmIoLib.c @@ -156,7 +156,7 @@ SmmIsMmioValid ( } /** - Merge continous entries whose type is EfiGcdMemoryTypeMemoryMappedIo. + Merge continuous entries whose type is EfiGcdMemoryTypeMemoryMappedIo. @param[in, out] GcdMemoryMap A pointer to the buffer in which firmware places the current GCD memory map. @@ -217,7 +217,8 @@ MergeGcdMmioEntry ( @param[in] Interface Points to the interface instance. @param[in] Handle The handle on which the interface was installed. - @retval EFI_SUCCESS Notification runs successfully. + @retval EFI_SUCCESS Notification runs successfully. + @retval EFI_OUT_OF_RESOURCES No enough resources to save GCD MMIO map. **/ EFI_STATUS EFIAPI @@ -237,10 +238,10 @@ SmmIoLibInternalEndOfDxeNotify ( MergeGcdMmioEntry (MemSpaceMap, &NumberOfDescriptors); mSmmIoLibGcdMemSpace = AllocateCopyPool (NumberOfDescriptors * sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR), MemSpaceMap); - ASSERT_EFI_ERROR (Status); - if (EFI_ERROR (Status)) { + ASSERT (mSmmIoLibGcdMemSpace != NULL); + if (mSmmIoLibGcdMemSpace == NULL) { gBS->FreePool (MemSpaceMap); - return Status; + return EFI_OUT_OF_RESOURCES; } mSmmIoLibGcdMemNumberOfDesc = NumberOfDescriptors; -- 2.7.0.windows.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check 2017-06-05 6:41 [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check Star Zeng @ 2017-06-05 6:56 ` Yao, Jiewen 2017-06-06 11:10 ` Udit Kumar 1 sibling, 0 replies; 7+ messages in thread From: Yao, Jiewen @ 2017-06-05 6:56 UTC (permalink / raw) To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Zeng, Star Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star > Zeng > Sent: Monday, June 5, 2017 2:41 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com> > Subject: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of > useless Status check > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=587 > > The Status check in "if (!EFI_ERROR (Status))" condition is useless, > it should be NULL pointer check. And this patch also fixes a typo > "continous" to "continuous". > > Cc: Jiewen Yao <jiewen.yao@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng <star.zeng@intel.com> > --- > MdePkg/Library/SmmIoLib/SmmIoLib.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/MdePkg/Library/SmmIoLib/SmmIoLib.c > b/MdePkg/Library/SmmIoLib/SmmIoLib.c > index 181abb8e25df..f1cb0dace500 100644 > --- a/MdePkg/Library/SmmIoLib/SmmIoLib.c > +++ b/MdePkg/Library/SmmIoLib/SmmIoLib.c > @@ -156,7 +156,7 @@ SmmIsMmioValid ( > } > > /** > - Merge continous entries whose type is > EfiGcdMemoryTypeMemoryMappedIo. > + Merge continuous entries whose type is > EfiGcdMemoryTypeMemoryMappedIo. > > @param[in, out] GcdMemoryMap A pointer to the buffer in > which firmware places > the current GCD memory map. > @@ -217,7 +217,8 @@ MergeGcdMmioEntry ( > @param[in] Interface Points to the interface instance. > @param[in] Handle The handle on which the interface was installed. > > - @retval EFI_SUCCESS Notification runs successfully. > + @retval EFI_SUCCESS Notification runs successfully. > + @retval EFI_OUT_OF_RESOURCES No enough resources to save GCD > MMIO map. > **/ > EFI_STATUS > EFIAPI > @@ -237,10 +238,10 @@ SmmIoLibInternalEndOfDxeNotify ( > MergeGcdMmioEntry (MemSpaceMap, &NumberOfDescriptors); > > mSmmIoLibGcdMemSpace = AllocateCopyPool (NumberOfDescriptors * > sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR), MemSpaceMap); > - ASSERT_EFI_ERROR (Status); > - if (EFI_ERROR (Status)) { > + ASSERT (mSmmIoLibGcdMemSpace != NULL); > + if (mSmmIoLibGcdMemSpace == NULL) { > gBS->FreePool (MemSpaceMap); > - return Status; > + return EFI_OUT_OF_RESOURCES; > } > > mSmmIoLibGcdMemNumberOfDesc = NumberOfDescriptors; > -- > 2.7.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check 2017-06-05 6:41 [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check Star Zeng 2017-06-05 6:56 ` Yao, Jiewen @ 2017-06-06 11:10 ` Udit Kumar 2017-06-07 1:10 ` Zeng, Star 1 sibling, 1 reply; 7+ messages in thread From: Udit Kumar @ 2017-06-06 11:10 UTC (permalink / raw) To: Star Zeng, edk2-devel@lists.01.org; +Cc: Jiewen Yao Hi Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star > Zeng > Sent: Monday, June 05, 2017 12:11 PM > To: edk2-devel@lists.01.org > Cc: Jiewen Yao <jiewen.yao@intel.com>; Star Zeng <star.zeng@intel.com> > Subject: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of > useless Status check > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=587 > > The Status check in "if (!EFI_ERROR (Status))" condition is useless, it should be > NULL pointer check. And this patch also fixes a typo "continous" to > "continuous". > > Cc: Jiewen Yao <jiewen.yao@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng <star.zeng@intel.com> > --- > MdePkg/Library/SmmIoLib/SmmIoLib.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/MdePkg/Library/SmmIoLib/SmmIoLib.c > b/MdePkg/Library/SmmIoLib/SmmIoLib.c > index 181abb8e25df..f1cb0dace500 100644 > --- a/MdePkg/Library/SmmIoLib/SmmIoLib.c > +++ b/MdePkg/Library/SmmIoLib/SmmIoLib.c > @@ -156,7 +156,7 @@ SmmIsMmioValid ( > } > > /** > - Merge continous entries whose type is EfiGcdMemoryTypeMemoryMappedIo. > + Merge continuous entries whose type is > EfiGcdMemoryTypeMemoryMappedIo. > > @param[in, out] GcdMemoryMap A pointer to the buffer in which > firmware places > the current GCD memory map. > @@ -217,7 +217,8 @@ MergeGcdMmioEntry ( > @param[in] Interface Points to the interface instance. > @param[in] Handle The handle on which the interface was installed. > > - @retval EFI_SUCCESS Notification runs successfully. > + @retval EFI_SUCCESS Notification runs successfully. > + @retval EFI_OUT_OF_RESOURCES No enough resources to save GCD MMIO > map. > **/ > EFI_STATUS > EFIAPI > @@ -237,10 +238,10 @@ SmmIoLibInternalEndOfDxeNotify ( > MergeGcdMmioEntry (MemSpaceMap, &NumberOfDescriptors); > > mSmmIoLibGcdMemSpace = AllocateCopyPool (NumberOfDescriptors * > sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR), MemSpaceMap); > - ASSERT_EFI_ERROR (Status); > - if (EFI_ERROR (Status)) { > + ASSERT (mSmmIoLibGcdMemSpace != NULL); > + if (mSmmIoLibGcdMemSpace == NULL) { If mSmmIoLibGcdMemSpace is NULL then if condition is not reachable. If not NULL then if condition will be false always, I think if condition is not needed. > gBS->FreePool (MemSpaceMap); > - return Status; > + return EFI_OUT_OF_RESOURCES; > } > > mSmmIoLibGcdMemNumberOfDesc = NumberOfDescriptors; > -- > 2.7.0.windows.1 Regards Udit > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check 2017-06-06 11:10 ` Udit Kumar @ 2017-06-07 1:10 ` Zeng, Star 2017-06-07 1:41 ` UEFI SCT2.5A cannot run with exception wang xiaofeng 2017-06-07 5:04 ` [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check Udit Kumar 0 siblings, 2 replies; 7+ messages in thread From: Zeng, Star @ 2017-06-07 1:10 UTC (permalink / raw) To: Udit Kumar, edk2-devel@lists.01.org; +Cc: Yao, Jiewen, Zeng, Star Hi Udit, What does "If mSmmIoLibGcdMemSpace is NULL then if condition is not reachable." mean? ASSERT_EFI_ERROR macro only effects at DEBUG mode, and the if condition is for error handling. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Udit Kumar Sent: Tuesday, June 6, 2017 7:11 PM To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen.yao@intel.com> Subject: Re: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check Hi Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Star Zeng > Sent: Monday, June 05, 2017 12:11 PM > To: edk2-devel@lists.01.org > Cc: Jiewen Yao <jiewen.yao@intel.com>; Star Zeng <star.zeng@intel.com> > Subject: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check > instead of useless Status check > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=587 > > The Status check in "if (!EFI_ERROR (Status))" condition is useless, > it should be NULL pointer check. And this patch also fixes a typo > "continous" to "continuous". > > Cc: Jiewen Yao <jiewen.yao@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng <star.zeng@intel.com> > --- > MdePkg/Library/SmmIoLib/SmmIoLib.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/MdePkg/Library/SmmIoLib/SmmIoLib.c > b/MdePkg/Library/SmmIoLib/SmmIoLib.c > index 181abb8e25df..f1cb0dace500 100644 > --- a/MdePkg/Library/SmmIoLib/SmmIoLib.c > +++ b/MdePkg/Library/SmmIoLib/SmmIoLib.c > @@ -156,7 +156,7 @@ SmmIsMmioValid ( > } > > /** > - Merge continous entries whose type is EfiGcdMemoryTypeMemoryMappedIo. > + Merge continuous entries whose type is > EfiGcdMemoryTypeMemoryMappedIo. > > @param[in, out] GcdMemoryMap A pointer to the buffer in which > firmware places > the current GCD memory map. > @@ -217,7 +217,8 @@ MergeGcdMmioEntry ( > @param[in] Interface Points to the interface instance. > @param[in] Handle The handle on which the interface was installed. > > - @retval EFI_SUCCESS Notification runs successfully. > + @retval EFI_SUCCESS Notification runs successfully. > + @retval EFI_OUT_OF_RESOURCES No enough resources to save GCD MMIO > map. > **/ > EFI_STATUS > EFIAPI > @@ -237,10 +238,10 @@ SmmIoLibInternalEndOfDxeNotify ( > MergeGcdMmioEntry (MemSpaceMap, &NumberOfDescriptors); > > mSmmIoLibGcdMemSpace = AllocateCopyPool (NumberOfDescriptors * > sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR), MemSpaceMap); > - ASSERT_EFI_ERROR (Status); > - if (EFI_ERROR (Status)) { > + ASSERT (mSmmIoLibGcdMemSpace != NULL); > + if (mSmmIoLibGcdMemSpace == NULL) { If mSmmIoLibGcdMemSpace is NULL then if condition is not reachable. If not NULL then if condition will be false always, I think if condition is not needed. > gBS->FreePool (MemSpaceMap); > - return Status; > + return EFI_OUT_OF_RESOURCES; > } > > mSmmIoLibGcdMemNumberOfDesc = NumberOfDescriptors; > -- > 2.7.0.windows.1 Regards Udit > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* UEFI SCT2.5A cannot run with exception 2017-06-07 1:10 ` Zeng, Star @ 2017-06-07 1:41 ` wang xiaofeng 2017-06-07 1:57 ` Jin, Eric 2017-06-07 5:04 ` [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check Udit Kumar 1 sibling, 1 reply; 7+ messages in thread From: wang xiaofeng @ 2017-06-07 1:41 UTC (permalink / raw) To: edk2-devel@lists.01.org Hi , Thanks all for your kind help. I just update SCT from 2.4B to 2.5A, WIth the same platform, 2.4B cannot be installed on EDK2 shell , we have to switch to EDK1 shell and then switch back. 2.4B can run on edk2shell. 2.5A aslo cannot be installed on EDK2 shell , we have to switch to EDK1 shell and then switch back. Unfortunatelly , the tool cannot run with an CPU exception. The attached file shows the serial log we see when the CPU exception occurs. Any suggestion? Where is the SCT2.5 source code link ? I can try to debug the issue to see which code lead to the exception. \x16�& ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: UEFI SCT2.5A cannot run with exception 2017-06-07 1:41 ` UEFI SCT2.5A cannot run with exception wang xiaofeng @ 2017-06-07 1:57 ` Jin, Eric 0 siblings, 0 replies; 7+ messages in thread From: Jin, Eric @ 2017-06-07 1:57 UTC (permalink / raw) To: wang xiaofeng, edk2-devel@lists.01.org Hi Xiaofeng, Could you please resend the email to utwg@uefi.org for this question? I mean UEFI SCT is not the scope of the EDK2 community. Please don't forget to attach the log file. I don't see it or filtered by system. Thanks. Best Regards Eric -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of wang xiaofeng Sent: Wednesday, June 7, 2017 9:41 AM To: edk2-devel@lists.01.org Subject: [edk2] UEFI SCT2.5A cannot run with exception Hi , Thanks all for your kind help. I just update SCT from 2.4B to 2.5A, WIth the same platform, 2.4B cannot be installed on EDK2 shell , we have to switch to EDK1 shell and then switch back. 2.4B can run on edk2shell. 2.5A aslo cannot be installed on EDK2 shell , we have to switch to EDK1 shell and then switch back. Unfortunatelly , the tool cannot run with an CPU exception. The attached file shows the serial log we see when the CPU exception occurs. Any suggestion? Where is the SCT2.5 source code link ? I can try to debug the issue to see which code lead to the exception. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check 2017-06-07 1:10 ` Zeng, Star 2017-06-07 1:41 ` UEFI SCT2.5A cannot run with exception wang xiaofeng @ 2017-06-07 5:04 ` Udit Kumar 1 sibling, 0 replies; 7+ messages in thread From: Udit Kumar @ 2017-06-07 5:04 UTC (permalink / raw) To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Yao, Jiewen Hi Star I restricted myself into debug mode only , while looking at patch . Regards Udit > -----Original Message----- > From: Zeng, Star [mailto:star.zeng@intel.com] > Sent: Wednesday, June 07, 2017 6:41 AM > To: Udit Kumar <udit.kumar@nxp.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com> > Subject: RE: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead > of useless Status check > > Hi Udit, > > What does "If mSmmIoLibGcdMemSpace is NULL then if condition is not > reachable." mean? > > ASSERT_EFI_ERROR macro only effects at DEBUG mode, and the if condition is > for error handling. > > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Udit > Kumar > Sent: Tuesday, June 6, 2017 7:11 PM > To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen.yao@intel.com> > Subject: Re: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead > of useless Status check > > Hi Star > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Star Zeng > > Sent: Monday, June 05, 2017 12:11 PM > > To: edk2-devel@lists.01.org > > Cc: Jiewen Yao <jiewen.yao@intel.com>; Star Zeng <star.zeng@intel.com> > > Subject: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check > > instead of useless Status check > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=587 > > > > The Status check in "if (!EFI_ERROR (Status))" condition is useless, > > it should be NULL pointer check. And this patch also fixes a typo > > "continous" to "continuous". > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Star Zeng <star.zeng@intel.com> > > --- > > MdePkg/Library/SmmIoLib/SmmIoLib.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/MdePkg/Library/SmmIoLib/SmmIoLib.c > > b/MdePkg/Library/SmmIoLib/SmmIoLib.c > > index 181abb8e25df..f1cb0dace500 100644 > > --- a/MdePkg/Library/SmmIoLib/SmmIoLib.c > > +++ b/MdePkg/Library/SmmIoLib/SmmIoLib.c > > @@ -156,7 +156,7 @@ SmmIsMmioValid ( > > } > > > > /** > > - Merge continous entries whose type is > EfiGcdMemoryTypeMemoryMappedIo. > > + Merge continuous entries whose type is > > EfiGcdMemoryTypeMemoryMappedIo. > > > > @param[in, out] GcdMemoryMap A pointer to the buffer in which > > firmware places > > the current GCD memory map. > > @@ -217,7 +217,8 @@ MergeGcdMmioEntry ( > > @param[in] Interface Points to the interface instance. > > @param[in] Handle The handle on which the interface was installed. > > > > - @retval EFI_SUCCESS Notification runs successfully. > > + @retval EFI_SUCCESS Notification runs successfully. > > + @retval EFI_OUT_OF_RESOURCES No enough resources to save GCD > MMIO > > map. > > **/ > > EFI_STATUS > > EFIAPI > > @@ -237,10 +238,10 @@ SmmIoLibInternalEndOfDxeNotify ( > > MergeGcdMmioEntry (MemSpaceMap, &NumberOfDescriptors); > > > > mSmmIoLibGcdMemSpace = AllocateCopyPool (NumberOfDescriptors * > > sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR), MemSpaceMap); > > - ASSERT_EFI_ERROR (Status); > > - if (EFI_ERROR (Status)) { > > + ASSERT (mSmmIoLibGcdMemSpace != NULL); > > + if (mSmmIoLibGcdMemSpace == NULL) { > > > If mSmmIoLibGcdMemSpace is NULL then if condition is not reachable. > If not NULL then if condition will be false always, I think if condition is not > needed. > > > > gBS->FreePool (MemSpaceMap); > > - return Status; > > + return EFI_OUT_OF_RESOURCES; > > } > > > > mSmmIoLibGcdMemNumberOfDesc = NumberOfDescriptors; > > -- > > 2.7.0.windows.1 > > > Regards > Udit > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-06-07 5:03 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-06-05 6:41 [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check Star Zeng 2017-06-05 6:56 ` Yao, Jiewen 2017-06-06 11:10 ` Udit Kumar 2017-06-07 1:10 ` Zeng, Star 2017-06-07 1:41 ` UEFI SCT2.5A cannot run with exception wang xiaofeng 2017-06-07 1:57 ` Jin, Eric 2017-06-07 5:04 ` [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check Udit Kumar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox