public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Cloud Wang <winggundum82@163.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg CapsuleApp: Fix print info in BuildGatherList()
Date: Fri, 30 Jun 2017 13:00:49 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A971989@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1498826608-30064-1-git-send-email-star.zeng@intel.com>

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Friday, June 30, 2017 8:43 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Cloud Wang
> <winggundum82@163.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] MdeModulePkg CapsuleApp: Fix print info in
> BuildGatherList()
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=614
> 
> Print (L"CapsuleApp: capsule data starts          at 0x%X with
>  size 0x%X\n", (UINTN) CapsuleBuffer, FileSize);
> 
> It should use (UINTN) CapsuleBuffer[Index] and FileSize[Index]
> as parameter.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Cloud Wang <winggundum82@163.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
> b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
> index 63c83b1474a5..393cfe506075 100644
> --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
> +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
> @@ -497,7 +497,7 @@ BuildGatherList (
>        goto ERREXIT;
>      } else {
>        Print (L"CapsuleApp: creating capsule descriptors at 0x%X\n", (UINTN)
> BlockDescriptors1);
> -      Print (L"CapsuleApp: capsule data starts          at 0x%X with size
> 0x%X\n", (UINTN) CapsuleBuffer, FileSize);
> +      Print (L"CapsuleApp: capsule data starts          at 0x%X with size
> 0x%X\n", (UINTN) CapsuleBuffer[Index], FileSize[Index]);
>      }
> 
>      //
> --
> 2.7.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2017-06-30 12:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30 12:43 [PATCH] MdeModulePkg CapsuleApp: Fix print info in BuildGatherList() Star Zeng
2017-06-30 13:00 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A971989@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox