Re: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API

["Yao, Jiewen" <jiewen.yao@intel.com>]

Hi
May I know what test you have done to remove this?

Have you built a real FSP and boot it with FSP Wrapper?

Thank you
Yao Jiewen

> -----Original Message-----
> From: Song, BinX
> Sent: Thursday, August 3, 2017 1:47 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Giri P Mudusuru
> <giri.p.mudusuru@intel.com>
> Subject: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API
> 
> - Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
>   error with VS2015 tool chain
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
>  IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm
> b/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm
> index 122eb9e..ee78312 100644
> --- a/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm
> +++ b/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm
> @@ -16,8 +16,6 @@
>  ; Define assembler characteristics
>  ;
> 
> -extern   ASM_PFX(TempRamInitApi)
> -
>  SECTION .text
> 
>  %macro RET_ESI  0
> @@ -66,11 +64,6 @@ ASM_PFX(SecPlatformInit):
>  ;----------------------------------------------------------------------------
>  global ASM_PFX(ProtectedModeEntryPoint)
>  ASM_PFX(ProtectedModeEntryPoint):
> -  ;
> -  ; Dummy function. Consume 2 API to make sure they can be linked.
> -  ;
> -  mov  eax, ASM_PFX(TempRamInitApi)
> -
>    ; Should never return
>    jmp  $
> 
> --
> 2.10.2.windows.1