From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 002F721AEB0A0 for ; Thu, 3 Aug 2017 06:00:58 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2017 06:03:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,316,1498546800"; d="scan'208";a="295242631" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 03 Aug 2017 06:03:10 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 3 Aug 2017 06:03:10 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 3 Aug 2017 06:03:09 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Thu, 3 Aug 2017 21:03:07 +0800 From: "Yao, Jiewen" To: "Song, BinX" , "edk2-devel@lists.01.org" CC: Giri P Mudusuru Thread-Topic: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API Thread-Index: AdMMG/VCDGqeDKeqTI69ZqXwtAZABgAPMRzQ Date: Thu, 3 Aug 2017 13:03:07 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A98296A@shsmsx102.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF102583089@shsmsx102.ccr.corp.intel.com> In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF102583089@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 13:00:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi May I know what test you have done to remove this? Have you built a real FSP and boot it with FSP Wrapper? Thank you Yao Jiewen > -----Original Message----- > From: Song, BinX > Sent: Thursday, August 3, 2017 1:47 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Giri P Mudusuru > > Subject: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API >=20 > - Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build > error with VS2015 tool chain >=20 > Cc: Jiewen Yao > Cc: Giri P Mudusuru > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Bell Song > --- > IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm | 7 -----= -- > 1 file changed, 7 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.na= sm > b/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm > index 122eb9e..ee78312 100644 > --- a/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm > +++ b/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm > @@ -16,8 +16,6 @@ > ; Define assembler characteristics > ; >=20 > -extern ASM_PFX(TempRamInitApi) > - > SECTION .text >=20 > %macro RET_ESI 0 > @@ -66,11 +64,6 @@ ASM_PFX(SecPlatformInit): > ;-----------------------------------------------------------------------= ----- > global ASM_PFX(ProtectedModeEntryPoint) > ASM_PFX(ProtectedModeEntryPoint): > - ; > - ; Dummy function. Consume 2 API to make sure they can be linked. > - ; > - mov eax, ASM_PFX(TempRamInitApi) > - > ; Should never return > jmp $ >=20 > -- > 2.10.2.windows.1