public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [patch] IntelSiliconPkg/IntelVTdDxe: Update function comments
@ 2017-08-17  1:07 Dandan Bi
  2017-08-17  1:09 ` Yao, Jiewen
  0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2017-08-17  1:07 UTC (permalink / raw)
  To: edk2-devel; +Cc: Jiewen Yao

In commit 4ad5f597153c7cb20a968236c2c7d6ff01994350, the parameters
of some functions have been updated, but miss to update the comments
accordingly. This patch is to update the function comments.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 IntelSiliconPkg/IntelVTdDxe/DmaProtection.h    | 1 +
 IntelSiliconPkg/IntelVTdDxe/TranslationTable.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/IntelSiliconPkg/IntelVTdDxe/DmaProtection.h b/IntelSiliconPkg/IntelVTdDxe/DmaProtection.h
index c3b57a0..c311b29 100644
--- a/IntelSiliconPkg/IntelVTdDxe/DmaProtection.h
+++ b/IntelSiliconPkg/IntelVTdDxe/DmaProtection.h
@@ -314,10 +314,11 @@ DumpSecondLevelPagingEntry (
 
 /**
   Set VTd attribute for a system memory.
 
   @param[in]  VtdIndex                The index used to identify a VTd engine.
+  @param[in]  DomainIdentifier        The domain ID of the source.
   @param[in]  SecondLevelPagingEntry  The second level paging entry in VTd table for the device.
   @param[in]  BaseAddress             The base of device memory address to be used as the DMA memory.
   @param[in]  Length                  The length of device memory address to be used as the DMA memory.
   @param[in]  IoMmuAccess             The IOMMU access.
 
diff --git a/IntelSiliconPkg/IntelVTdDxe/TranslationTable.c b/IntelSiliconPkg/IntelVTdDxe/TranslationTable.c
index 80fc823..bc0c24c 100644
--- a/IntelSiliconPkg/IntelVTdDxe/TranslationTable.c
+++ b/IntelSiliconPkg/IntelVTdDxe/TranslationTable.c
@@ -732,10 +732,11 @@ SplitSecondLevelPage (
 
 /**
   Set VTd attribute for a system memory on second level page entry
 
   @param[in]  VtdIndex                The index used to identify a VTd engine.
+  @param[in]  DomainIdentifier        The domain ID of the source.
   @param[in]  SecondLevelPagingEntry  The second level paging entry in VTd table for the device.
   @param[in]  BaseAddress             The base of device memory address to be used as the DMA memory.
   @param[in]  Length                  The length of device memory address to be used as the DMA memory.
   @param[in]  IoMmuAccess             The IOMMU access.
 
@@ -815,10 +816,11 @@ SetSecondLevelPagingAttribute (
 
 /**
   Set VTd attribute for a system memory.
 
   @param[in]  VtdIndex                The index used to identify a VTd engine.
+  @param[in]  DomainIdentifier        The domain ID of the source.
   @param[in]  SecondLevelPagingEntry  The second level paging entry in VTd table for the device.
   @param[in]  BaseAddress             The base of device memory address to be used as the DMA memory.
   @param[in]  Length                  The length of device memory address to be used as the DMA memory.
   @param[in]  IoMmuAccess             The IOMMU access.
 
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-17  1:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-17  1:07 [patch] IntelSiliconPkg/IntelVTdDxe: Update function comments Dandan Bi
2017-08-17  1:09 ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox