* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
[not found] <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com>
@ 2017-08-21 8:19 ` Gao, Liming
2017-08-21 8:21 ` Song, BinX
2017-08-21 8:25 ` Yao, Jiewen
2017-08-22 22:26 ` Kinney, Michael D
2 siblings, 1 reply; 11+ messages in thread
From: Gao, Liming @ 2017-08-21 8:19 UTC (permalink / raw)
To: Song, BinX, Yao, Jiewen; +Cc: edk2-devel@lists.01.org
Bin:
Please remove VS2015 from the comments in source files.
Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Song, BinX
>Sent: Monday, August 21, 2017 2:35 PM
>To: Yao, Jiewen <jiewen.yao@intel.com>
>Cc: edk2-devel@lists.01.org
>Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE
>option
>
>V2:
>- Recover TempRamInitApi API and add dummy TempRamInitApi function to
>fix
> build error with WHOLEARCHIVE option
>
>V1:
>- Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
> error with VS2015 tool chain
>
>Cc: Jiewen Yao <jiewen.yao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Bell Song <binx.song@intel.com>
>---
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
> 2 files changed, 20 insertions(+)
>
>diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>index 9744e16..81b531e 100644
>--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>@@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
> ret
>
> ;----------------------------------------------------------------------------
>+; TempRamInit API
>+;
>+; Dummy function for VS2015 WHOLEARCHIVE build option
>+;
>+;----------------------------------------------------------------------------
>+global ASM_PFX(TempRamInitApi)
>+ASM_PFX(TempRamInitApi):
>+ ret
>+
>+;----------------------------------------------------------------------------
> ; Module Entrypoint API
> ;----------------------------------------------------------------------------
> global ASM_PFX(_ModuleEntryPoint)
>diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>index cdc1149..06a791f 100644
>--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>@@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
> ret
>
> ;----------------------------------------------------------------------------
>+; TempRamInit API
>+;
>+; Dummy function for VS2015 WHOLEARCHIVE build option
>+;
>+;----------------------------------------------------------------------------
>+global ASM_PFX(TempRamInitApi)
>+ASM_PFX(TempRamInitApi):
>+ ret
>+
>+;----------------------------------------------------------------------------
> ; Module Entrypoint API
> ;----------------------------------------------------------------------------
> global ASM_PFX(_ModuleEntryPoint)
>--
>2.10.2.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
2017-08-21 8:19 ` [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option Gao, Liming
@ 2017-08-21 8:21 ` Song, BinX
0 siblings, 0 replies; 11+ messages in thread
From: Song, BinX @ 2017-08-21 8:21 UTC (permalink / raw)
To: Gao, Liming, Yao, Jiewen; +Cc: edk2-devel@lists.01.org
Hi Liming,
Got it, will update V3.
Best Regards,
Bell Song
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, August 21, 2017 4:20 PM
> To: Song, BinX <binx.song@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE
> option
>
> Bin:
> Please remove VS2015 from the comments in source files.
>
> Thanks
> Liming
> >-----Original Message-----
> >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> >Song, BinX
> >Sent: Monday, August 21, 2017 2:35 PM
> >To: Yao, Jiewen <jiewen.yao@intel.com>
> >Cc: edk2-devel@lists.01.org
> >Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE
> >option
> >
> >V2:
> >- Recover TempRamInitApi API and add dummy TempRamInitApi function to
> >fix
> > build error with WHOLEARCHIVE option
> >
> >V1:
> >- Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
> > error with VS2015 tool chain
> >
> >Cc: Jiewen Yao <jiewen.yao@intel.com>
> >Contributed-under: TianoCore Contribution Agreement 1.0
> >Signed-off-by: Bell Song <binx.song@intel.com>
> >---
> > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
> > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
> > 2 files changed, 20 insertions(+)
> >
> >diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> >b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> >index 9744e16..81b531e 100644
> >--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> >+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> >@@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
> > ret
> >
> > ;----------------------------------------------------------------------------
> >+; TempRamInit API
> >+;
> >+; Dummy function for VS2015 WHOLEARCHIVE build option
> >+;
> >+;----------------------------------------------------------------------------
> >+global ASM_PFX(TempRamInitApi)
> >+ASM_PFX(TempRamInitApi):
> >+ ret
> >+
> >+;----------------------------------------------------------------------------
> > ; Module Entrypoint API
> > ;----------------------------------------------------------------------------
> > global ASM_PFX(_ModuleEntryPoint)
> >diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> >b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> >index cdc1149..06a791f 100644
> >--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> >+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> >@@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
> > ret
> >
> > ;----------------------------------------------------------------------------
> >+; TempRamInit API
> >+;
> >+; Dummy function for VS2015 WHOLEARCHIVE build option
> >+;
> >+;----------------------------------------------------------------------------
> >+global ASM_PFX(TempRamInitApi)
> >+ASM_PFX(TempRamInitApi):
> >+ ret
> >+
> >+;----------------------------------------------------------------------------
> > ; Module Entrypoint API
> > ;----------------------------------------------------------------------------
> > global ASM_PFX(_ModuleEntryPoint)
> >--
> >2.10.2.windows.1
> >
> >_______________________________________________
> >edk2-devel mailing list
> >edk2-devel@lists.01.org
> >https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
[not found] <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com>
2017-08-21 8:19 ` [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option Gao, Liming
@ 2017-08-21 8:25 ` Yao, Jiewen
2017-08-21 8:28 ` Song, BinX
2017-08-22 22:26 ` Kinney, Michael D
2 siblings, 1 reply; 11+ messages in thread
From: Yao, Jiewen @ 2017-08-21 8:25 UTC (permalink / raw)
To: Song, BinX; +Cc: edk2-devel@lists.01.org
Hi
Can we add "JMP $" before ret for the empty function?
It is to prevent the empty function is linked by mistake.
Thank you
Yao Jiewen
> -----Original Message-----
> From: Song, BinX
> Sent: Monday, August 21, 2017 2:35 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
>
> V2:
> - Recover TempRamInitApi API and add dummy TempRamInitApi function to fix
> build error with WHOLEARCHIVE option
>
> V1:
> - Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
> error with VS2015 tool chain
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> index 9744e16..81b531e 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
> ret
>
> ;----------------------------------------------------------------------------
> +; TempRamInit API
> +;
> +; Dummy function for VS2015 WHOLEARCHIVE build option
> +;
> +;----------------------------------------------------------------------------
> +global ASM_PFX(TempRamInitApi)
> +ASM_PFX(TempRamInitApi):
> + ret
> +
> +;----------------------------------------------------------------------------
> ; Module Entrypoint API
> ;----------------------------------------------------------------------------
> global ASM_PFX(_ModuleEntryPoint)
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> index cdc1149..06a791f 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
> ret
>
> ;----------------------------------------------------------------------------
> +; TempRamInit API
> +;
> +; Dummy function for VS2015 WHOLEARCHIVE build option
> +;
> +;----------------------------------------------------------------------------
> +global ASM_PFX(TempRamInitApi)
> +ASM_PFX(TempRamInitApi):
> + ret
> +
> +;----------------------------------------------------------------------------
> ; Module Entrypoint API
> ;----------------------------------------------------------------------------
> global ASM_PFX(_ModuleEntryPoint)
> --
> 2.10.2.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
2017-08-21 8:25 ` Yao, Jiewen
@ 2017-08-21 8:28 ` Song, BinX
0 siblings, 0 replies; 11+ messages in thread
From: Song, BinX @ 2017-08-21 8:28 UTC (permalink / raw)
To: Yao, Jiewen; +Cc: edk2-devel@lists.01.org
Hi Jiewen,
Yes, I will update.
Best Regards,
Bell Song
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Monday, August 21, 2017 4:26 PM
> To: Song, BinX <binx.song@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE
> option
>
> Hi
> Can we add "JMP $" before ret for the empty function?
>
> It is to prevent the empty function is linked by mistake.
>
> Thank you
> Yao Jiewen
>
> > -----Original Message-----
> > From: Song, BinX
> > Sent: Monday, August 21, 2017 2:35 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
> >
> > V2:
> > - Recover TempRamInitApi API and add dummy TempRamInitApi function to
> fix
> > build error with WHOLEARCHIVE option
> >
> > V1:
> > - Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
> > error with VS2015 tool chain
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Bell Song <binx.song@intel.com>
> > ---
> > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
> > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
> > 2 files changed, 20 insertions(+)
> >
> > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> > index 9744e16..81b531e 100644
> > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> > @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
> > ret
> >
> > ;----------------------------------------------------------------------------
> > +; TempRamInit API
> > +;
> > +; Dummy function for VS2015 WHOLEARCHIVE build option
> > +;
> > +;----------------------------------------------------------------------------
> > +global ASM_PFX(TempRamInitApi)
> > +ASM_PFX(TempRamInitApi):
> > + ret
> > +
> > +;----------------------------------------------------------------------------
> > ; Module Entrypoint API
> > ;----------------------------------------------------------------------------
> > global ASM_PFX(_ModuleEntryPoint)
> > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> > index cdc1149..06a791f 100644
> > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> > @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
> > ret
> >
> > ;----------------------------------------------------------------------------
> > +; TempRamInit API
> > +;
> > +; Dummy function for VS2015 WHOLEARCHIVE build option
> > +;
> > +;----------------------------------------------------------------------------
> > +global ASM_PFX(TempRamInitApi)
> > +ASM_PFX(TempRamInitApi):
> > + ret
> > +
> > +;----------------------------------------------------------------------------
> > ; Module Entrypoint API
> > ;----------------------------------------------------------------------------
> > global ASM_PFX(_ModuleEntryPoint)
> > --
> > 2.10.2.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
[not found] <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com>
2017-08-21 8:19 ` [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option Gao, Liming
2017-08-21 8:25 ` Yao, Jiewen
@ 2017-08-22 22:26 ` Kinney, Michael D
2017-08-23 2:34 ` Gao, Liming
2 siblings, 1 reply; 11+ messages in thread
From: Kinney, Michael D @ 2017-08-22 22:26 UTC (permalink / raw)
To: Song, BinX, Yao, Jiewen, Kinney, Michael D; +Cc: edk2-devel@lists.01.org
Bell Song,
Why is it documented as a "Dummy" function?
There must be a reference to this symbol somewhere or it would
not generate a link error. The implementation is an empty
function. Is that a better way to describe this function?
Mike
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
> Behalf Of Song, BinX
> Sent: Sunday, August 20, 2017 11:35 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
> WHOLEARCHIVE option
>
> V2:
> - Recover TempRamInitApi API and add dummy TempRamInitApi
> function to fix
> build error with WHOLEARCHIVE option
>
> V1:
> - Delete useless external TempRamInitApi API to fix
> /WHOLEARCHIVE build
> error with VS2015 tool chain
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> index 9744e16..81b531e 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
> ret
>
> ;--------------------------------------------------------------
> --------------
> +; TempRamInit API
> +;
> +; Dummy function for VS2015 WHOLEARCHIVE build option
> +;
> +;--------------------------------------------------------------
> --------------
> +global ASM_PFX(TempRamInitApi)
> +ASM_PFX(TempRamInitApi):
> + ret
> +
> +;--------------------------------------------------------------
> --------------
> ; Module Entrypoint API
> ;--------------------------------------------------------------
> --------------
> global ASM_PFX(_ModuleEntryPoint)
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> index cdc1149..06a791f 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
> ret
>
> ;--------------------------------------------------------------
> --------------
> +; TempRamInit API
> +;
> +; Dummy function for VS2015 WHOLEARCHIVE build option
> +;
> +;--------------------------------------------------------------
> --------------
> +global ASM_PFX(TempRamInitApi)
> +ASM_PFX(TempRamInitApi):
> + ret
> +
> +;--------------------------------------------------------------
> --------------
> ; Module Entrypoint API
> ;--------------------------------------------------------------
> --------------
> global ASM_PFX(_ModuleEntryPoint)
> --
> 2.10.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
2017-08-22 22:26 ` Kinney, Michael D
@ 2017-08-23 2:34 ` Gao, Liming
2017-08-23 2:54 ` Yao, Jiewen
2017-08-23 16:08 ` Kinney, Michael D
0 siblings, 2 replies; 11+ messages in thread
From: Gao, Liming @ 2017-08-23 2:34 UTC (permalink / raw)
To: Kinney, Michael D, Song, BinX, Yao, Jiewen, Kinney, Michael D
Cc: edk2-devel@lists.01.org
Mike:
TempRamInitApi() is referred in Library\SecFspSecPlatformLibNull\Ia32\Flat32.nasm. FspSecCoreM, FspSecCoreS and FspSecCoreT all link this library.
How about describe this function as the empty implementation?
Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Kinney, Michael D
>Sent: Wednesday, August 23, 2017 6:27 AM
>To: Song, BinX <binx.song@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
>Kinney, Michael D <michael.d.kinney@intel.com>
>Cc: edk2-devel@lists.01.org
>Subject: Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>WHOLEARCHIVE option
>
>Bell Song,
>
>Why is it documented as a "Dummy" function?
>
>There must be a reference to this symbol somewhere or it would
>not generate a link error. The implementation is an empty
>function. Is that a better way to describe this function?
>
>Mike
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
>> Behalf Of Song, BinX
>> Sent: Sunday, August 20, 2017 11:35 PM
>> To: Yao, Jiewen <jiewen.yao@intel.com>
>> Cc: edk2-devel@lists.01.org
>> Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>> WHOLEARCHIVE option
>>
>> V2:
>> - Recover TempRamInitApi API and add dummy TempRamInitApi
>> function to fix
>> build error with WHOLEARCHIVE option
>>
>> V1:
>> - Delete useless external TempRamInitApi API to fix
>> /WHOLEARCHIVE build
>> error with VS2015 tool chain
>>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Bell Song <binx.song@intel.com>
>> ---
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> index 9744e16..81b531e 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> index cdc1149..06a791f 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> --
>> 2.10.2.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
2017-08-23 2:34 ` Gao, Liming
@ 2017-08-23 2:54 ` Yao, Jiewen
2017-08-23 3:01 ` Song, BinX
2017-08-23 16:08 ` Kinney, Michael D
1 sibling, 1 reply; 11+ messages in thread
From: Yao, Jiewen @ 2017-08-23 2:54 UTC (permalink / raw)
To: Gao, Liming, Kinney, Michael D, Song, BinX, Kinney, Michael D
Cc: edk2-devel@lists.01.org
I checked existing code, we have below styles:
MD4 Digest Wrapper Implementation which does not provide real capabilities.
Null Base Debug Library instance with empty functions.
A emptry template implementation of PCD Library.
Base Performance Library which provides no service.
I think we can name it to be "empty functions", "empty implementation"
Thank you
Yao Jiewen
From: Gao, Liming
Sent: Wednesday, August 23, 2017 10:35 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; Song, BinX <binx.song@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
Mike:
TempRamInitApi() is referred in Library\SecFspSecPlatformLibNull\Ia32\Flat32.nasm. FspSecCoreM, FspSecCoreS and FspSecCoreT all link this library.
How about describe this function as the empty implementation?
Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Kinney, Michael D
>Sent: Wednesday, August 23, 2017 6:27 AM
>To: Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>;
>Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
>Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>Subject: Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>WHOLEARCHIVE option
>
>Bell Song,
>
>Why is it documented as a "Dummy" function?
>
>There must be a reference to this symbol somewhere or it would
>not generate a link error. The implementation is an empty
>function. Is that a better way to describe this function?
>
>Mike
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
>> Behalf Of Song, BinX
>> Sent: Sunday, August 20, 2017 11:35 PM
>> To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
>> Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>> WHOLEARCHIVE option
>>
>> V2:
>> - Recover TempRamInitApi API and add dummy TempRamInitApi
>> function to fix
>> build error with WHOLEARCHIVE option
>>
>> V1:
>> - Delete useless external TempRamInitApi API to fix
>> /WHOLEARCHIVE build
>> error with VS2015 tool chain
>>
>> Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Bell Song <binx.song@intel.com<mailto:binx.song@intel.com>>
>> ---
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> index 9744e16..81b531e 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> index cdc1149..06a791f 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> --
>> 2.10.2.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> https://lists.01.org/mailman/listinfo/edk2-devel
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
2017-08-23 2:54 ` Yao, Jiewen
@ 2017-08-23 3:01 ` Song, BinX
2017-08-23 3:03 ` Yao, Jiewen
0 siblings, 1 reply; 11+ messages in thread
From: Song, BinX @ 2017-08-23 3:01 UTC (permalink / raw)
To: Yao, Jiewen, Gao, Liming, Kinney, Michael D, Kinney, Michael D
Cc: edk2-devel@lists.01.org
Hi Jiewen,
Do I need to update this patch?
Best Regards,
Bell Song
From: Yao, Jiewen
Sent: Wednesday, August 23, 2017 10:54 AM
To: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Song, BinX <binx.song@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
I checked existing code, we have below styles:
MD4 Digest Wrapper Implementation which does not provide real capabilities.
Null Base Debug Library instance with empty functions.
A emptry template implementation of PCD Library.
Base Performance Library which provides no service.
I think we can name it to be "empty functions", "empty implementation"
Thank you
Yao Jiewen
From: Gao, Liming
Sent: Wednesday, August 23, 2017 10:35 AM
To: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
Mike:
TempRamInitApi() is referred in Library\SecFspSecPlatformLibNull\Ia32\Flat32.nasm. FspSecCoreM, FspSecCoreS and FspSecCoreT all link this library.
How about describe this function as the empty implementation?
Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Kinney, Michael D
>Sent: Wednesday, August 23, 2017 6:27 AM
>To: Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>;
>Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
>Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>Subject: Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>WHOLEARCHIVE option
>
>Bell Song,
>
>Why is it documented as a "Dummy" function?
>
>There must be a reference to this symbol somewhere or it would
>not generate a link error. The implementation is an empty
>function. Is that a better way to describe this function?
>
>Mike
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
>> Behalf Of Song, BinX
>> Sent: Sunday, August 20, 2017 11:35 PM
>> To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
>> Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>> WHOLEARCHIVE option
>>
>> V2:
>> - Recover TempRamInitApi API and add dummy TempRamInitApi
>> function to fix
>> build error with WHOLEARCHIVE option
>>
>> V1:
>> - Delete useless external TempRamInitApi API to fix
>> /WHOLEARCHIVE build
>> error with VS2015 tool chain
>>
>> Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Bell Song <binx.song@intel.com<mailto:binx.song@intel.com>>
>> ---
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> index 9744e16..81b531e 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> index cdc1149..06a791f 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> --
>> 2.10.2.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> https://lists.01.org/mailman/listinfo/edk2-devel
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
2017-08-23 3:01 ` Song, BinX
@ 2017-08-23 3:03 ` Yao, Jiewen
2017-08-23 3:04 ` Song, BinX
0 siblings, 1 reply; 11+ messages in thread
From: Yao, Jiewen @ 2017-08-23 3:03 UTC (permalink / raw)
To: Song, BinX, Gao, Liming, Kinney, Michael D, Kinney, Michael D
Cc: edk2-devel@lists.01.org
Never mind.
If we agree to use "empty" in comment, I can update for you when I check in.
Thank you
Yao Jiewen
From: Song, BinX
Sent: Wednesday, August 23, 2017 11:02 AM
To: Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
Hi Jiewen,
Do I need to update this patch?
Best Regards,
Bell Song
From: Yao, Jiewen
Sent: Wednesday, August 23, 2017 10:54 AM
To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
I checked existing code, we have below styles:
MD4 Digest Wrapper Implementation which does not provide real capabilities.
Null Base Debug Library instance with empty functions.
A emptry template implementation of PCD Library.
Base Performance Library which provides no service.
I think we can name it to be "empty functions", "empty implementation"
Thank you
Yao Jiewen
From: Gao, Liming
Sent: Wednesday, August 23, 2017 10:35 AM
To: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
Mike:
TempRamInitApi() is referred in Library\SecFspSecPlatformLibNull\Ia32\Flat32.nasm. FspSecCoreM, FspSecCoreS and FspSecCoreT all link this library.
How about describe this function as the empty implementation?
Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Kinney, Michael D
>Sent: Wednesday, August 23, 2017 6:27 AM
>To: Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>;
>Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
>Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>Subject: Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>WHOLEARCHIVE option
>
>Bell Song,
>
>Why is it documented as a "Dummy" function?
>
>There must be a reference to this symbol somewhere or it would
>not generate a link error. The implementation is an empty
>function. Is that a better way to describe this function?
>
>Mike
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
>> Behalf Of Song, BinX
>> Sent: Sunday, August 20, 2017 11:35 PM
>> To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
>> Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>> WHOLEARCHIVE option
>>
>> V2:
>> - Recover TempRamInitApi API and add dummy TempRamInitApi
>> function to fix
>> build error with WHOLEARCHIVE option
>>
>> V1:
>> - Delete useless external TempRamInitApi API to fix
>> /WHOLEARCHIVE build
>> error with VS2015 tool chain
>>
>> Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Bell Song <binx.song@intel.com<mailto:binx.song@intel.com>>
>> ---
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> index 9744e16..81b531e 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> index cdc1149..06a791f 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> --
>> 2.10.2.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> https://lists.01.org/mailman/listinfo/edk2-devel
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
2017-08-23 3:03 ` Yao, Jiewen
@ 2017-08-23 3:04 ` Song, BinX
0 siblings, 0 replies; 11+ messages in thread
From: Song, BinX @ 2017-08-23 3:04 UTC (permalink / raw)
To: Yao, Jiewen, Gao, Liming, Kinney, Michael D, Kinney, Michael D
Cc: edk2-devel@lists.01.org
Got it, thanks.
Best Regards,
Bell Song
From: Yao, Jiewen
Sent: Wednesday, August 23, 2017 11:03 AM
To: Song, BinX <binx.song@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
Never mind.
If we agree to use "empty" in comment, I can update for you when I check in.
Thank you
Yao Jiewen
From: Song, BinX
Sent: Wednesday, August 23, 2017 11:02 AM
To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
Hi Jiewen,
Do I need to update this patch?
Best Regards,
Bell Song
From: Yao, Jiewen
Sent: Wednesday, August 23, 2017 10:54 AM
To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
I checked existing code, we have below styles:
MD4 Digest Wrapper Implementation which does not provide real capabilities.
Null Base Debug Library instance with empty functions.
A emptry template implementation of PCD Library.
Base Performance Library which provides no service.
I think we can name it to be "empty functions", "empty implementation"
Thank you
Yao Jiewen
From: Gao, Liming
Sent: Wednesday, August 23, 2017 10:35 AM
To: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
Mike:
TempRamInitApi() is referred in Library\SecFspSecPlatformLibNull\Ia32\Flat32.nasm. FspSecCoreM, FspSecCoreS and FspSecCoreT all link this library.
How about describe this function as the empty implementation?
Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Kinney, Michael D
>Sent: Wednesday, August 23, 2017 6:27 AM
>To: Song, BinX <binx.song@intel.com<mailto:binx.song@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>;
>Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
>Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>Subject: Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>WHOLEARCHIVE option
>
>Bell Song,
>
>Why is it documented as a "Dummy" function?
>
>There must be a reference to this symbol somewhere or it would
>not generate a link error. The implementation is an empty
>function. Is that a better way to describe this function?
>
>Mike
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
>> Behalf Of Song, BinX
>> Sent: Sunday, August 20, 2017 11:35 PM
>> To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
>> Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with
>> WHOLEARCHIVE option
>>
>> V2:
>> - Recover TempRamInitApi API and add dummy TempRamInitApi
>> function to fix
>> build error with WHOLEARCHIVE option
>>
>> V1:
>> - Delete useless external TempRamInitApi API to fix
>> /WHOLEARCHIVE build
>> error with VS2015 tool chain
>>
>> Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Bell Song <binx.song@intel.com<mailto:binx.song@intel.com>>
>> ---
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
>> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> index 9744e16..81b531e 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>> @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> index cdc1149..06a791f 100644
>> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>> @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
>> ret
>>
>> ;--------------------------------------------------------------
>> --------------
>> +; TempRamInit API
>> +;
>> +; Dummy function for VS2015 WHOLEARCHIVE build option
>> +;
>> +;--------------------------------------------------------------
>> --------------
>> +global ASM_PFX(TempRamInitApi)
>> +ASM_PFX(TempRamInitApi):
>> + ret
>> +
>> +;--------------------------------------------------------------
>> --------------
>> ; Module Entrypoint API
>> ;--------------------------------------------------------------
>> --------------
>> global ASM_PFX(_ModuleEntryPoint)
>> --
>> 2.10.2.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> https://lists.01.org/mailman/listinfo/edk2-devel
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
2017-08-23 2:34 ` Gao, Liming
2017-08-23 2:54 ` Yao, Jiewen
@ 2017-08-23 16:08 ` Kinney, Michael D
1 sibling, 0 replies; 11+ messages in thread
From: Kinney, Michael D @ 2017-08-23 16:08 UTC (permalink / raw)
To: Gao, Liming, Song, BinX, Yao, Jiewen, Kinney, Michael D
Cc: edk2-devel@lists.01.org
Liming,
Yes. "empty" is a better term to use.
Mike
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, August 22, 2017 7:35 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; Song, BinX
> <binx.song@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with
> WHOLEARCHIVE option
>
> Mike:
> TempRamInitApi() is referred in
> Library\SecFspSecPlatformLibNull\Ia32\Flat32.nasm. FspSecCoreM,
> FspSecCoreS and FspSecCoreT all link this library.
>
> How about describe this function as the empty implementation?
>
> Thanks
> Liming
> >-----Original Message-----
> >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
> Behalf Of
> >Kinney, Michael D
> >Sent: Wednesday, August 23, 2017 6:27 AM
> >To: Song, BinX <binx.song@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>;
> >Kinney, Michael D <michael.d.kinney@intel.com>
> >Cc: edk2-devel@lists.01.org
> >Subject: Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error
> with
> >WHOLEARCHIVE option
> >
> >Bell Song,
> >
> >Why is it documented as a "Dummy" function?
> >
> >There must be a reference to this symbol somewhere or it would
> >not generate a link error. The implementation is an empty
> >function. Is that a better way to describe this function?
> >
> >Mike
> >
> >> -----Original Message-----
> >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
> >> Behalf Of Song, BinX
> >> Sent: Sunday, August 20, 2017 11:35 PM
> >> To: Yao, Jiewen <jiewen.yao@intel.com>
> >> Cc: edk2-devel@lists.01.org
> >> Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error
> with
> >> WHOLEARCHIVE option
> >>
> >> V2:
> >> - Recover TempRamInitApi API and add dummy TempRamInitApi
> >> function to fix
> >> build error with WHOLEARCHIVE option
> >>
> >> V1:
> >> - Delete useless external TempRamInitApi API to fix
> >> /WHOLEARCHIVE build
> >> error with VS2015 tool chain
> >>
> >> Cc: Jiewen Yao <jiewen.yao@intel.com>
> >> Contributed-under: TianoCore Contribution Agreement 1.0
> >> Signed-off-by: Bell Song <binx.song@intel.com>
> >> ---
> >> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10
> ++++++++++
> >> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10
> ++++++++++
> >> 2 files changed, 20 insertions(+)
> >>
> >> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> >> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> >> index 9744e16..81b531e 100644
> >> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> >> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
> >> @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
> >> ret
> >>
> >> ;----------------------------------------------------------
> ----
> >> --------------
> >> +; TempRamInit API
> >> +;
> >> +; Dummy function for VS2015 WHOLEARCHIVE build option
> >> +;
> >> +;----------------------------------------------------------
> ----
> >> --------------
> >> +global ASM_PFX(TempRamInitApi)
> >> +ASM_PFX(TempRamInitApi):
> >> + ret
> >> +
> >> +;----------------------------------------------------------
> ----
> >> --------------
> >> ; Module Entrypoint API
> >> ;----------------------------------------------------------
> ----
> >> --------------
> >> global ASM_PFX(_ModuleEntryPoint)
> >> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> >> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> >> index cdc1149..06a791f 100644
> >> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> >> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
> >> @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
> >> ret
> >>
> >> ;----------------------------------------------------------
> ----
> >> --------------
> >> +; TempRamInit API
> >> +;
> >> +; Dummy function for VS2015 WHOLEARCHIVE build option
> >> +;
> >> +;----------------------------------------------------------
> ----
> >> --------------
> >> +global ASM_PFX(TempRamInitApi)
> >> +ASM_PFX(TempRamInitApi):
> >> + ret
> >> +
> >> +;----------------------------------------------------------
> ----
> >> --------------
> >> ; Module Entrypoint API
> >> ;----------------------------------------------------------
> ----
> >> --------------
> >> global ASM_PFX(_ModuleEntryPoint)
> >> --
> >> 2.10.2.windows.1
> >>
> >> _______________________________________________
> >> edk2-devel mailing list
> >> edk2-devel@lists.01.org
> >> https://lists.01.org/mailman/listinfo/edk2-devel
> >_______________________________________________
> >edk2-devel mailing list
> >edk2-devel@lists.01.org
> >https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-08-23 16:06 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com>
2017-08-21 8:19 ` [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option Gao, Liming
2017-08-21 8:21 ` Song, BinX
2017-08-21 8:25 ` Yao, Jiewen
2017-08-21 8:28 ` Song, BinX
2017-08-22 22:26 ` Kinney, Michael D
2017-08-23 2:34 ` Gao, Liming
2017-08-23 2:54 ` Yao, Jiewen
2017-08-23 3:01 ` Song, BinX
2017-08-23 3:03 ` Yao, Jiewen
2017-08-23 3:04 ` Song, BinX
2017-08-23 16:08 ` Kinney, Michael D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox