From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C745021E11D27 for ; Tue, 29 Aug 2017 05:10:10 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2017 05:12:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,444,1498546800"; d="scan'208";a="1167212601" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 29 Aug 2017 05:12:48 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 29 Aug 2017 05:12:48 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 29 Aug 2017 05:12:48 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.39]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.168]) with mapi id 14.03.0319.002; Tue, 29 Aug 2017 20:12:46 +0800 From: "Yao, Jiewen" To: "Wu, Hao A" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] IntelSiliconPkg/PlatformVTdSample: Avoid using constant result 'if' Thread-Index: AQHTILwqWQQUiNdZwEWNhfz+Z6tQaKKbPr0A Date: Tue, 29 Aug 2017 12:12:45 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A9A3757@shsmsx102.ccr.corp.intel.com> References: <20170829114411.20468-1-hao.a.wu@intel.com> In-Reply-To: <20170829114411.20468-1-hao.a.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] IntelSiliconPkg/PlatformVTdSample: Avoid using constant result 'if' X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 12:10:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen.yao@Intel.com > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, August 29, 2017 7:44 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen > Subject: [PATCH] IntelSiliconPkg/PlatformVTdSample: Avoid using constant = result > 'if' >=20 > In this sample driver, if (0) {...} else {...} statements were used to > illustrate two different using scenarios. >=20 > This comment refines the coding style by substituting the 'if (0)' > statement with comments to select sample codes for different cases. >=20 > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > .../PlatformVTdSampleDxe/PlatformVTdSampleDxe.c | 38 > ++++++++++++++-------- > 1 file changed, 24 insertions(+), 14 deletions(-) >=20 > diff --git a/IntelSiliconPkg/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c > b/IntelSiliconPkg/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c > index 07499c7da8..3587fa3c83 100644 > --- a/IntelSiliconPkg/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c > +++ b/IntelSiliconPkg/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c > @@ -339,23 +339,33 @@ PlatformVTdGetExceptionDeviceList ( > return EFI_INVALID_PARAMETER; > } >=20 > - if (0) { > - *DeviceInfo =3D AllocateZeroPool (sizeof(mExceptionDeviceScopeList))= ; > - if (*DeviceInfo =3D=3D NULL) { > - return EFI_OUT_OF_RESOURCES; > - } > - CopyMem (*DeviceInfo, mExceptionDeviceScopeList, > sizeof(mExceptionDeviceScopeList)); > + // > + // Sample codes for device scope based exception list. > + // Uncomment to take affect and comment the sample codes for PCI vendo= r > id > + // based exception list. > + // > + /* > + *DeviceInfo =3D AllocateZeroPool (sizeof(mExceptionDeviceScopeList)); > + if (*DeviceInfo =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + CopyMem (*DeviceInfo, mExceptionDeviceScopeList, > sizeof(mExceptionDeviceScopeList)); >=20 > - *DeviceInfoCount =3D ARRAY_SIZE(mExceptionDeviceScopeList); > - } else { > - *DeviceInfo =3D AllocateZeroPool (sizeof(mExceptionPciDeviceIdList))= ; > - if (*DeviceInfo =3D=3D NULL) { > - return EFI_OUT_OF_RESOURCES; > - } > - CopyMem (*DeviceInfo, mExceptionPciDeviceIdList, > sizeof(mExceptionPciDeviceIdList)); > + *DeviceInfoCount =3D ARRAY_SIZE(mExceptionDeviceScopeList); > + */ >=20 > - *DeviceInfoCount =3D ARRAY_SIZE(mExceptionPciDeviceIdList); > + // > + // Sample codes for PCI vendor id based exception list. > + // Uncomment to take affect and comment the sample codes for device > scope > + // based exception list. > + // > + *DeviceInfo =3D AllocateZeroPool (sizeof(mExceptionPciDeviceIdList)); > + if (*DeviceInfo =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > } > + CopyMem (*DeviceInfo, mExceptionPciDeviceIdList, > sizeof(mExceptionPciDeviceIdList)); > + > + *DeviceInfoCount =3D ARRAY_SIZE(mExceptionPciDeviceIdList); >=20 > return EFI_SUCCESS; > } > -- > 2.12.0.windows.1