From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B69CA20945C0B for ; Fri, 8 Sep 2017 00:25:33 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 08 Sep 2017 00:28:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,360,1500966000"; d="scan'208";a="126751065" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 08 Sep 2017 00:28:13 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 8 Sep 2017 00:28:12 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 8 Sep 2017 00:28:12 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.39]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.168]) with mapi id 14.03.0319.002; Fri, 8 Sep 2017 15:28:08 +0800 From: "Yao, Jiewen" To: Laszlo Ersek , edk2-devel-01 CC: Ard Biesheuvel , Brijesh Singh , "Dong, Eric" , "Justen, Jordan L" , "Zeng, Star" Thread-Topic: [PATCH 00/10] MdeModulePkg, OvmfPkg: unmap DMA buffers at ExitBootServices Thread-Index: AQHTKCpwX3k2I5VyWkamAZBkx9rGyqKql5Vw Date: Fri, 8 Sep 2017 07:28:08 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A9A9954@shsmsx102.ccr.corp.intel.com> References: <20170907224116.895-1-lersek@redhat.com> In-Reply-To: <20170907224116.895-1-lersek@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 00/10] MdeModulePkg, OvmfPkg: unmap DMA buffers at ExitBootServices X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 07:25:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch 1~3 reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Friday, September 8, 2017 6:41 AM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Brijesh Singh > ; Dong, Eric ; Yao, Jiewen > ; Justen, Jordan L ; Zen= g, > Star > Subject: [PATCH 00/10] MdeModulePkg, OvmfPkg: unmap DMA buffers at > ExitBootServices >=20 > Repo: https://github.com/lersek/edk2.git > Branch: iommu_exit_boot >=20 > This series is the result of the discussion under >=20 > [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common > buffers at ExitBootServices() > https://lists.01.org/pipermail/edk2-devel/2017-September/014099.html >=20 > At ExitBootServices(), PCI and VirtIo drivers should only care about > aborting pending DMA on the devices. Cleaning up PciIo mappings (which > ultimately boil down to IOMMU mappings) for those aborted DMA operations > should be the job of the IOMMU driver. >=20 > Patches 01 through 03 clean up the AtaAtapiPassThru driver in > MdeModulePkg a little bit, because at present, (a) it unmaps the buffers > and disables BMDMA in the wrong order in its DriverBindingStop() > function, (b) it doesn't abort pending DMA at ExitBootServices(). >=20 > This subset can be treated separately from the rest of the series, but I > thought they belonged loosely together (given that AtaAtapiPassThru is > used on QEMU's Q35 machine type). >=20 > Patches 04 through 07 remove > VIRTIO_DEVICE_PROTOCOL.UnmapSharedBuffer() > calls from the VirtIo drivers' ExitBootServices() handlers. >=20 > (The conversion of VirtioNetDxe to device addresses is still in progress > -- Brijesh, when you submit v2 of that, under this approach, there is no > need to change VirtioNetExitBoot() relative to current upstream, and you > can use VirtioOperationBusMasterRead to map outgoing packets.) >=20 > Patches 08 through 10 make OvmfPkg/IoMmuDxe track all mappings, and > unmap all mappings (Read, Write, CommonBuffer) that are in effect when > ExitBootServices() is called. It is ensured that PCI and VirtIo drivers > abort pending DMA first, and IoMmuDxe clean up the mappings last. >=20 > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Eric Dong > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Star Zeng >=20 > Thanks > Laszlo >=20 > Laszlo Ersek (10): > MdeModulePkg/AtaAtapiPassThru: cache EnabledPciAttributes > MdeModulePkg/AtaAtapiPassThru: unmap DMA buffers after disabling BM > DMA > MdeModulePkg/AtaAtapiPassThru: disable the device at > ExitBootServices() > OvmfPkg/VirtioBlkDxe: don't unmap VRING at ExitBootServices() > OvmfPkg/VirtioGpuDxe: don't unmap VRING & BackingStore at > ExitBootServices > OvmfPkg/VirtioRngDxe: don't unmap VRING at ExitBootServices() > OvmfPkg/VirtioScsiDxe: don't unmap VRING at ExitBootServices() > OvmfPkg/IoMmuDxe: track all mappings > OvmfPkg/IoMmuDxe: generalize IoMmuUnmap() to IoMmuUnmapWorker() > OvmfPkg/IoMmuDxe: unmap all IOMMU mappings at ExitBootServices() >=20 > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 103 +++++--- > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h | 7 + > OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 246 > +++++++++++++++++--- > OvmfPkg/VirtioBlkDxe/VirtioBlk.c | 7 +- > OvmfPkg/VirtioGpuDxe/Commands.c | 23 +- > OvmfPkg/VirtioRngDxe/VirtioRng.c | 7 +- > OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 7 +- > 7 files changed, 299 insertions(+), 101 deletions(-) >=20 > -- > 2.14.1.3.gb7cf6e02401b