From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6E70B21ECCB15 for ; Wed, 20 Sep 2017 01:00:24 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 20 Sep 2017 01:03:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,420,1500966000"; d="scan'208,217";a="153424849" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 20 Sep 2017 01:03:29 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Sep 2017 01:03:29 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Sep 2017 01:03:28 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Wed, 20 Sep 2017 16:03:26 +0800 From: "Yao, Jiewen" To: "Wang, Jian J" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , Laszlo Ersek , "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver Thread-Index: AQHTMQ4F11M7jCE8r0WP6av9fLJuYKK8taqAgACVarD//5fUAIAAiM4Q Date: Wed, 20 Sep 2017 08:03:25 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A9BF5F8@shsmsx102.ccr.corp.intel.com> References: <20170919061013.15976-1-jian.j.wang@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503A9BF448@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 08:00:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks. I have no other comments. From: Wang, Jian J Sent: Wednesday, September 20, 2017 3:54 PM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Laszlo Ersek ; Dong, Eric ; Zeng, Star Subject: RE: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU = driver Jiewen, Yes. The patch has passed the validation of the UEFI booting Windows 10, Wi= ndows 7 and Fedora 25. If no comments from you and others, I'll push the patch to upstream soon. Thanks, Jian Wang -----Original Message----- From: Yao, Jiewen Sent: Wednesday, September 20, 2017 2:08 PM To: Wang, Jian J >; edk= 2-devel@lists.01.org Cc: Kinney, Michael D >; Laszlo Ersek >; Don= g, Eric >; Zeng, Star > Subject: RE: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU = driver Hi I take a look at the driver. I think the update is good. Would you please share what test you have done with the updated UEFI memory= map? Such as UEFI Windows boot, UEFI Linux boot? Thank you Yao Jiewen > -----Original Message----- > From: Wang, Jian J > Sent: Wednesday, September 20, 2017 1:12 PM > To: Wang, Jian J >; e= dk2-devel@lists.01.org > Cc: Kinney, Michael D >; Laszlo Ersek > >; Yao, Jiewen >; Dong, Eric > >; Zeng, Star > > Subject: RE: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CP= U > driver > > Jiewen, > > Any comments on this patch? > > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= an J > Wang > Sent: Tuesday, September 19, 2017 2:10 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D >; Laszlo Ersek > >; Yao, Jiewen >; Dong, Eric > >; Zeng, Star > > Subject: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU dr= iver > > There're two issues here actually. > > From GCD perspective, its SetMemorySpaceAttributes() method doesn't > accept page related attributes. That means users cannot use it to > change page attributes, and have to turn to CPU arch protocol to do it, > which is not be allowed by PI spec. > > From CpuDxe driver perspective, it doesn't update GCD memory attributes > from current page table setup during its initialization. So the memory > attributes in GCD might not reflect all memory attributes in real world. > > Cc: Jiewen Yao > > Cc: Eric Dong > > Cc: Star Zeng > > Cc: Laszlo Ersek > > Cc: Michael Kinney > > Suggested-by: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > > > Jian J Wang (2): > UefiCpuPkg/CpuDxe: Fix out-of-sync issue in CpuDxe > MdeModulePkg/Core: Fix out-of-sync issue in GCD > > MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 45 ++++++++++-------- > UefiCpuPkg/CpuDxe/CpuDxe.c | 5 ++ > UefiCpuPkg/CpuDxe/CpuDxe.h | 9 ++++ > UefiCpuPkg/CpuDxe/CpuPageTable.c | 99 > ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 140 insertions(+), 18 deletions(-) > > -- > 2.14.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel