public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in GenCfgOpt.py
Date: Thu, 21 Sep 2017 07:55:21 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A9C031C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170921075105.3536-1-chasel.chiu@intel.com>

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Chiu, Chasel
> Sent: Thursday, September 21, 2017 3:51 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Maurice; Ma, Maurice
> <maurice.ma@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in
> GenCfgOpt.py
> 
> Platform is eligible to use either PcdsFeatureFlag or
> PcdsFixedAtBuild for build configuration and requires
> GenCfgOpt.py support.
> 
> Cc: Jiewen Yao <Jiewen.yao@intel.com>
> Cc: Maurice, Ma <maurice.ma@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> index 6dc1b10b34..64e0a3a985 100644
> --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> @@ -457,7 +457,7 @@ EndList
>                  IsUpdSect = False
>                  if  Match.group(1).lower() == "Defines".lower():
>                      IsDefSect = True
> -                if  Match.group(1).lower() == "PcdsFeatureFlag".lower():
> +                if  (Match.group(1).lower() == "PcdsFeatureFlag".lower() or
> Match.group(1).lower() == "PcdsFixedAtBuild".lower()):
>                      IsPcdSect = True
>                  elif Match.group(1).lower() ==
> "PcdsDynamicVpd.Upd".lower():
>                      ConfigDict = {}
> --
> 2.13.3.windows.1



      reply	other threads:[~2017-09-21  7:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21  7:51 [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in GenCfgOpt.py Chasel, Chiu
2017-09-21  7:55 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A9C031C@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox