Re: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle reserved or unimplemented PP Operation

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, September 27, 2017 3:57 PM
> To: Zhang, Chao B <chao.b.zhang@intel.com>; edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle
> reserved or unimplemented PP Operation
> 
> Reviewed-by: Star Zeng <star.zeng@intel.com>
> 
> -----Original Message-----
> From: Zhang, Chao B
> Sent: Friday, September 22, 2017 2:54 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle reserved or
> unimplemented PP Operation
> 
> Several PP operations < 128(Vendor Specific) are reserved or unimplemented.
> Follow TCG PC Client Platform Physical Presence Interface Specification to return
> not implemented.
> https://trustedcomputinggroup.org/wp-content/uploads/Physical-Presence-Int
> erface_1-30_0-52.pdf
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
>  .../SmmTcg2PhysicalPresenceLib.c                           | 14
> +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLi
> b.c
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLi
> b.c
> index ba4db11..6061453 100644
> ---
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLi
> b.c
> +++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPres
> +++ enceLib.c
> @@ -10,7 +10,7 @@
>    Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction() and
> Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction()
>    will receive untrusted input and do validation.
> 
> -Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials  are licensed and made available
> under the terms and conditions of the BSD License  which accompanies this
> distribution.  The full text of the license may be found at @@ -291,6 +291,7 @@
> Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
>        }
>        break;
> 
> +    case TCG2_PHYSICAL_PRESENCE_NO_ACTION:
>      case TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_CLEAR_TRUE:
>        RequestConfirmed = TRUE;
>        break;
> @@ -336,12 +337,11 @@
> Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
>        break;
> 
>      default:
> -      if (OperationRequest <= TCG2_PHYSICAL_PRESENCE_NO_ACTION_MAX)
> {
> -        RequestConfirmed = TRUE;
> -      } else {
> -        if (OperationRequest <
> TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {
> -          return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED;
> -        }
> +      if (OperationRequest <
> TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {
> +        //
> +        // TCG PP spec defined operations that are reserved or
> un-implemented
> +        //
> +        return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED;
>        }
>        break;
>    }
> --
> 1.9.5.msysgit.1