From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5B7D421F322CB for ; Wed, 27 Sep 2017 01:05:31 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2017 01:08:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,444,1500966000"; d="scan'208";a="156529863" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 27 Sep 2017 00:58:41 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 00:58:41 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Wed, 27 Sep 2017 15:58:39 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , "Zhang, Chao B" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle reserved or unimplemented PP Operation Thread-Index: AQHTN2YrXO8COKYeQEKZH3qdA+7FsKLIXgLg Date: Wed, 27 Sep 2017 07:58:39 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A9C587C@shsmsx102.ccr.corp.intel.com> References: <20170922065343.12660-1-chao.b.zhang@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B97B8DA@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B97B8DA@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle reserved or unimplemented PP Operation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2017 08:05:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, September 27, 2017 3:57 PM > To: Zhang, Chao B ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star > Subject: RE: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle > reserved or unimplemented PP Operation >=20 > Reviewed-by: Star Zeng >=20 > -----Original Message----- > From: Zhang, Chao B > Sent: Friday, September 22, 2017 2:54 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star ; > Zhang, Chao B > Subject: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle reserved= or > unimplemented PP Operation >=20 > Several PP operations < 128(Vendor Specific) are reserved or unimplemente= d. > Follow TCG PC Client Platform Physical Presence Interface Specification t= o return > not implemented. > https://trustedcomputinggroup.org/wp-content/uploads/Physical-Presence-In= t > erface_1-30_0-52.pdf >=20 > Cc: Jiewen Yao > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chao Zhang > --- > .../SmmTcg2PhysicalPresenceLib.c | 14 > +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git > a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceL= i > b.c > b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceL= i > b.c > index ba4db11..6061453 100644 > --- > a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceL= i > b.c > +++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPres > +++ enceLib.c > @@ -10,7 +10,7 @@ > Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction() and > Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction() > will receive untrusted input and do validation. >=20 > -Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made avail= able > under the terms and conditions of the BSD License which accompanies this > distribution. The full text of the license may be found at @@ -291,6 +29= 1,7 @@ > Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction ( > } > break; >=20 > + case TCG2_PHYSICAL_PRESENCE_NO_ACTION: > case TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_CLEAR_TRUE: > RequestConfirmed =3D TRUE; > break; > @@ -336,12 +337,11 @@ > Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction ( > break; >=20 > default: > - if (OperationRequest <=3D TCG2_PHYSICAL_PRESENCE_NO_ACTION_MAX) > { > - RequestConfirmed =3D TRUE; > - } else { > - if (OperationRequest < > TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) { > - return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED; > - } > + if (OperationRequest < > TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) { > + // > + // TCG PP spec defined operations that are reserved or > un-implemented > + // > + return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED; > } > break; > } > -- > 1.9.5.msysgit.1