public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Song, BinX" <binx.song@intel.com>,
	 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
Date: Tue, 7 Nov 2017 05:59:46 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA12A36@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AA129D3@shsmsx102.ccr.corp.intel.com>

Sorry, let me clarify, if we believe C4255 can help catch more problem, and we fixed all problem, why not enable it in BaseTool directly.



> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,
> Jiewen
> Sent: Tuesday, November 7, 2017 1:44 PM
> To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> warning
> 
> Yes, I suggest we fix it.
> 
> > -----Original Message-----
> > From: Song, BinX
> > Sent: Tuesday, November 7, 2017 1:43 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
> > Cc: Gao, Liming <liming.gao@intel.com>
> > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
> >
> > Hi Jiewen,
> >
> > Do you mean we fix the problem after enable MSFT C4255 warning?
> > If yes, I have fix them in related patch, such as MdeModulePkg.
> >
> > Best Regards,
> > Bell Song
> >
> >
> > > -----Original Message-----
> > > From: Yao, Jiewen
> > > Sent: Tuesday, November 7, 2017 1:39 PM
> > > To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> > > Cc: Gao, Liming <liming.gao@intel.com>
> > > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> > > warning
> > >
> > > Hi
> > > I suggest we fix the problem.
> > >
> > > > -----Original Message-----
> > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > > Song,
> > > > BinX
> > > > Sent: Tuesday, November 7, 2017 1:35 PM
> > > > To: edk2-devel@lists.01.org
> > > > Cc: Gao, Liming <liming.gao@intel.com>
> > > > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> > > warning
> > > >
> > > > Enable MSFT C4255 warning
> > > >
> > > > From MSDN:
> > > > Compiler Warning (level 4) C4255
> > > > function' : no function prototype given: converting '()' to '(void)'
> > > > The compiler did not find an explicit list of arguments to a function.
> > > > This warning is for the C compiler only.
> > > >
> > > > Cc: Liming Gao <liming.gao@intel.com>
> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > Signed-off-by: Bell Song <binx.song@intel.com>
> > > > ---
> > > >  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > > index 6496dad..4b4d5b2 100644
> > > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > > @@ -95,3 +95,4 @@
> > > >
> > > >  [BuildOptions]
> > > >    *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> > > > +  MSFT:*_*_*_CC_FLAGS = /we4255
> > > > --
> > > > 2.10.2.windows.1
> > > >
> > > > _______________________________________________
> > > > edk2-devel mailing list
> > > > edk2-devel@lists.01.org
> > > > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-11-07  5:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07  5:34 [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning Song, BinX
2017-11-07  5:38 ` Yao, Jiewen
2017-11-07  5:43   ` Song, BinX
2017-11-07  5:44     ` Yao, Jiewen
2017-11-07  5:59       ` Yao, Jiewen [this message]
2017-11-07  7:57         ` Gao, Liming
2017-11-07  8:06           ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AA12A36@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox