* [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
@ 2017-11-07 5:34 Song, BinX
2017-11-07 5:38 ` Yao, Jiewen
0 siblings, 1 reply; 7+ messages in thread
From: Song, BinX @ 2017-11-07 5:34 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: Gao, Liming
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song <binx.song@intel.com>
---
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
index 6496dad..4b4d5b2 100644
--- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
+++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
@@ -95,3 +95,4 @@
[BuildOptions]
*_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
+ MSFT:*_*_*_CC_FLAGS = /we4255
--
2.10.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
2017-11-07 5:34 [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning Song, BinX
@ 2017-11-07 5:38 ` Yao, Jiewen
2017-11-07 5:43 ` Song, BinX
0 siblings, 1 reply; 7+ messages in thread
From: Yao, Jiewen @ 2017-11-07 5:38 UTC (permalink / raw)
To: Song, BinX, edk2-devel@lists.01.org; +Cc: Gao, Liming
Hi
I suggest we fix the problem.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Song,
> BinX
> Sent: Tuesday, November 7, 2017 1:35 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
>
> Enable MSFT C4255 warning
>
> From MSDN:
> Compiler Warning (level 4) C4255
> function' : no function prototype given: converting '()' to '(void)'
> The compiler did not find an explicit list of arguments to a function.
> This warning is for the C compiler only.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> index 6496dad..4b4d5b2 100644
> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> @@ -95,3 +95,4 @@
>
> [BuildOptions]
> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> + MSFT:*_*_*_CC_FLAGS = /we4255
> --
> 2.10.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
2017-11-07 5:38 ` Yao, Jiewen
@ 2017-11-07 5:43 ` Song, BinX
2017-11-07 5:44 ` Yao, Jiewen
0 siblings, 1 reply; 7+ messages in thread
From: Song, BinX @ 2017-11-07 5:43 UTC (permalink / raw)
To: Yao, Jiewen, edk2-devel@lists.01.org; +Cc: Gao, Liming
Hi Jiewen,
Do you mean we fix the problem after enable MSFT C4255 warning?
If yes, I have fix them in related patch, such as MdeModulePkg.
Best Regards,
Bell Song
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, November 7, 2017 1:39 PM
> To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> warning
>
> Hi
> I suggest we fix the problem.
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Song,
> > BinX
> > Sent: Tuesday, November 7, 2017 1:35 PM
> > To: edk2-devel@lists.01.org
> > Cc: Gao, Liming <liming.gao@intel.com>
> > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> warning
> >
> > Enable MSFT C4255 warning
> >
> > From MSDN:
> > Compiler Warning (level 4) C4255
> > function' : no function prototype given: converting '()' to '(void)'
> > The compiler did not find an explicit list of arguments to a function.
> > This warning is for the C compiler only.
> >
> > Cc: Liming Gao <liming.gao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Bell Song <binx.song@intel.com>
> > ---
> > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > index 6496dad..4b4d5b2 100644
> > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > @@ -95,3 +95,4 @@
> >
> > [BuildOptions]
> > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> > + MSFT:*_*_*_CC_FLAGS = /we4255
> > --
> > 2.10.2.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
2017-11-07 5:43 ` Song, BinX
@ 2017-11-07 5:44 ` Yao, Jiewen
2017-11-07 5:59 ` Yao, Jiewen
0 siblings, 1 reply; 7+ messages in thread
From: Yao, Jiewen @ 2017-11-07 5:44 UTC (permalink / raw)
To: Song, BinX, edk2-devel@lists.01.org; +Cc: Gao, Liming
Yes, I suggest we fix it.
> -----Original Message-----
> From: Song, BinX
> Sent: Tuesday, November 7, 2017 1:43 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
>
> Hi Jiewen,
>
> Do you mean we fix the problem after enable MSFT C4255 warning?
> If yes, I have fix them in related patch, such as MdeModulePkg.
>
> Best Regards,
> Bell Song
>
>
> > -----Original Message-----
> > From: Yao, Jiewen
> > Sent: Tuesday, November 7, 2017 1:39 PM
> > To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> > Cc: Gao, Liming <liming.gao@intel.com>
> > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> > warning
> >
> > Hi
> > I suggest we fix the problem.
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Song,
> > > BinX
> > > Sent: Tuesday, November 7, 2017 1:35 PM
> > > To: edk2-devel@lists.01.org
> > > Cc: Gao, Liming <liming.gao@intel.com>
> > > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> > warning
> > >
> > > Enable MSFT C4255 warning
> > >
> > > From MSDN:
> > > Compiler Warning (level 4) C4255
> > > function' : no function prototype given: converting '()' to '(void)'
> > > The compiler did not find an explicit list of arguments to a function.
> > > This warning is for the C compiler only.
> > >
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Bell Song <binx.song@intel.com>
> > > ---
> > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > index 6496dad..4b4d5b2 100644
> > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > @@ -95,3 +95,4 @@
> > >
> > > [BuildOptions]
> > > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> > > + MSFT:*_*_*_CC_FLAGS = /we4255
> > > --
> > > 2.10.2.windows.1
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
2017-11-07 5:44 ` Yao, Jiewen
@ 2017-11-07 5:59 ` Yao, Jiewen
2017-11-07 7:57 ` Gao, Liming
0 siblings, 1 reply; 7+ messages in thread
From: Yao, Jiewen @ 2017-11-07 5:59 UTC (permalink / raw)
To: Yao, Jiewen, Song, BinX, edk2-devel@lists.01.org; +Cc: Gao, Liming
Sorry, let me clarify, if we believe C4255 can help catch more problem, and we fixed all problem, why not enable it in BaseTool directly.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,
> Jiewen
> Sent: Tuesday, November 7, 2017 1:44 PM
> To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> warning
>
> Yes, I suggest we fix it.
>
> > -----Original Message-----
> > From: Song, BinX
> > Sent: Tuesday, November 7, 2017 1:43 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
> > Cc: Gao, Liming <liming.gao@intel.com>
> > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
> >
> > Hi Jiewen,
> >
> > Do you mean we fix the problem after enable MSFT C4255 warning?
> > If yes, I have fix them in related patch, such as MdeModulePkg.
> >
> > Best Regards,
> > Bell Song
> >
> >
> > > -----Original Message-----
> > > From: Yao, Jiewen
> > > Sent: Tuesday, November 7, 2017 1:39 PM
> > > To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> > > Cc: Gao, Liming <liming.gao@intel.com>
> > > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> > > warning
> > >
> > > Hi
> > > I suggest we fix the problem.
> > >
> > > > -----Original Message-----
> > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > > Song,
> > > > BinX
> > > > Sent: Tuesday, November 7, 2017 1:35 PM
> > > > To: edk2-devel@lists.01.org
> > > > Cc: Gao, Liming <liming.gao@intel.com>
> > > > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> > > warning
> > > >
> > > > Enable MSFT C4255 warning
> > > >
> > > > From MSDN:
> > > > Compiler Warning (level 4) C4255
> > > > function' : no function prototype given: converting '()' to '(void)'
> > > > The compiler did not find an explicit list of arguments to a function.
> > > > This warning is for the C compiler only.
> > > >
> > > > Cc: Liming Gao <liming.gao@intel.com>
> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > Signed-off-by: Bell Song <binx.song@intel.com>
> > > > ---
> > > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > > index 6496dad..4b4d5b2 100644
> > > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > > @@ -95,3 +95,4 @@
> > > >
> > > > [BuildOptions]
> > > > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> > > > + MSFT:*_*_*_CC_FLAGS = /we4255
> > > > --
> > > > 2.10.2.windows.1
> > > >
> > > > _______________________________________________
> > > > edk2-devel mailing list
> > > > edk2-devel@lists.01.org
> > > > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
2017-11-07 5:59 ` Yao, Jiewen
@ 2017-11-07 7:57 ` Gao, Liming
2017-11-07 8:06 ` Yao, Jiewen
0 siblings, 1 reply; 7+ messages in thread
From: Gao, Liming @ 2017-11-07 7:57 UTC (permalink / raw)
To: Yao, Jiewen, Song, BinX, edk2-devel@lists.01.org
Jiewen:
We plan to enable this option in new VS tool chain VS2017. So, we can keep DSC without the change, and enable this option after VS2017 tool chain is added.
Thanks
Liming
>-----Original Message-----
>From: Yao, Jiewen
>Sent: Tuesday, November 07, 2017 2:00 PM
>To: Yao, Jiewen <jiewen.yao@intel.com>; Song, BinX <binx.song@intel.com>;
>edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
>
>Sorry, let me clarify, if we believe C4255 can help catch more problem, and we
>fixed all problem, why not enable it in BaseTool directly.
>
>
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yao,
>> Jiewen
>> Sent: Tuesday, November 7, 2017 1:44 PM
>> To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
>> Cc: Gao, Liming <liming.gao@intel.com>
>> Subject: Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT
>C4255
>> warning
>>
>> Yes, I suggest we fix it.
>>
>> > -----Original Message-----
>> > From: Song, BinX
>> > Sent: Tuesday, November 7, 2017 1:43 PM
>> > To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
>> > Cc: Gao, Liming <liming.gao@intel.com>
>> > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
>warning
>> >
>> > Hi Jiewen,
>> >
>> > Do you mean we fix the problem after enable MSFT C4255 warning?
>> > If yes, I have fix them in related patch, such as MdeModulePkg.
>> >
>> > Best Regards,
>> > Bell Song
>> >
>> >
>> > > -----Original Message-----
>> > > From: Yao, Jiewen
>> > > Sent: Tuesday, November 7, 2017 1:39 PM
>> > > To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
>> > > Cc: Gao, Liming <liming.gao@intel.com>
>> > > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
>> > > warning
>> > >
>> > > Hi
>> > > I suggest we fix the problem.
>> > >
>> > > > -----Original Message-----
>> > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
>Of
>> > > Song,
>> > > > BinX
>> > > > Sent: Tuesday, November 7, 2017 1:35 PM
>> > > > To: edk2-devel@lists.01.org
>> > > > Cc: Gao, Liming <liming.gao@intel.com>
>> > > > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT
>C4255
>> > > warning
>> > > >
>> > > > Enable MSFT C4255 warning
>> > > >
>> > > > From MSDN:
>> > > > Compiler Warning (level 4) C4255
>> > > > function' : no function prototype given: converting '()' to '(void)'
>> > > > The compiler did not find an explicit list of arguments to a function.
>> > > > This warning is for the C compiler only.
>> > > >
>> > > > Cc: Liming Gao <liming.gao@intel.com>
>> > > > Contributed-under: TianoCore Contribution Agreement 1.1
>> > > > Signed-off-by: Bell Song <binx.song@intel.com>
>> > > > ---
>> > > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
>> > > > 1 file changed, 1 insertion(+)
>> > > >
>> > > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
>> > > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
>> > > > index 6496dad..4b4d5b2 100644
>> > > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
>> > > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
>> > > > @@ -95,3 +95,4 @@
>> > > >
>> > > > [BuildOptions]
>> > > > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
>> > > > + MSFT:*_*_*_CC_FLAGS = /we4255
>> > > > --
>> > > > 2.10.2.windows.1
>> > > >
>> > > > _______________________________________________
>> > > > edk2-devel mailing list
>> > > > edk2-devel@lists.01.org
>> > > > https://lists.01.org/mailman/listinfo/edk2-devel
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
2017-11-07 7:57 ` Gao, Liming
@ 2017-11-07 8:06 ` Yao, Jiewen
0 siblings, 0 replies; 7+ messages in thread
From: Yao, Jiewen @ 2017-11-07 8:06 UTC (permalink / raw)
To: Gao, Liming, Song, BinX, edk2-devel@lists.01.org
Got it. That is better. Agree.
I think we can check in the real C code update at first.
Thank you
Yao Jiewen
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, November 7, 2017 3:58 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; Song, BinX <binx.song@intel.com>;
> edk2-devel@lists.01.org
> Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
>
> Jiewen:
> We plan to enable this option in new VS tool chain VS2017. So, we can keep
> DSC without the change, and enable this option after VS2017 tool chain is added.
>
> Thanks
> Liming
> >-----Original Message-----
> >From: Yao, Jiewen
> >Sent: Tuesday, November 07, 2017 2:00 PM
> >To: Yao, Jiewen <jiewen.yao@intel.com>; Song, BinX <binx.song@intel.com>;
> >edk2-devel@lists.01.org
> >Cc: Gao, Liming <liming.gao@intel.com>
> >Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning
> >
> >Sorry, let me clarify, if we believe C4255 can help catch more problem, and we
> >fixed all problem, why not enable it in BaseTool directly.
> >
> >
> >
> >> -----Original Message-----
> >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> >Yao,
> >> Jiewen
> >> Sent: Tuesday, November 7, 2017 1:44 PM
> >> To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> >> Cc: Gao, Liming <liming.gao@intel.com>
> >> Subject: Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT
> >C4255
> >> warning
> >>
> >> Yes, I suggest we fix it.
> >>
> >> > -----Original Message-----
> >> > From: Song, BinX
> >> > Sent: Tuesday, November 7, 2017 1:43 PM
> >> > To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
> >> > Cc: Gao, Liming <liming.gao@intel.com>
> >> > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> >warning
> >> >
> >> > Hi Jiewen,
> >> >
> >> > Do you mean we fix the problem after enable MSFT C4255 warning?
> >> > If yes, I have fix them in related patch, such as MdeModulePkg.
> >> >
> >> > Best Regards,
> >> > Bell Song
> >> >
> >> >
> >> > > -----Original Message-----
> >> > > From: Yao, Jiewen
> >> > > Sent: Tuesday, November 7, 2017 1:39 PM
> >> > > To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> >> > > Cc: Gao, Liming <liming.gao@intel.com>
> >> > > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255
> >> > > warning
> >> > >
> >> > > Hi
> >> > > I suggest we fix the problem.
> >> > >
> >> > > > -----Original Message-----
> >> > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> >Of
> >> > > Song,
> >> > > > BinX
> >> > > > Sent: Tuesday, November 7, 2017 1:35 PM
> >> > > > To: edk2-devel@lists.01.org
> >> > > > Cc: Gao, Liming <liming.gao@intel.com>
> >> > > > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT
> >C4255
> >> > > warning
> >> > > >
> >> > > > Enable MSFT C4255 warning
> >> > > >
> >> > > > From MSDN:
> >> > > > Compiler Warning (level 4) C4255
> >> > > > function' : no function prototype given: converting '()' to '(void)'
> >> > > > The compiler did not find an explicit list of arguments to a function.
> >> > > > This warning is for the C compiler only.
> >> > > >
> >> > > > Cc: Liming Gao <liming.gao@intel.com>
> >> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> >> > > > Signed-off-by: Bell Song <binx.song@intel.com>
> >> > > > ---
> >> > > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
> >> > > > 1 file changed, 1 insertion(+)
> >> > > >
> >> > > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> >> > > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> >> > > > index 6496dad..4b4d5b2 100644
> >> > > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> >> > > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> >> > > > @@ -95,3 +95,4 @@
> >> > > >
> >> > > > [BuildOptions]
> >> > > > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> >> > > > + MSFT:*_*_*_CC_FLAGS = /we4255
> >> > > > --
> >> > > > 2.10.2.windows.1
> >> > > >
> >> > > > _______________________________________________
> >> > > > edk2-devel mailing list
> >> > > > edk2-devel@lists.01.org
> >> > > > https://lists.01.org/mailman/listinfo/edk2-devel
> >> _______________________________________________
> >> edk2-devel mailing list
> >> edk2-devel@lists.01.org
> >> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-07 8:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-07 5:34 [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning Song, BinX
2017-11-07 5:38 ` Yao, Jiewen
2017-11-07 5:43 ` Song, BinX
2017-11-07 5:44 ` Yao, Jiewen
2017-11-07 5:59 ` Yao, Jiewen
2017-11-07 7:57 ` Gao, Liming
2017-11-07 8:06 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox