From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BBD252034D812 for ; Tue, 7 Nov 2017 00:02:35 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2017 00:06:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,357,1505804400"; d="scan'208";a="1240710261" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 07 Nov 2017 00:06:33 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Nov 2017 00:06:33 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Nov 2017 00:06:33 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Tue, 7 Nov 2017 16:06:30 +0800 From: "Yao, Jiewen" To: "Gao, Liming" , "Song, BinX" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning Thread-Index: AdNXiiC05LEXwRtuTPKvO902HothWgAAIQPAAAAbz3AAABHbcAAAflVQAAPAqJAAAKc1gA== Date: Tue, 7 Nov 2017 08:06:30 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA12D77@shsmsx102.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF1025BBD42@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA1299B@shsmsx102.ccr.corp.intel.com> <559D2DF22BC9A3468B4FA1AA547F0EF1025BBE33@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA129D3@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA12A36@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1795A8@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1795A8@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjg5Nzc3NTYtYzAzMi00YWM0LWFlNTEtNjQ4YmJjMjc4ZDQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ2U09IaEFHOGh5N0plZHJCT2pXZkpUREh1QTBBeERsV25XeGtBK3NMMEU5dHNFRUtzSVFSdFZOQkwrYWhIbXpEIn0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 08:02:35 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Got it. That is better. Agree. I think we can check in the real C code update at first. Thank you Yao Jiewen > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, November 7, 2017 3:58 PM > To: Yao, Jiewen ; Song, BinX ; > edk2-devel@lists.01.org > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning >=20 > Jiewen: > We plan to enable this option in new VS tool chain VS2017. So, we can k= eep > DSC without the change, and enable this option after VS2017 tool chain is= added. >=20 > Thanks > Liming > >-----Original Message----- > >From: Yao, Jiewen > >Sent: Tuesday, November 07, 2017 2:00 PM > >To: Yao, Jiewen ; Song, BinX = ; > >edk2-devel@lists.01.org > >Cc: Gao, Liming > >Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warnin= g > > > >Sorry, let me clarify, if we believe C4255 can help catch more problem, = and we > >fixed all problem, why not enable it in BaseTool directly. > > > > > > > >> -----Original Message----- > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >Yao, > >> Jiewen > >> Sent: Tuesday, November 7, 2017 1:44 PM > >> To: Song, BinX ; edk2-devel@lists.01.org > >> Cc: Gao, Liming > >> Subject: Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT > >C4255 > >> warning > >> > >> Yes, I suggest we fix it. > >> > >> > -----Original Message----- > >> > From: Song, BinX > >> > Sent: Tuesday, November 7, 2017 1:43 PM > >> > To: Yao, Jiewen ; edk2-devel@lists.01.org > >> > Cc: Gao, Liming > >> > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 > >warning > >> > > >> > Hi Jiewen, > >> > > >> > Do you mean we fix the problem after enable MSFT C4255 warning? > >> > If yes, I have fix them in related patch, such as MdeModulePkg. > >> > > >> > Best Regards, > >> > Bell Song > >> > > >> > > >> > > -----Original Message----- > >> > > From: Yao, Jiewen > >> > > Sent: Tuesday, November 7, 2017 1:39 PM > >> > > To: Song, BinX ; edk2-devel@lists.01.org > >> > > Cc: Gao, Liming > >> > > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 > >> > > warning > >> > > > >> > > Hi > >> > > I suggest we fix the problem. > >> > > > >> > > > -----Original Message----- > >> > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Beh= alf > >Of > >> > > Song, > >> > > > BinX > >> > > > Sent: Tuesday, November 7, 2017 1:35 PM > >> > > > To: edk2-devel@lists.01.org > >> > > > Cc: Gao, Liming > >> > > > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT > >C4255 > >> > > warning > >> > > > > >> > > > Enable MSFT C4255 warning > >> > > > > >> > > > From MSDN: > >> > > > Compiler Warning (level 4) C4255 > >> > > > function' : no function prototype given: converting '()' to '(vo= id)' > >> > > > The compiler did not find an explicit list of arguments to a fun= ction. > >> > > > This warning is for the C compiler only. > >> > > > > >> > > > Cc: Liming Gao > >> > > > Contributed-under: TianoCore Contribution Agreement 1.1 > >> > > > Signed-off-by: Bell Song > >> > > > --- > >> > > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 + > >> > > > 1 file changed, 1 insertion(+) > >> > > > > >> > > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > >> > > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > >> > > > index 6496dad..4b4d5b2 100644 > >> > > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > >> > > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > >> > > > @@ -95,3 +95,4 @@ > >> > > > > >> > > > [BuildOptions] > >> > > > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES > >> > > > + MSFT:*_*_*_CC_FLAGS =3D /we4255 > >> > > > -- > >> > > > 2.10.2.windows.1 > >> > > > > >> > > > _______________________________________________ > >> > > > edk2-devel mailing list > >> > > > edk2-devel@lists.01.org > >> > > > https://lists.01.org/mailman/listinfo/edk2-devel > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel