public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg XhciPei: Minor refinement about IoMmu
Date: Fri, 17 Nov 2017 02:32:20 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA21059@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1510829112-93900-1-git-send-email-star.zeng@intel.com>

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Zeng, Star
> Sent: Thursday, November 16, 2017 6:45 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH] MdeModulePkg XhciPei: Minor refinement about IoMmu
> 
> 1. Call IoMmuInit() after locating gPeiUsbControllerPpiGuid.
> 2. Call XhcPeiFreeSched() to do cleanup in XhcEndOfPei.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
> b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
> index 99f69f730b3f..c5631e87cacc 100644
> --- a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
> +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
> @@ -1427,6 +1427,8 @@ XhcEndOfPei (
> 
>    XhcPeiHaltHC (Xhc, XHC_GENERIC_TIMEOUT);
> 
> +  XhcPeiFreeSched (Xhc);
> +
>    return EFI_SUCCESS;
>  }
> 
> @@ -1461,8 +1463,6 @@ XhcPeimEntry (
>      return EFI_SUCCESS;
>    }
> 
> -  IoMmuInit ();
> -
>    Status = PeiServicesLocatePpi (
>               &gPeiUsbControllerPpiGuid,
>               0,
> @@ -1473,6 +1473,8 @@ XhcPeimEntry (
>      return EFI_UNSUPPORTED;
>    }
> 
> +  IoMmuInit ();
> +
>    Index = 0;
>    while (TRUE) {
>      Status = UsbControllerPpi->GetUsbController (
> --
> 2.7.0.windows.1



      reply	other threads:[~2017-11-17  2:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 10:45 [PATCH] MdeModulePkg XhciPei: Minor refinement about IoMmu Star Zeng
2017-11-17  2:32 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AA21059@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox