From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg EhciPei: Minor refinement about IOMMU
Date: Wed, 22 Nov 2017 06:08:54 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA27BA5@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1511255028-10804-1-git-send-email-star.zeng@intel.com>
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, November 21, 2017 5:04 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH] MdeModulePkg EhciPei: Minor refinement about IOMMU
>
> This patch is following 2c656af04d7f.
> 1. Fix typo "XHC" to "EHC".
> 2. Reinitialize Request(Phy/Map) and Data(Phy/Map)
> in Urb, otherwise the last time value of them may
> be used in error handling when error happens.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h | 2 +-
> MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 13 ++++++-------
> 2 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h
> b/MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h
> index 279407475b66..715a5ab1c142 100644
> --- a/MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h
> +++ b/MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h
> @@ -99,7 +99,7 @@ struct _PEI_USB2_HC_DEV {
> EDKII_IOMMU_PPI *IoMmu;
> EFI_PEI_PPI_DESCRIPTOR PpiDescriptor;
> //
> - // EndOfPei callback is used to stop the XHC DMA operation
> + // EndOfPei callback is used to stop the EHC DMA operation
> // after exit PEI phase.
> //
> EFI_PEI_NOTIFY_DESCRIPTOR EndOfPeiNotifyList;
> diff --git a/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c
> b/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c
> index 3dadcd60b6fe..baacf5d56080 100644
> --- a/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c
> +++ b/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c
> @@ -576,7 +576,12 @@ EhcCreateUrb (
> if (Urb->Qh == NULL) {
> goto ON_ERROR;
> }
> -
> +
> + Urb->RequestPhy = NULL;
> + Urb->RequestMap = NULL;
> + Urb->DataPhy = NULL;
> + Urb->DataMap = NULL;
> +
> //
> // Map the request and user data
> //
> @@ -591,9 +596,6 @@ EhcCreateUrb (
>
> Urb->RequestPhy = (VOID *) ((UINTN) PhyAddr);
> Urb->RequestMap = Map;
> - } else {
> - Urb->RequestPhy = NULL;
> - Urb->RequestMap = NULL;
> }
>
> if (Data != NULL) {
> @@ -613,9 +615,6 @@ EhcCreateUrb (
>
> Urb->DataPhy = (VOID *) ((UINTN) PhyAddr);
> Urb->DataMap = Map;
> - } else {
> - Urb->DataPhy = NULL;
> - Urb->DataMap = NULL;
> }
>
> Status = EhcCreateQtds (Ehc, Urb);
> --
> 2.7.0.windows.1
prev parent reply other threads:[~2017-11-22 6:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 9:03 [PATCH] MdeModulePkg EhciPei: Minor refinement about IOMMU Star Zeng
2017-11-22 6:08 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AA27BA5@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox