From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E0B1721C913BB for ; Tue, 21 Nov 2017 23:53:31 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2017 23:57:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,436,1505804400"; d="scan'208";a="179207690" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 21 Nov 2017 23:57:47 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 21 Nov 2017 23:57:47 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 21 Nov 2017 23:57:46 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Wed, 22 Nov 2017 15:57:43 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , Laszlo Ersek , "Wang, Jian J" CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map Thread-Index: AQHTYpB0zfYyl1Vw1keu+UOh7QEXGqMeUL8AgAEy24CAAIZNEA== Date: Wed, 22 Nov 2017 07:57:43 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA27FB4@shsmsx102.ccr.corp.intel.com> References: <20171121061725.11028-1-jian.j.wang@intel.com> <2e083f9d-4009-dd3e-c845-108f0c1eb24a@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B9BA58E@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B9BA58E@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2UzY2QyMzQtYWIzNi00N2RkLWE3MWMtMDg0MGY0M2I4ZWEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJkMXRpcnJLOXBHRVpIS05JWkp0UHRlTWFMNGJyS1dyMWJcL3hsQlhhVzB5aFlTZG1hNGpkTko2UjU1WUdBNjRHTSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 07:53:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am OK on that. > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, November 22, 2017 3:57 PM > To: Laszlo Ersek ; Wang, Jian J > Cc: edk2-devel@lists.01.org; Yao, Jiewen ; Zeng, St= ar > > Subject: RE: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in mem= ory > map >=20 > How about we have the v6 patch series in first with the feedback from Jie= wen > (about comments) and you (about MemoryMapStart) addressed? >=20 > Then we can have a separated patch for the merging. >=20 >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo > Ersek > Sent: Tuesday, November 21, 2017 9:38 PM > To: Wang, Jian J > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in mem= ory > map >=20 > Jian, >=20 > On 11/21/17 07:17, Jian J Wang wrote: > >> v7: > >> Merge memory map after filtering paging attributes > > > > More than one entry of RT_CODE memory might cause boot problem for > > some old OSs. This patch will fix this issue to keep OS compatibility > > as much as possible. > > > > Jian J Wang (2): > > MdeModulePkg/DxeCore: Filter out all paging capabilities > > UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map > > > > MdeModulePkg/Core/Dxe/DxeMain.h | 18 ++++++ > > MdeModulePkg/Core/Dxe/Mem/Page.c | 21 +++++++ > > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1 - > > UefiCpuPkg/CpuDxe/CpuPageTable.c | 94 > +++++++++++++++++++++------- > > 4 files changed, 112 insertions(+), 22 deletions(-) > > >=20 > I don't have capacity to retest and re-review the series. >=20 > Considering the following two options, I like none of them: >=20 > (1) Version 7 is merged with my feedback tags from v6. I don't like this = because I > didn't review or test version 7. >=20 > (2) Version 7 is merged without my feedback tags. I don't like this becau= se I've > put a lot of BZ writeup, and patch review and testing effort for this ser= ies, and I'd > like the commit log to reflect that. >=20 >=20 > Instead, I would like to request the following, for v8: >=20 > Please submit a series that consists of three patches: >=20 > - patch v8 1/3: identical to v6 1/2, except for the code comment update, > - patch v8 2/3: identical to v6 2/2, > - patch v8 3/3: please implement the merging of the memory map as a separ= ate > patch. >=20 > Patches v8 1/3 and 2/3 should include *both* my Tested-by *and* my > Reviewed-by tags, from v6. >=20 > Patch v8 3/3 should be reviewed / tested separately by others. I don't th= ink I can > find the capacity for that at the moment. >=20 > This approach will correctly reflect all the work done thus far, and it w= ill provide > the desired result for the code as well. >=20 > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel