From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 819A321A1098A for ; Mon, 4 Dec 2017 18:27:28 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2017 18:31:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,362,1508828400"; d="scan'208";a="184052631" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 04 Dec 2017 18:31:58 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Dec 2017 18:31:58 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Dec 2017 18:31:58 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Tue, 5 Dec 2017 10:31:57 +0800 From: "Yao, Jiewen" To: "Wang, Jian J" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" Thread-Topic: [edk2] [PATCH v2 0/4] Enable page table write protection Thread-Index: AQHTbNr7CBx7wLF7Uk2bqlxUOIpiVKMzSUtw Date: Tue, 5 Dec 2017 02:31:56 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA39A87@shsmsx102.ccr.corp.intel.com> References: <20171204083556.19416-1-jian.j.wang@intel.com> In-Reply-To: <20171204083556.19416-1-jian.j.wang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWI3MThjZmQtMmU0MS00NGQ5LTlkNGUtNGYxMzRmMDRiZmYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ4K1N4K0NQNVF1dWx6ZmdzdG9YRVMxZmtiZUZZZmNkXC9uXC9SZmtaSEx4VFdkZTJNTU0rTEJydW9GWDFWdDNSUmwifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/4] Enable page table write protection X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 02:27:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jian In V1 review, I suggest to test in UEFI shell env to make sure all page tab= le is read only, with PageTable split in CPU driver. May I know if that is done? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= an J > Wang > Sent: Monday, December 4, 2017 4:36 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 0/4] Enable page table write protection >=20 > > v2 changes: > > a. Enable protection on any newly added page table after DxeIpl. > > b. Introduce page table pool concept to make page table allocation > > and protection easier and error free. >=20 > Write Protect feature (CR0.WP) is always enabled in driver UefiCpuPkg/Cpu= Dxe. > But the memory pages used for page table are not set as read-only in the = driver > DxeIplPeim, after the paging is setup. This might jeopardize the page tab= le > integrity if there's buffer overflow occured in other part of system. >=20 > This patch series will change this situation by clearing R/W bit in page = attribute > of the pages used as page table. >=20 > Validation works include booting Windows (10/server 2016) and Linux > (Fedora/Ubuntu) > on OVMF and Intel real platform. >=20 > Jian J Wang (4): > MdeModulePkg/MdeModulePkg.dec: Add new PCDs and Guid > MdeModulePkg/PageTablePool.h: Page table pool GUID definition file > MdeModulePkg/DxeIpl: Mark page table as read-only > UefiCpuPkg/CpuDxe: Enable protection for newly added page table >=20 > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 34 +++ > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 3 + > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 8 +- > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 315 > +++++++++++++++++++++- > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h | 15 ++ > MdeModulePkg/Include/Guid/PageTablePool.h | 53 ++++ > MdeModulePkg/MdeModulePkg.dec | 28 ++ > UefiCpuPkg/CpuDxe/CpuDxe.c | 17 +- > UefiCpuPkg/CpuDxe/CpuDxe.h | 2 + > UefiCpuPkg/CpuDxe/CpuDxe.inf | 3 + > UefiCpuPkg/CpuDxe/CpuPageTable.c | 329 > ++++++++++++++++++++++- > UefiCpuPkg/CpuDxe/CpuPageTable.h | 22 ++ > 12 files changed, 816 insertions(+), 13 deletions(-) > create mode 100644 MdeModulePkg/Include/Guid/PageTablePool.h >=20 > -- > 2.14.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel