From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6743D2218E923 for ; Wed, 6 Dec 2017 18:47:19 -0800 (PST) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 18:51:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,370,1508828400"; d="scan'208";a="738972" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 06 Dec 2017 18:51:51 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 18:51:51 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 18:51:50 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Thu, 7 Dec 2017 10:51:49 +0800 From: "Yao, Jiewen" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX in nasm code Thread-Index: AQHTbwVuQVD9zgrOC0yA56EDb4vt36M3LmTQ Date: Thu, 7 Dec 2017 02:51:49 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA3C710@shsmsx102.ccr.corp.intel.com> References: <1512614710-9956-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1512614710-9956-1-git-send-email-liming.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTcyZTBkYmItZjhkMy00N2I1LWE2ODktY2M4NmUwYWQwZjdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJyNFBSN1pKMHcrcVZcL1JiM045NFlqdFIrT25jUGJCMk9CUExrUHAzVFNVQm1IcUhRTkdYWW1MTmJjdTVtWkNheSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX in nasm code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 02:47:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming Reviewed-by: Jiewen.yao@intel.com BTW: Do you think we also need update SmmCpuFeaturesLib ? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Li= ming > Gao > Sent: Thursday, December 7, 2017 10:45 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing > ASM_PFX in nasm code >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Eric Dong > --- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > index c3c094f..dc56dc7 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > @@ -1,5 +1,5 @@ > ;-----------------------------------------------------------------------= ------- ; > -; Copyright (c) 2016, Intel Corporation. All rights reserved.
> +; Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
> ; This program and the accompanying materials > ; are licensed and made available under the terms and conditions of the = BSD > License > ; which accompanies this distribution. The full text of the license may= be found > at > @@ -184,15 +184,15 @@ _SmiHandler: > add rsp, -0x20 >=20 > mov rcx, rbx > - mov rax, CpuSmmDebugEntry > + mov rax, ASM_PFX(CpuSmmDebugEntry) > call rax >=20 > mov rcx, rbx > - mov rax, SmiRendezvous ; rax <- absolute addr of > SmiRedezvous > + mov rax, ASM_PFX(SmiRendezvous) ; rax <- absolute addr of > SmiRedezvous > call rax >=20 > mov rcx, rbx > - mov rax, CpuSmmDebugExit > + mov rax, ASM_PFX(CpuSmmDebugExit) > call rax >=20 > add rsp, 0x20 > @@ -220,5 +220,5 @@ _SmiHandler: > .1: > rsm >=20 > -gcSmiHandlerSize DW $ - _SmiEntryPoint > +ASM_PFX(gcSmiHandlerSize) DW $ - _SmiEntryPoint >=20 > -- > 2.8.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel