From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7ED8B2218E921 for ; Wed, 6 Dec 2017 20:08:47 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 20:13:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,371,1508828400"; d="scan'208";a="10274485" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 06 Dec 2017 20:13:19 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 20:13:19 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 20:10:31 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 7 Dec 2017 12:10:29 +0800 From: "Yao, Jiewen" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX in nasm code Thread-Index: AQHTbwVuQVD9zgrOC0yA56EDb4vt36M3LmTQ//96jICAAIfYUP//hlCAgACNIWA= Date: Thu, 7 Dec 2017 04:10:29 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA3C9B6@shsmsx102.ccr.corp.intel.com> References: <1512614710-9956-1-git-send-email-liming.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA3C710@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E18BA1A@SHSMSX104.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA3C796@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E18BAB3@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E18BAB3@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzI4YjkyYjYtNzVhNC00NGNkLTk3NjctMTA0NThlMGZmYjNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJnR1wvNWcxUnRoaFRON3pENld5WG1QQzhTS2hWbXU0WUYxeTc3VkY3V3N2NUZ4YUZaZW55eDFmN3JnZFFQaXZ4TCJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX in nasm code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 04:08:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, build pass is enough. Agree. Please make sure all NASM related modules are built and linked. :-) Thank you Yao Jiewen > -----Original Message----- > From: Gao, Liming > Sent: Thursday, December 7, 2017 11:44 AM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: RE: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing > ASM_PFX in nasm code >=20 > XCODE5 tool chain reports them. For this change, I think build pass is e= nough. >=20 > I send another patch to fix the missing ASM_PFX in SmmCpuFeaturesLib. >=20 > Thanks > Liming > >-----Original Message----- > >From: Yao, Jiewen > >Sent: Thursday, December 07, 2017 11:00 AM > >To: Gao, Liming ; edk2-devel@lists.01.org > >Cc: Dong, Eric > >Subject: RE: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing > >ASM_PFX in nasm code > > > >I think so. > > > >May I know how this is found? And how this is validated? > > > >I think we need build the whole package to trigger all the failure, and = fix all. > > > >Thank you > >Yao Jiewen > > > > > >> -----Original Message----- > >> From: Gao, Liming > >> Sent: Thursday, December 7, 2017 10:53 AM > >> To: Yao, Jiewen ; edk2-devel@lists.01.org > >> Cc: Dong, Eric > >> Subject: RE: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing > >> ASM_PFX in nasm code > >> > >> Do you mean SmmCpuFeaturesLib also has the similar issue? If yes, I wi= ll > >provide > >> the patch to fix it. > >> > >> >-----Original Message----- > >> >From: Yao, Jiewen > >> >Sent: Thursday, December 07, 2017 10:52 AM > >> >To: Gao, Liming ; edk2-devel@lists.01.org > >> >Cc: Dong, Eric > >> >Subject: RE: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the > >missing > >> >ASM_PFX in nasm code > >> > > >> >Hi Liming > >> >Reviewed-by: Jiewen.yao@intel.com > >> > > >> >BTW: Do you think we also need update SmmCpuFeaturesLib ? > >> > > >> >Thank you > >> >Yao Jiewen > >> > > >> > > >> >> -----Original Message----- > >> >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > >Of > >> >Liming > >> >> Gao > >> >> Sent: Thursday, December 7, 2017 10:45 AM > >> >> To: edk2-devel@lists.01.org > >> >> Cc: Dong, Eric > >> >> Subject: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing > >> >> ASM_PFX in nasm code > >> >> > >> >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> >> Signed-off-by: Liming Gao > >> >> Cc: Eric Dong > >> >> --- > >> >> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 10 +++++----- > >> >> 1 file changed, 5 insertions(+), 5 deletions(-) > >> >> > >> >> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > >> >> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > >> >> index c3c094f..dc56dc7 100644 > >> >> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > >> >> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > >> >> @@ -1,5 +1,5 @@ > >> >> ;-----------------------------------------------------------------= ------------- ; > >> >> -; Copyright (c) 2016, Intel Corporation. All rights reserved.
> >> >> +; Copyright (c) 2016 - 2017, Intel Corporation. All rights reserve= d.
> >> >> ; This program and the accompanying materials > >> >> ; are licensed and made available under the terms and conditions o= f the > >BSD > >> >> License > >> >> ; which accompanies this distribution. The full text of the licen= se may > be > >> >found > >> >> at > >> >> @@ -184,15 +184,15 @@ _SmiHandler: > >> >> add rsp, -0x20 > >> >> > >> >> mov rcx, rbx > >> >> - mov rax, CpuSmmDebugEntry > >> >> + mov rax, ASM_PFX(CpuSmmDebugEntry) > >> >> call rax > >> >> > >> >> mov rcx, rbx > >> >> - mov rax, SmiRendezvous ; rax <- absolute addr of > >> >> SmiRedezvous > >> >> + mov rax, ASM_PFX(SmiRendezvous) ; rax <- absolute addr of > >> >> SmiRedezvous > >> >> call rax > >> >> > >> >> mov rcx, rbx > >> >> - mov rax, CpuSmmDebugExit > >> >> + mov rax, ASM_PFX(CpuSmmDebugExit) > >> >> call rax > >> >> > >> >> add rsp, 0x20 > >> >> @@ -220,5 +220,5 @@ _SmiHandler: > >> >> .1: > >> >> rsm > >> >> > >> >> -gcSmiHandlerSize DW $ - _SmiEntryPoint > >> >> +ASM_PFX(gcSmiHandlerSize) DW $ - _SmiEntryPoint > >> >> > >> >> -- > >> >> 2.8.0.windows.1 > >> >> > >> >> _______________________________________________ > >> >> edk2-devel mailing list > >> >> edk2-devel@lists.01.org > >> >> https://lists.01.org/mailman/listinfo/edk2-devel