From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [Patch] UefiCpuPkg: SmmCpuFeaturesLib Add the missing ASM_PFX in nasm code
Date: Thu, 7 Dec 2017 04:10:45 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA3C9C4@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1512618153-6308-1-git-send-email-liming.gao@intel.com>
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming
> Gao
> Sent: Thursday, December 7, 2017 11:43 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>
> Subject: [edk2] [Patch] UefiCpuPkg: SmmCpuFeaturesLib Add the missing
> ASM_PFX in nasm code
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> index bcac643..ea2d297 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> @@ -188,15 +188,15 @@ CommonHandler:
> add rsp, -0x20
>
> mov rcx, rbx
> - mov rax, CpuSmmDebugEntry
> + mov rax, ASM_PFX(CpuSmmDebugEntry)
> call rax
>
> mov rcx, rbx
> - mov rax, SmiRendezvous ; rax <- absolute addr of
> SmiRedezvous
> + mov rax, ASM_PFX(SmiRendezvous) ; rax <- absolute addr
> of SmiRedezvous
> call rax
>
> mov rcx, rbx
> - mov rax, CpuSmmDebugExit
> + mov rax, ASM_PFX(CpuSmmDebugExit)
> call rax
>
> add rsp, 0x20
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-12-07 4:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 3:42 [Patch] UefiCpuPkg: SmmCpuFeaturesLib Add the missing ASM_PFX in nasm code Liming Gao
2017-12-07 4:10 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AA3C9C4@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox