From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg PiSmmCore: Unregister each other for LegacyBoot and EBS
Date: Mon, 11 Dec 2017 13:20:52 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA42606@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1512981378-16992-1-git-send-email-star.zeng@intel.com>
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Zeng, Star
> Sent: Monday, December 11, 2017 4:36 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH] MdeModulePkg PiSmmCore: Unregister each other for
> LegacyBoot and EBS
>
> Otherwise, LegacyBoot may be triggered wrongly by other code in UEFI OS,
> or vice versa.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 22
> ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> index 6d266933868d..d516e9dcea34 100644
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> @@ -157,6 +157,7 @@ SmmLegacyBootHandler (
> {
> EFI_STATUS Status;
> EFI_HANDLE SmmHandle;
> + UINTN Index;
>
> //
> // Install SMM Legacy Boot protocol.
> @@ -173,6 +174,16 @@ SmmLegacyBootHandler (
>
> SmiHandlerUnRegister (DispatchHandle);
>
> + //
> + // It is legacy boot, unregister ExitBootService SMI handler.
> + //
> + for (Index = 0; mSmmCoreSmiHandlers[Index].HandlerType != NULL; Index++)
> {
> + if (CompareGuid (mSmmCoreSmiHandlers[Index].HandlerType,
> &gEfiEventExitBootServicesGuid)) {
> + SmiHandlerUnRegister
> (mSmmCoreSmiHandlers[Index].DispatchHandle);
> + break;
> + }
> + }
> +
> return Status;
> }
>
> @@ -201,6 +212,7 @@ SmmExitBootServicesHandler (
> {
> EFI_STATUS Status;
> EFI_HANDLE SmmHandle;
> + UINTN Index;
>
> //
> // Install SMM Exit Boot Services protocol.
> @@ -215,6 +227,16 @@ SmmExitBootServicesHandler (
>
> SmiHandlerUnRegister (DispatchHandle);
>
> + //
> + // It is UEFI boot, unregister LegacyBoot SMI handler.
> + //
> + for (Index = 0; mSmmCoreSmiHandlers[Index].HandlerType != NULL; Index++)
> {
> + if (CompareGuid (mSmmCoreSmiHandlers[Index].HandlerType,
> &gEfiEventLegacyBootGuid)) {
> + SmiHandlerUnRegister
> (mSmmCoreSmiHandlers[Index].DispatchHandle);
> + break;
> + }
> + }
> +
> return Status;
> }
>
> --
> 2.7.0.windows.1
prev parent reply other threads:[~2017-12-11 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 8:36 [PATCH] MdeModulePkg PiSmmCore: Unregister each other for LegacyBoot and EBS Star Zeng
2017-12-11 13:20 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AA42606@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox