From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: More than 10 MX records returned) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EDC1721A1099A for ; Tue, 12 Dec 2017 04:49:28 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2017 04:54:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,395,1508828400"; d="scan'208";a="183532140" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 12 Dec 2017 04:54:06 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Dec 2017 04:54:06 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Dec 2017 04:54:06 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 12 Dec 2017 20:54:04 +0800 From: "Yao, Jiewen" To: Laszlo Ersek , edk2-devel-01 CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error Thread-Index: AQHTc0dJUqtHBHvo7ESFYM+VhqF9VqM/qcFQ Date: Tue, 12 Dec 2017 12:54:03 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA43F8D@shsmsx102.ccr.corp.intel.com> References: <20171212124630.7637-1-lersek@redhat.com> In-Reply-To: <20171212124630.7637-1-lersek@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTExOTY1ZjAtOWI3YS00OWU5LWExY2YtMWE1ZDU2MWI2ZGYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJJdTJuQzFXejhSRkdCZ1hVR2NIa0xYbkJEbkpsSFQxREpWbklQWnVFT1k4Q0J6OFU0aU5uVlNqSHo4TnZkcklzIn0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 12:49:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks ,Laszlo. Reviewed-by: Jiewen.yao@intel.com Since it breaks the build, can we check in as soon as possible? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo > Ersek > Sent: Tuesday, December 12, 2017 8:47 PM > To: edk2-devel-01 > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error >=20 > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function > > 'SmmReadyToBootHandler': > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing > argument > > 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] > > ); > > ^ > > In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0: > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void > **' > > but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **' > > SmmLocateProtocol ( > > ^ > > cc1: all warnings being treated as errors >=20 > Cc: Eric Dong > Cc: Star Zeng > Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > index dbb89932e75b..1ccb9c7787ad 100644 > --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > @@ -319,7 +319,7 @@ SmmReadyToBootHandler ( > Status =3D SmmLocateProtocol ( > &gEfiSmmSxDispatch2ProtocolGuid, > NULL, > - &SxDispatch > + (VOID **)&SxDispatch > ); > if (!EFI_ERROR (Status)) { > // > -- > 2.14.1.3.gb7cf6e02401b >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel