From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8361E2218E922 for ; Thu, 21 Dec 2017 19:53:27 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 19:58:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,438,1508828400"; d="scan'208";a="189168447" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 21 Dec 2017 19:58:08 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Dec 2017 19:58:08 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Fri, 22 Dec 2017 11:57:59 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1 and 2 definitions Thread-Index: AQHTeXfSMC/VcxW9T0y0ZNo+zN+mbaNOvxxw Date: Fri, 22 Dec 2017 03:57:58 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AA5731D@SHSMSX104.ccr.corp.intel.com> References: <1513763352-7660-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1513763352-7660-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjNkZGE5NmQtYzU5NC00ZDUxLTgyZWMtNDZkODg5ODBjYjc2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJBVnlWSVpta0xBOEl5MEpQZzduQzhNZkRyS3N4YWlYeFpnam9HYnJIQkgxSis0OUVcL1wvbGVTTDdCZ2ZGTjdNUmIifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1 and 2 definitions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 03:53:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of St= ar > Zeng > Sent: Wednesday, December 20, 2017 5:49 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming ; > Zeng, Star > Subject: [edk2] [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1 > and 2 definitions >=20 > Same change is done for Acpi61.h. >=20 > Cc: Jiewen Yao > Cc: Liming Gao > Cc: Chasel Chiu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdePkg/Include/IndustryStandard/Acpi60.h | 48 > +++++++++++++++++++++++++++++++- > MdePkg/Include/IndustryStandard/Acpi61.h | 48 > +++++++++++++++++++++++++++++++- > 2 files changed, 94 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h > b/MdePkg/Include/IndustryStandard/Acpi60.h > index 6183d8a9bd6c..29c16f48405d 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi60.h > +++ b/MdePkg/Include/IndustryStandard/Acpi60.h > @@ -2020,7 +2020,9 @@ typedef struct { > // > // PCCT Subspace type > // > -#define EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_GENERIC 0x00 > +#define EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_GENERIC > 0x00 > +#define > EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_1_HW_REDUCED_COMMUNICATIONS > 0x01 > +#define > EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_2_HW_REDUCED_COMMUNICATIONS > 0x02 >=20 > /// > /// PCC Subspace Structure Header > @@ -2072,6 +2074,50 @@ typedef struct { > EFI_ACPI_6_0_PCCT_GENERIC_SHARED_MEMORY_REGION_STATUS > Status; > } EFI_ACPI_6_0_PCCT_GENERIC_SHARED_MEMORY_REGION_HEADER; >=20 > +#define > EFI_ACPI_6_0_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_POLARITY > BIT0 > +#define > EFI_ACPI_6_0_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_MODE > BIT1 > + > +/// > +/// Type 1 HW-Reduced Communications Subspace Structure > +/// > +typedef struct { > + UINT8 Type; > + UINT8 Length; > + UINT32 DoorbellInterrupt; > + UINT8 DoorbellInterruptFlags; > + UINT8 Reserved; > + UINT64 BaseAddress; > + UINT64 AddressLength; > + EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellRegister; > + UINT64 DoorbellPreserve; > + UINT64 DoorbellWrite; > + UINT32 NominalLatency; > + UINT32 > MaximumPeriodicAccessRate; > + UINT16 > MinimumRequestTurnaroundTime; > +} EFI_ACPI_6_0_PCCT_SUBSPACE_1_HW_REDUCED_COMMUNICATIONS; > + > +/// > +/// Type 2 HW-Reduced Communications Subspace Structure > +/// > +typedef struct { > + UINT8 Type; > + UINT8 Length; > + UINT32 DoorbellInterrupt; > + UINT8 DoorbellInterruptFlags; > + UINT8 Reserved; > + UINT64 BaseAddress; > + UINT64 AddressLength; > + EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellRegister; > + UINT64 DoorbellPreserve; > + UINT64 DoorbellWrite; > + UINT32 NominalLatency; > + UINT32 > MaximumPeriodicAccessRate; > + UINT16 > MinimumRequestTurnaroundTime; > + EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellAckRegister; > + UINT64 DoorbellAckPreserve; > + UINT64 DoorbellAckWrite; > +} EFI_ACPI_6_0_PCCT_SUBSPACE_2_HW_REDUCED_COMMUNICATIONS; > + > // > // Known table signatures > // > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h > b/MdePkg/Include/IndustryStandard/Acpi61.h > index 0fac9a80694d..4a370c27e012 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > @@ -2052,7 +2052,9 @@ typedef struct { > // > // PCCT Subspace type > // > -#define EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_GENERIC 0x00 > +#define EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_GENERIC > 0x00 > +#define > EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_1_HW_REDUCED_COMMUNICATIONS > 0x01 > +#define > EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_2_HW_REDUCED_COMMUNICATIONS > 0x02 >=20 > /// > /// PCC Subspace Structure Header > @@ -2104,6 +2106,50 @@ typedef struct { > EFI_ACPI_6_1_PCCT_GENERIC_SHARED_MEMORY_REGION_STATUS > Status; > } EFI_ACPI_6_1_PCCT_GENERIC_SHARED_MEMORY_REGION_HEADER; >=20 > +#define > EFI_ACPI_6_1_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_POLARITY > BIT0 > +#define > EFI_ACPI_6_1_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_MODE > BIT1 > + > +/// > +/// Type 1 HW-Reduced Communications Subspace Structure > +/// > +typedef struct { > + UINT8 Type; > + UINT8 Length; > + UINT32 DoorbellInterrupt; > + UINT8 DoorbellInterruptFlags; > + UINT8 Reserved; > + UINT64 BaseAddress; > + UINT64 AddressLength; > + EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellRegister; > + UINT64 DoorbellPreserve; > + UINT64 DoorbellWrite; > + UINT32 NominalLatency; > + UINT32 > MaximumPeriodicAccessRate; > + UINT16 > MinimumRequestTurnaroundTime; > +} EFI_ACPI_6_1_PCCT_SUBSPACE_1_HW_REDUCED_COMMUNICATIONS; > + > +/// > +/// Type 2 HW-Reduced Communications Subspace Structure > +/// > +typedef struct { > + UINT8 Type; > + UINT8 Length; > + UINT32 DoorbellInterrupt; > + UINT8 DoorbellInterruptFlags; > + UINT8 Reserved; > + UINT64 BaseAddress; > + UINT64 AddressLength; > + EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellRegister; > + UINT64 DoorbellPreserve; > + UINT64 DoorbellWrite; > + UINT32 NominalLatency; > + UINT32 > MaximumPeriodicAccessRate; > + UINT16 > MinimumRequestTurnaroundTime; > + EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellAckRegister; > + UINT64 DoorbellAckPreserve; > + UINT64 DoorbellAckWrite; > +} EFI_ACPI_6_1_PCCT_SUBSPACE_2_HW_REDUCED_COMMUNICATIONS; > + > // > // Known table signatures > // > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel