[PATCH] IntelSiliconPkg IntelVTdDxe: Remove mVtdHostAddressWidthMask

[PATCH] IntelSiliconPkg IntelVTdDxe: Remove mVtdHostAddressWidthMask

[Star Zeng]

mVtdHostAddressWidthMask is not been used at all,
its definition and related code could be removed.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h | 1 -
 IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 2 --
 IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c        | 3 +--
 3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
index 767531e4a93f..2ec92fe523c3 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
@@ -124,7 +124,6 @@ EFI_STATUS
 
 extern EFI_ACPI_DMAR_HEADER  *mAcpiDmarTable;
 
-extern UINT64                           mVtdHostAddressWidthMask;
 extern UINTN                            mVtdUnitNumber;
 extern VTD_UNIT_INFORMATION             *mVtdUnitInformation;
 
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
index 342830a01fb0..24ad47edc543 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
@@ -806,8 +806,6 @@ ParseDmarAcpiTableDrhd (
     return EFI_OUT_OF_RESOURCES;
   }
 
-  mVtdHostAddressWidthMask = LShiftU64 (1ull, mAcpiDmarTable->HostAddressWidth) - 1;
-
   VtdIndex = 0;
   DmarHeader = (EFI_ACPI_DMAR_STRUCTURE_HEADER *)((UINTN)(mAcpiDmarTable + 1));
   while ((UINTN)DmarHeader < (UINTN)mAcpiDmarTable + mAcpiDmarTable->Header.Length) {
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c
index 1404af7cd781..bc9f427a3686 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c
@@ -1,6 +1,6 @@
 /** @file
 
-  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
@@ -13,7 +13,6 @@
 
 #include "DmaProtection.h"
 
-UINT64                           mVtdHostAddressWidthMask;
 UINTN                            mVtdUnitNumber;
 VTD_UNIT_INFORMATION             *mVtdUnitInformation;
 
-- 
2.7.0.windows.1

Re: [PATCH] IntelSiliconPkg IntelVTdDxe: Remove mVtdHostAddressWidthMask

[Yao, Jiewen]

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Tuesday, January 16, 2018 7:05 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] IntelSiliconPkg IntelVTdDxe: Remove
> mVtdHostAddressWidthMask
> 
> mVtdHostAddressWidthMask is not been used at all,
> its definition and related code could be removed.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h | 1 -
>  IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 2 --
>  IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c        | 3 +--
>  3 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> index 767531e4a93f..2ec92fe523c3 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> @@ -124,7 +124,6 @@ EFI_STATUS
> 
>  extern EFI_ACPI_DMAR_HEADER  *mAcpiDmarTable;
> 
> -extern UINT64                           mVtdHostAddressWidthMask;
>  extern UINTN                            mVtdUnitNumber;
>  extern VTD_UNIT_INFORMATION             *mVtdUnitInformation;
> 
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> index 342830a01fb0..24ad47edc543 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> @@ -806,8 +806,6 @@ ParseDmarAcpiTableDrhd (
>      return EFI_OUT_OF_RESOURCES;
>    }
> 
> -  mVtdHostAddressWidthMask = LShiftU64 (1ull,
> mAcpiDmarTable->HostAddressWidth) - 1;
> -
>    VtdIndex = 0;
>    DmarHeader = (EFI_ACPI_DMAR_STRUCTURE_HEADER
> *)((UINTN)(mAcpiDmarTable + 1));
>    while ((UINTN)DmarHeader < (UINTN)mAcpiDmarTable +
> mAcpiDmarTable->Header.Length) {
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c
> b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c
> index 1404af7cd781..bc9f427a3686 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c
> @@ -1,6 +1,6 @@
>  /** @file
> 
> -  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be
> found at
> @@ -13,7 +13,6 @@
> 
>  #include "DmaProtection.h"
> 
> -UINT64                           mVtdHostAddressWidthMask;
>  UINTN                            mVtdUnitNumber;
>  VTD_UNIT_INFORMATION             *mVtdUnitInformation;
> 
> --
> 2.7.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel