* [PATCH] SecurityPkg: Disable TPM interrupt in DEC
@ 2018-01-30 1:17 Zhang, Chao B
2018-01-30 1:23 ` Yao, Jiewen
2018-01-30 1:32 ` Long, Qin
0 siblings, 2 replies; 3+ messages in thread
From: Zhang, Chao B @ 2018-01-30 1:17 UTC (permalink / raw)
To: edk2-devel; +Cc: Yao Jiewen, Long Qin, Chao Zhang
Disable TPM interrupt support in DEC
Cc: Yao Jiewen <jiewen.yao@intel.com>
Cc: Long Qin <qin.long@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
---
SecurityPkg/SecurityPkg.dec | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index d2741f6..983fb0e 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b/SecurityPkg/SecurityPkg.dec
@@ -453,12 +453,12 @@
## Indicate current TPM2 Interrupt Number reported by _CRS control method.<BR><BR>
# TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
# @Prompt Current TPM2 Interrupt Number
- gEfiSecurityPkgTokenSpaceGuid.PcdTpm2CurrentIrqNum|0x0C|UINT32|0x0001001C
+ gEfiSecurityPkgTokenSpaceGuid.PcdTpm2CurrentIrqNum|0x00|UINT32|0x0001001C
## Indicate platform possible TPM2 Interrupt Number reported by _PRS control method.<BR><BR>
# Possible TPM2 Interrupt Number Buffer will not be reported if TPM2 Interrupt feature is disabled.<BR>
# @Prompt Possible TPM2 Interrupt Number buffer
- gEfiSecurityPkgTokenSpaceGuid.PcdTpm2PossibleIrqNumBuf|{0x0C, 0x00, 0x00, 0x00}|VOID*|0x0001001D
+ gEfiSecurityPkgTokenSpaceGuid.PcdTpm2PossibleIrqNumBuf|{0x00, 0x00, 0x00, 0x00}|VOID*|0x0001001D
[PcdsDynamic, PcdsDynamicEx]
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] SecurityPkg: Disable TPM interrupt in DEC
2018-01-30 1:17 [PATCH] SecurityPkg: Disable TPM interrupt in DEC Zhang, Chao B
@ 2018-01-30 1:23 ` Yao, Jiewen
2018-01-30 1:32 ` Long, Qin
1 sibling, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2018-01-30 1:23 UTC (permalink / raw)
To: Zhang, Chao B, edk2-devel@lists.01.org; +Cc: Long, Qin
Thanks.
Would you please update comment with - "Disable TPM interrupt support in DEC by default to keep compatibility"
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Zhang, Chao B
> Sent: Tuesday, January 30, 2018 9:17 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Long, Qin <qin.long@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH] SecurityPkg: Disable TPM interrupt in DEC
>
> Disable TPM interrupt support in DEC
>
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Cc: Long Qin <qin.long@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
> SecurityPkg/SecurityPkg.dec | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
> index d2741f6..983fb0e 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -453,12 +453,12 @@
> ## Indicate current TPM2 Interrupt Number reported by _CRS control
> method.<BR><BR>
> # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
> # @Prompt Current TPM2 Interrupt Number
> -
> gEfiSecurityPkgTokenSpaceGuid.PcdTpm2CurrentIrqNum|0x0C|UINT32|0x0001
> 001C
> +
> gEfiSecurityPkgTokenSpaceGuid.PcdTpm2CurrentIrqNum|0x00|UINT32|0x0001
> 001C
>
> ## Indicate platform possible TPM2 Interrupt Number reported by _PRS
> control method.<BR><BR>
> # Possible TPM2 Interrupt Number Buffer will not be reported if TPM2
> Interrupt feature is disabled.<BR>
> # @Prompt Possible TPM2 Interrupt Number buffer
> - gEfiSecurityPkgTokenSpaceGuid.PcdTpm2PossibleIrqNumBuf|{0x0C, 0x00,
> 0x00, 0x00}|VOID*|0x0001001D
> + gEfiSecurityPkgTokenSpaceGuid.PcdTpm2PossibleIrqNumBuf|{0x00, 0x00,
> 0x00, 0x00}|VOID*|0x0001001D
>
> [PcdsDynamic, PcdsDynamicEx]
>
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SecurityPkg: Disable TPM interrupt in DEC
2018-01-30 1:17 [PATCH] SecurityPkg: Disable TPM interrupt in DEC Zhang, Chao B
2018-01-30 1:23 ` Yao, Jiewen
@ 2018-01-30 1:32 ` Long, Qin
1 sibling, 0 replies; 3+ messages in thread
From: Long, Qin @ 2018-01-30 1:32 UTC (permalink / raw)
To: Zhang, Chao B, edk2-devel@lists.01.org; +Cc: Yao, Jiewen
Reviewed-by: Long Qin <qin.long@intel.com>
Best Regards & Thanks,
LONG, Qin
-----Original Message-----
From: Zhang, Chao B
Sent: Tuesday, January 30, 2018 9:17 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Long, Qin <qin.long@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
Subject: [PATCH] SecurityPkg: Disable TPM interrupt in DEC
Disable TPM interrupt support in DEC
Cc: Yao Jiewen <jiewen.yao@intel.com>
Cc: Long Qin <qin.long@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
---
SecurityPkg/SecurityPkg.dec | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec index d2741f6..983fb0e 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b/SecurityPkg/SecurityPkg.dec
@@ -453,12 +453,12 @@
## Indicate current TPM2 Interrupt Number reported by _CRS control method.<BR><BR>
# TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
# @Prompt Current TPM2 Interrupt Number
- gEfiSecurityPkgTokenSpaceGuid.PcdTpm2CurrentIrqNum|0x0C|UINT32|0x0001001C
+
+ gEfiSecurityPkgTokenSpaceGuid.PcdTpm2CurrentIrqNum|0x00|UINT32|0x00010
+ 01C
## Indicate platform possible TPM2 Interrupt Number reported by _PRS control method.<BR><BR>
# Possible TPM2 Interrupt Number Buffer will not be reported if TPM2 Interrupt feature is disabled.<BR>
# @Prompt Possible TPM2 Interrupt Number buffer
- gEfiSecurityPkgTokenSpaceGuid.PcdTpm2PossibleIrqNumBuf|{0x0C, 0x00, 0x00, 0x00}|VOID*|0x0001001D
+ gEfiSecurityPkgTokenSpaceGuid.PcdTpm2PossibleIrqNumBuf|{0x00, 0x00,
+ 0x00, 0x00}|VOID*|0x0001001D
[PcdsDynamic, PcdsDynamicEx]
--
1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-30 1:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-30 1:17 [PATCH] SecurityPkg: Disable TPM interrupt in DEC Zhang, Chao B
2018-01-30 1:23 ` Yao, Jiewen
2018-01-30 1:32 ` Long, Qin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox