From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C4B76223CCEE5 for ; Thu, 1 Feb 2018 19:41:35 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 19:47:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,445,1511856000"; d="scan'208";a="26690766" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 01 Feb 2018 19:47:13 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Feb 2018 19:47:12 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Fri, 2 Feb 2018 11:47:11 +0800 From: "Yao, Jiewen" To: "Fu, Siyuan" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE if failed to read system GUID from SMBIOS. Thread-Index: AQHTm9X+qTbzjuplWUGZemwmbb1mWaOQeMpw Date: Fri, 2 Feb 2018 03:47:10 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AAA3E4D@shsmsx102.ccr.corp.intel.com> References: <20180202032858.12824-1-siyuan.fu@intel.com> In-Reply-To: <20180202032858.12824-1-siyuan.fu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTU3M2MyNmItYmM5YS00OWY5LWFhYzUtZTExMzExYTgyZDljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJKSUFWR1wvdndDUThzU1JSV0NvU0lNaGpsNVdyWVVJakVFUjB3eE5UTU9DaUlNb3ZYWjF0REoycGNMeXh6ZkNYSCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/2] NetworkPkg: Add warning message for PXE if failed to read system GUID from SMBIOS. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 03:41:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Siyuan It is great idea to add such warning message to help debug such PXE issue. Do you think it will be better if we add such info in NetLib - NetLibGetSys= temGuid(). As such, we don't need update all consumers. Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Friday, February 2, 2018 11:29 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE if fa= iled > to read system GUID from SMBIOS. >=20 > Current PXE driver uses zero GUID if failed to get the system GUID from s= mbios > table, and some OS PXE boot may fail in such case. This patch is to add a= warning > message to inform user that smbios table is missed on the platform. >=20 > Fu Siyuan (2): > NetworkPkg: Add warning message for PXE if failed to read system GUID > from SMBIOS. > MdeModulePkg/PXE: Add warning message for PXE if failed to read system > GUID from SMBIOS. >=20 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c | 5 ++++- > NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 3 +++ > NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 1 + > 3 files changed, 8 insertions(+), 1 deletion(-) >=20 > -- > 2.13.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel