Re: [Patch 0/2] NetworkPkg: Add warning message for PXE if failed to read system GUID from SMBIOS.

["Yao, Jiewen" <jiewen.yao@intel.com>]

Got it. I agree.

> -----Original Message-----
> From: Fu, Siyuan
> Sent: Friday, February 2, 2018 11:49 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE if
> failed to read system GUID from SMBIOS.
> 
> Jiewen,
> 
> NetLibGetSystemGuid is also used by some other drivers like DHCP6, and it's
> acceptable to not use system GUID as client identifier in DHCP protocol. That's
> why I only add the warning in PXE driver.
> 
> BestRegards
> Fu Siyuan
> 
> > -----Original Message-----
> > From: Yao, Jiewen
> > Sent: Friday, February 2, 2018 11:47 AM
> > To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org
> > Subject: RE: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE if
> > failed to read system GUID from SMBIOS.
> >
> > Hi Siyuan
> > It is great idea to add such warning message to help debug such PXE issue.
> >
> > Do you think it will be better if we add such info in NetLib -
> > NetLibGetSystemGuid().
> >
> > As such, we don't need update all consumers.
> >
> > Thank you
> > Yao Jiewen
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Fu
> > > Siyuan
> > > Sent: Friday, February 2, 2018 11:29 AM
> > > To: edk2-devel@lists.01.org
> > > Subject: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE if
> > failed
> > > to read system GUID from SMBIOS.
> > >
> > > Current PXE driver uses zero GUID if failed to get the system GUID from
> > smbios
> > > table, and some OS PXE boot may fail in such case. This patch is to add
> > a warning
> > > message to inform user that smbios table is missed on the platform.
> > >
> > > Fu Siyuan (2):
> > >   NetworkPkg: Add warning message for PXE if failed to read system GUID
> > >     from SMBIOS.
> > >   MdeModulePkg/PXE: Add warning message for PXE if failed to read
> system
> > >     GUID from SMBIOS.
> > >
> > >  MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c | 5 ++++-
> > >  NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c                    | 3 +++
> > >  NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c                     | 1 +
> > >  3 files changed, 8 insertions(+), 1 deletion(-)
> > >
> > > --
> > > 2.13.0.windows.1
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel